Re: [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Fixes #4829. Introduces a new ZFS install option `arc_max` (aptly named > after the corresponding module option `zfs_arc_max`). > > For PVE installations, this can be adjusted when creating a ZFS RAID > under "Advanced Options". The default value i

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * No changes > > Proxmox/Install.pm| 4 > Proxmox/Install/Config.pm | 1 + > Proxmox/Install/RunEnv.pm | 38 ++ > 3 files changed, 43

[pve-devel] applied: [PATCH manager 1/3] ui: tags: fix focus for edit mode

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:36 schrieb Dominik Csapak: > such that one can tab through the editable tag fields. > We have to handle that manually, since ExtJs does not expect > contenteditable html tags for focus handling. > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/Tag.js | 9 +

Re: [pve-devel] [PATCH manager 3/3] ui: wizards: allow adding tags in the qemu/lxc create wizard

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:36 schrieb Dominik Csapak: > in the general tab in the advanced section. > > For that to work, we introduce a new option for the TagEditContainer > named 'editOnly', which controls now the cancel/finish buttons, > automatically enter edit mode and disable enter/escape keypresse

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-24 Thread Filip Schauer
A patch v2 is available: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059617.html On 20/10/2023 10:39, Dominik Csapak wrote: On 10/20/23 10:29, Thomas Lamprecht wrote: Am 20/10/2023 um 09:51 schrieb Dominik Csapak: On 10/20/23 09:08, Wolfgang Bumiller wrote: Also, Dominik recen

[pve-devel] [PATCH v2 guest-common 1/1] Add foreach_passthrough_device

2023-10-24 Thread Filip Schauer
Add a function to iterate over passthrough devices of a provided container config. Signed-off-by: Filip Schauer --- src/PVE/AbstractConfig.pm | 44 +++ 1 file changed, 44 insertions(+) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index a

[pve-devel] [PATCH many v2] Add container device passthrough

2023-10-24 Thread Filip Schauer
Changes since v2: * mknod the devices in /var/lib/lxc/$vmid/passthrough and setup proper permissions instead of bind mounting the devices from /dev directly * Add support for USB mapping * Add foreach_passthrough_device helper function pve-container: Filip Schauer (1): Add device passthrough

[pve-devel] [PATCH v2 container 1/1] Add device passthrough

2023-10-24 Thread Filip Schauer
Add a dev[n] argument to the container config to pass devices through to a container. A device can be passed by its path. Alternatively a mapped USB device can be passed through with usbmapping=. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 34 +++- src/PVE/LXC/Co

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-24 Thread DERUMIER, Alexandre
>>So I think the best way for now is to restart the target vm. >> >>Sure! Going with that is a much cleaner approach then. I'll try to send a v5 today with you're last comments. I don't manage yet the unused disks, I need to test with blockdev, but if it's work, I think we'll need to add config

[pve-devel] applied: [PATCH widget-toolkit] text field: add trimValue config

2023-10-24 Thread Thomas Lamprecht
Inspired by a recent bug detected in the subscription key field, where a trailing white space caused verification issues. We might even enable the trimming by default, after checking call sites that is – most often one wants to trim the text to be submitted Signed-off-by: Thomas Lamprecht --- h

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi there. Now, that's a good option in the installer. I wonder if this option will be available post-intall, like some box in the ZFS manager from WEB GUI! That's would be nice. Em ter., 24 de out. de 2023 às 08:55, Christoph Heiss escreveu: > Signed-off-by: Christoph

[pve-devel] [PATCH installer v2 6/6] fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE installations

2023-10-24 Thread Christoph Heiss
To set the maximum value for arc_max accordingly, simply pass down `RuntimeInfo` directly instead of the disks array to the views. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Fix ZFS_ARC_MIN_SIZE to be MiB rather than bytes proxmox-tui-installer/src/main.rs | 2 +- proxm

[pve-devel] [PATCH installer v2 3/6] fix #4829: test: add tests for new zfs_arc_max calculations

2023-10-24 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes Makefile| 3 ++ debian/control | 1 + test/Makefile | 10 ++ test/zfs-arc-max.pl | 81 + 4 files changed, 95 insertions(+) create mode 100644 test/Makefil

[pve-devel] [PATCH installer v2 2/6] fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE installations

2023-10-24 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes proxinstall | 15 +++ 1 file changed, 15 insertions(+) diff --git a/proxinstall b/proxinstall index 64c8bab..f1a3c02 100755 --- a/proxinstall +++ b/proxinstall @@ -1162,6 +1162,21 @@ my $create_raid_advanced_grid =

[pve-devel] [PATCH installer v2 5/6] fix #4829: tui: setup: add new ZFS `arc_max` option

2023-10-24 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * Updated comment for ZfsBootdiskOptions::defaults_from() accordingly proxmox-tui-installer/src/options.rs| 52 +++-- proxmox-tui-installer/src/setup.rs | 2 + proxmox-tui-installer/src/views/bootdisk.rs |

[pve-devel] [PATCH installer v2 4/6] tui: views: add optional suffix label for `NumericEditView`s

2023-10-24 Thread Christoph Heiss
Most of the churn here is due to changing the inner view from an `EditView` to a `LinearLayout`. Also prompted the introduction of two small helpers .inner() and .inner_mut() to simplify things everywhere else in the view. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes prox

[pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer

2023-10-24 Thread Christoph Heiss
Fixes #4829. Introduces a new ZFS install option `arc_max` (aptly named after the corresponding module option `zfs_arc_max`). For PVE installations, this can be adjusted when creating a ZFS RAID under "Advanced Options". The default value is choosen as 10% of system memory, clamped to between 64 M

[pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes Proxmox/Install.pm| 4 Proxmox/Install/Config.pm | 1 + Proxmox/Install/RunEnv.pm | 38 ++ 3 files changed, 43 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.p

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 12:51 schrieb Dominik Csapak: > On 10/24/23 12:07, Thomas Lamprecht wrote: >> OK, let's make "no special cases for browsers" a rule that should have as >> few as possible exceptions, that can only benefit users and devs reproducing >> issues. > > that makes sense, i'll add a secti

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Dominik Csapak
On 10/24/23 12:07, Thomas Lamprecht wrote: Am 24/10/2023 um 11:57 schrieb Dominik Csapak: On 10/24/23 11:53, Thomas Lamprecht wrote: Am 19/10/2023 um 15:59 schrieb Dominik Csapak: sry disregard this patch only, that property value is not supported in firefox :( We could set it only to "pla

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 11:57 schrieb Dominik Csapak: > On 10/24/23 11:53, Thomas Lamprecht wrote: >> Am 19/10/2023 um 15:59 schrieb Dominik Csapak: >>> sry disregard this patch only, that property value is not supported in >>> firefox :( >>> >> >> We could set it only to "plaintext-only" for non-firefox

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Dominik Csapak
On 10/24/23 11:53, Thomas Lamprecht wrote: Am 19/10/2023 um 15:59 schrieb Dominik Csapak: sry disregard this patch only, that property value is not supported in firefox :( We could set it only to "plaintext-only" for non-firefox then though? sure not a problem, i just generally try to avoi

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:59 schrieb Dominik Csapak: > sry disregard this patch only, that property value is not supported in > firefox :( > We could set it only to "plaintext-only" for non-firefox then though? ___ pve-devel mailing list pve-devel@lists.pr

[pve-devel] applied: [PATCH qemu-server] Fix: cpu hotplug feature can't be changed online

2023-10-24 Thread Thomas Lamprecht
Am 10/10/2023 um 17:37 schrieb Alexandre Derumier: > The cpus are passed as devices with specific id only when cpu hotplug is > enable > at start. > We can't enable/disable it online or vcpu hotplug api will thrown errors > not finding core id. > > Signed-off-by: Alexandre Derumier > --- > PVE/

Re: [pve-devel] [PATCH acme 1/5] fix #4497: add support for external account bindings

2023-10-24 Thread Thomas Lamprecht
mostly stylistic nits inline, but also a comment w.r.t. FWICT needles ABI breakage. Am 23/10/2023 um 15:18 schrieb Folke Gleumes: > implementation acording to rfc855 section 7.3.4 s/acording/according/ > > Signed-off-by: Folke Gleumes > --- > src/PVE/ACME.pm | 43 +

Re: [pve-devel] [PATCH manager 3/5] fix #4497: api/acme: deprecate tos endpoint in favor of meta

2023-10-24 Thread Fabian Grünbichler
On October 23, 2023 3:18 pm, Folke Gleumes wrote: > The ToS endpoint ignored data that is needed to detect if EAB needs to > be used. Instead of adding a new endpoint that does the same request, > the tos endpoint is deprecated and replaced by the meta endpoint, > that returns all information retur

Re: [pve-devel] [PATCH acme 1/5] fix #4497: add support for external account bindings

2023-10-24 Thread Fabian Grünbichler
On October 23, 2023 3:18 pm, Folke Gleumes wrote: > implementation acording to rfc855 section 7.3.4 > > Signed-off-by: Folke Gleumes > --- > src/PVE/ACME.pm | 43 +++ > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff --git a/src/PVE/ACME.pm b/sr

Re: [pve-devel] [PATCH manager 2/5] fix #4497: acme: add support for external account bindings

2023-10-24 Thread Fabian Grünbichler
On October 23, 2023 3:18 pm, Folke Gleumes wrote: > Signed-off-by: Folke Gleumes > --- > PVE/API2/ACMEAccount.pm | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm > index b790843a..daae18d8 10064

Re: [pve-devel] [PATCH acme/manager 0/5] fix #4497: add external account binding support

2023-10-24 Thread Fabian Grünbichler
On October 23, 2023 3:18 pm, Folke Gleumes wrote: > This patch series adds functionality to use acme directiories > that require the use of external account binding, as specified > in rfc 8555 section 7.3.4. > > To avoid code duplication and redundant calls to the CA, > the `/cluster/acme/tos` end

Re: [pve-devel] [PATCH manager 4/5] fix #4497: cli/acme: detect eab and ask for credentials

2023-10-24 Thread Fabian Grünbichler
On October 23, 2023 3:18 pm, Folke Gleumes wrote: > Since external account binding is advertised the same way as the ToS, > it can be detected when creating an account and asked for if needed. > > Signed-off-by: Folke Gleumes > --- > PVE/CLI/pvenode.pm | 16 ++-- > 1 file changed, 14

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-24 Thread Fiona Ebner
Am 23.10.23 um 20:03 schrieb DERUMIER, Alexandre: > Hi Fiona, > > >>> In case of 'restart' migration, we do want to start the VM anyways, >>> so >>> it's actually better, because we can catch config issues early :) Now >>> that I think about it, can we also just start the target VM in >>> prelaun

Re: [pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available

2023-10-24 Thread Christoph Heiss
On Fri, Oct 20, 2023 at 05:21:41PM +0200, Thomas Lamprecht wrote: > > Am 20/10/2023 um 11:46 schrieb Christoph Heiss: > > DHCP servers can set option 12 ("host-name") for client leases [0], > > telling them about their hostname. It's very much non-invasive and falls > > back to the default values