Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Fixes #4829. Introduces a new ZFS install option `arc_max` (aptly named > after the corresponding module option `zfs_arc_max`). > > For PVE installations, this can be adjusted when creating a ZFS RAID > under "Advanced Options". The default value is choosen as 10% of system > memory, clamped to between 64 MiB as lower limit and 16 GiB as upper > limit. For PBS and PMG, the option is (currently) hidden. > > If the option is set to a non-zero value, a new file > /etc/modprobe.d/zfs.conf gets written during install, setting the > `zfs_arc_max` module option as appropriate. > > Tested by installing PVE, PBS and PMG. For PVE, checked that the `zfs` > module option gets correctly written & applied, the latter by looking at > the output of `arc_summary`. For PBS and PMG, verified that no modprobe > options file is created and the ARC size is set to default. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2023-August/058830.html > > Notable changes v1 -> v2: > * Rebased on latest master > * Fix arc_max value set in TUI not being applied correctly > > Christoph Heiss (6): > fix #4829: install: add new ZFS `arc_max` setup option > fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE > installations > fix #4829: test: add tests for new zfs_arc_max calculations > tui: views: add optional suffix label for `NumericEditView`s > fix #4829: tui: setup: add new ZFS `arc_max` option > fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE > installations >
looks OK bis of a few comments in the first patch, I can fix those up too, but maybe it's quicker if just send a v3, if you agree with them. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
