Re: [pve-devel] [PATCH manager master stable-7] pve7to8: Fix Fedora 38 systemd unified cgroupv2 check

2023-09-26 Thread Christian Ebner
Ping, see also https://forum.proxmox.com/threads/128721/ > On 28.08.2023 09:54 CEST Christian Ebner wrote: > > > For Fedora 38 the systemd shared object files used to check the systemd > version are located at /usr/lib64/systemd or /usr/lib/systemd. > Therefore, include /usr/lib64/systemd in t

Re: [pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-26 Thread DERUMIER, Alexandre
Le mardi 26 septembre 2023 à 16:12 +0200, Stefan Hanreich a écrit : > > Yes, this is my main concern, as it'll be my case in production, as > > I > > managing multiple clusters, on differents location, with subnets > > sharing. > > > > for me, it's ok if ipam is down when allocating a new ip or vm

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Thomas Lamprecht
Am 26/09/2023 um 16:54 schrieb Philipp Hufnagl: > On 9/26/23 16:23, Thomas Lamprecht wrote: >> Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl: >>> On 9/26/23 12:56, Thomas Lamprecht wrote: while this is already applied, some comments inline, for a possible next time, and also the big

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
On 9/26/23 16:23, Thomas Lamprecht wrote: > Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl: >> On 9/26/23 12:56, Thomas Lamprecht wrote: >>> while this is already applied, some comments inline, for a possible next >>> time, and also the big >>> question if this is even required, after all I can jus

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Thomas Lamprecht
Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl: > On 9/26/23 12:56, Thomas Lamprecht wrote: >> while this is already applied, some comments inline, for a possible next >> time, and also the big >> question if this is even required, after all I can just check the few >> compression algorithms easily

Re: [pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-26 Thread Stefan Hanreich
> Yes, this is my main concern, as it'll be my case in production, as I > managing multiple clusters, on differents location, with subnets > sharing. > > for me, it's ok if ipam is down when allocating a new ip or vm. > But for vm start/stop, I think we should have at minimum some cache > somewher

Re: [pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-26 Thread DERUMIER, Alexandre
Le mardi 26 septembre 2023 à 13:20 +0200, Stefan Hanreich a écrit : > On 9/20/23 23:48, DERUMIER, Alexandre wrote: > > Finally, It's not so easy without writing ip on proxmox side (in vm > > config or somewhere else), because to retrieve a reserved ip from > > external ipam when vm start, we need t

Re: [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
On 9/26/23 12:59, Thomas Lamprecht wrote: > Am 21/09/2023 um 15:09 schrieb Philipp Hufnagl: >> extends the download iso prompt with a "compression algorithm" drop down >> under advanced. User can configure there if a decompression algorithm >> should be used from the storage backend. The compressio

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
On 9/26/23 12:56, Thomas Lamprecht wrote: > while this is already applied, some comments inline, for a possible next > time, and also the big > question if this is even required, after all I can just check the few > compression algorithms easily in the frontend, i.e., offloading a simple > string r

Re: [pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-26 Thread Stefan Hanreich
On 9/20/23 23:48, DERUMIER, Alexandre wrote: Finally, It's not so easy without writing ip on proxmox side (in vm config or somewhere else), because to retrieve a reserved ip from external ipam when vm start, we need to lookup maybe from mac address, maybe from hostname of the vm, or maybe some cu

Re: [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-26 Thread Thomas Lamprecht
Am 21/09/2023 um 15:09 schrieb Philipp Hufnagl: > extends the download iso prompt with a "compression algorithm" drop down > under advanced. User can configure there if a decompression algorithm > should be used from the storage backend. The compression algorithm will > be automatically guessed whe

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Thomas Lamprecht
while this is already applied, some comments inline, for a possible next time, and also the big question if this is even required, after all I can just check the few compression algorithms easily in the frontend, i.e., offloading a simple string regex match to the backend seems rather odd to me..

[pve-devel] applied: [PATCH pve-kernel] cherry-pick fix for new amd64 ucode

2023-09-26 Thread Thomas Lamprecht
Am 25/09/2023 um 19:23 schrieb Stoiko Ivanov: > The latest amd64-microcode package in sid [0] (which probably will > eventually make it to bookworm-security) has a change that requires > the added patch to work properly. > > The changelog-entry refers to stable k.o branches only - but a quick > lo

[pve-devel] applied: [PATCH qemu] fix #2874: SATA: avoid unsolicited write to sector 0 during reset

2023-09-26 Thread Thomas Lamprecht
Am 24/08/2023 um 15:51 schrieb Fiona Ebner: > If there is a pending DMA operation during ide_bus_reset(), the fact > that the IDEstate is already reset before the operation is canceled > can be problematic. In particular, ide_dma_cb() might be called and > then use the reset IDEstate which contains

[pve-devel] [PATCH pve-network 3/3] zones: evpn: add disable-bridge-learning

2023-09-26 Thread Alexandre Derumier
Allow to statically register mac address in evpn, can be useful for silent hosts --- src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm index 5df05f9..5e9f8e

[pve-devel] [PATCH pve-container 1/1] add_bridge_fbd: remove unused firewall param

2023-09-26 Thread Alexandre Derumier
--- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 1e9af0f..aa8564e 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -935,7 +935,7 @@ sub net_tap_plug : prototype($$) { if ($have_sdn) { PVE::Network::SDN::Z

[pve-devel] [PATCH qemu-server 1/1] add|del_bridge_fdb: remove unused firewall param

2023-09-26 Thread Alexandre Derumier
--- PVE/QemuServer.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1b1ccf4..b89697a 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -8541,9 +8541,9 @@ sub add_nets_bridge_fdb { next; }

[pve-devel] [PATCH-SERIES pve-network/qemu-server/pve-container] cleanup for static mac registration

2023-09-26 Thread Alexandre Derumier
- add|del_bridge_fdb: remove unused firewall param - sdn: move add|del_bridge_fdb to plugin to be overridable - sdn: evpn : add disable-bridge-learning option pve-network : Alexandre Derumier (3): zones: add|del_bridge_fdb : remove firewall param zones: add add|del_bridge_fdb to plugins zon

[pve-devel] [PATCH pve-network 2/3] zones: add add|del_bridge_fdb to plugins

2023-09-26 Thread Alexandre Derumier
We want to be able to override it for some specific plugins. Can be used by an sdn controller (like ovn for example), where mac need to be registered manually. --- src/PVE/Network/SDN/Zones.pm| 4 ++-- src/PVE/Network/SDN/Zones/Plugin.pm | 12 2 files changed, 14 insertions(

[pve-devel] [PATCH pve-network 1/3] zones: add|del_bridge_fdb : remove firewall param

2023-09-26 Thread Alexandre Derumier
It's not used anymore in Network.pm --- src/PVE/Network/SDN/Zones.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm index 7d70e49..1e678ed 100644 --- a/src/PVE/Network/SDN/Zones.pm +++ b/src/PVE/Network/S

[pve-devel] applied-series: [PATCH manager v9 0/2] fix #4849: allow download of compressed ISOs

2023-09-26 Thread Fabian Grünbichler
with some commit message fixups, and d/control update folded in (and Dominik's T+R-B). On September 21, 2023 3:09 pm, Philipp Hufnagl wrote: > Many web pages offer the download of the disk images compressed. This > patch allows the download of archives (like .gz), automatically detects > the forma

Re: [pve-devel] [PATCH manager 0/2] ui: fw: allow selecting network interface for rules using combogrid

2023-09-26 Thread Christoph Heiss
Ping. While it does not apply cleanly on current master anymore, I'd like to collect some general feedback on the approach before rebasing + resending w/o any actual changes. On Thu, May 11, 2023 at 11:46:18AM +0200, Christoph Heiss wrote: > > For nodes, VMs and CTs we can show the user a list