Re: [pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-08 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- I just love it! Something I have desired for decades! Thanks --- Gilberto Nunes Ferreira (47) 99676-7530 - Whatsapp / Telegram Em sex., 8 de set. de 2023 às 10:43, Stefan Hanreich escreveu: > This patch series adds support for automatically deploying dnsmasq as a > DHC

[pve-devel] [RFC pve-network 6/6] sdn: dhcp: regenerate config for DHCP servers on reload

2023-09-08 Thread Stefan Hanreich
During config regeneration parsing of the SDN configuration happens in one pass before generating the configuration files via the plugins in order to avoid having to parse property strings in the subnet configuration multiple times. Then we call the respective hooks of the plugin responsible for c

[pve-devel] [RFC pve-network 3/6] sdn: dhcp: add abstract class for DHCP plugins

2023-09-08 Thread Stefan Hanreich
This abstract class provides several hooks that should be called during the config regeneration process: before_regenerate Should be called before the plugin does any configuration tasks. The main usage for this hook is tearing down old instances. after_regenerate Should be called after the plugi

[pve-devel] [RFC pve-manager 2/6] sdn: regenerate DHCP config on reload

2023-09-08 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- PVE/API2/Network.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 00d964a79..f39f04f52 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -660,6 +660,7 @@ __PACKAGE__->register_method({

[pve-devel] [RFC pve-network 4/6] sdn: dhcp: subnet: add DHCP options to subnet configuration

2023-09-08 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/SubnetPlugin.pm | 43 + 1 file changed, 43 insertions(+) diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm b/src/PVE/Network/SDN/SubnetPlugin.pm index 15b370f..527db4f 100644 --- a/src/PVE/Network/SDN/SubnetPlugin

[pve-devel] [RFC pve-network 5/6] sdn: dhcp: add DHCP plugin for dnsmasq

2023-09-08 Thread Stefan Hanreich
The plugin generates several dnsmasq configuration files from the SDN configuration. /etc/default/dnsmasq. This file specifies the configuration directory for the dnsmasq instance (/etc/dnsmasq.d/). It also sets the configuration file to /dev/null so the default configuration from the package has

[pve-devel] [RFC cluster/manager/network 0/6] Add support for DHCP servers to SDN

2023-09-08 Thread Stefan Hanreich
This patch series adds support for automatically deploying dnsmasq as a DHCP server to a simple SDN Zone. While certainly not 100% polished on some ends (looking at restarting systemd services in particular), the general idea behind the mechanism shows. I wanted to gather some feedback on how I ap

[pve-devel] [RFC pve-cluster 1/6] cluster files: add dhcp.cfg

2023-09-08 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index e3705b6..2f674db 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -78,6 +78,7 @@ my $observed = { '

[pve-devel] [PATCH manager v3] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
After the implementation of fix #474, it has been suggested that instead of requiring the user to click a checkbox allowing migration, it should be allowed automatically and and a warning should be displayed Further it has been discussed to rename the feature from "transfer" to "migrate". However

Re: [pve-devel] [PATCH manager v2] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
Please dont merge. It appers i made an error at testing On 9/8/23 13:56, Philipp Hufnagl wrote: After the implementation of fix #474, it has been suggested that instead of requiring the user to click a checkbox allowing migration, it should be allowed automatically and and a warning should be di

[pve-devel] [PATCH manager v2] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
After the implementation of fix #474, it has been suggested that instead of requiring the user to click a checkbox allowing migration, it should be allowed automatically and and a warning should be displayed Further it has been discussed to rename the feature from "transfer" to "migrate". However

Re: [pve-devel] [PATCH qemu-server] vm start: set minimum timeout of 300s if using PCI passthrough

2023-09-08 Thread Friedrich Weber
On 21/08/2023 10:33, Fiona Ebner wrote: > Would it make sense to instead add a constant multiplier to the memory > timeout heuristic in presence of PCI passthrough? The user says 65 GiB > takes about 3 min 30 s, so assuming it's more or less linear, the 5 min > from this patch would not be enough f

[pve-devel] [PATCH qemu-sever v12 1/6] enable VNC clipboard parameter in vga_fmt

2023-09-08 Thread Markus Frank
added option to use the qemu vdagent implementation to enable the VNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the QEMU implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the gue

[pve-devel] [PATCH manager v12 5/6] add clipboard checkbox to VM Options

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 8 + www/manager6/qemu/Options.js | 52 2 files changed, 60 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..d7cd51a9 100644

[pve-devel] [PATCH qemu-sever v12 3/6] test cases for clipboard spice & std

2023-09-08 Thread Markus Frank
add one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/VNC-clipboard-spice.conf | 1 + test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 +++ test/cfg2cmd/VNC-clipboard-std.conf | 1 + test/cfg2cmd/VNC-clipboard-std.conf.cm

[pve-devel] [PATCH qemu-sever/novnc/manager/docs v12 0/6] Feature VNC-Clipboard

2023-09-08 Thread Markus Frank
overall changes v11: * renamed vnc-clipboard to clipboard and changed it to a string overall changes v9: * renamed vnc_clipboard to vnc-clipboard qemu-sever: changes v10: * separated "vnc-clipboard return at status/current" to its own patch * added missing trailing comma * changed capitalizatio

[pve-devel] [PATCH docs v12 6/6] add VNC clipboard documentation

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index b3c3034..43c1da4 100644 --- a/qm.adoc +++ b/qm.adoc @@ -776,6 +776,24 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web C

[pve-devel] [PATCH qemu-sever v12 2/6] add clipboard variable to return at status/current

2023-09-08 Thread Markus Frank
By that noVNC is able to check if clipboard is active. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8a2fdef..49d0420 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2697,6 +2697,13

[pve-devel] [PATCH novnc v12 4/6] add "show clipboard button" patch to series

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

Re: [pve-devel] [PATCH qemu-sever/novnc/manager/docs v11 0/6] Feature VNC-Clipboard

2023-09-08 Thread Markus Frank
forgot to update novnc-pve -> ignore this v11 series At Fri Sep 08 2023 12:46:43 GMT+0200 (Central European Summer Time), Markus Frank wrote: overall changes v11: * renamed vnc-clipboard to clipboard and changed it to a string overall changes v9: * renamed vnc_clipboard to vnc-clipboard qemu

Re: [pve-devel] [PATCH manager] ui: improve vm/container migration user experience

2023-09-08 Thread Philipp Hufnagl
On 9/6/23 11:18, Thomas Lamprecht wrote: subject is quite confusing, this isn't for what's commonly understood w.r.t. the "VM/CT migration", i.e., live migration to another host. You at least need to use the word "pool" somewhere.. Am 05/09/2023 um 15:51 schrieb Philipp Hufnagl: After the imp

[pve-devel] [PATCH docs v11 6/6] add VNC clipboard documentation

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index b3c3034..43c1da4 100644 --- a/qm.adoc +++ b/qm.adoc @@ -776,6 +776,24 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects the Web C

[pve-devel] [PATCH manager v11 5/6] add clipboard checkbox to VM Options

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 8 + www/manager6/qemu/Options.js | 52 2 files changed, 60 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..d7cd51a9 100644

[pve-devel] [PATCH qemu-sever/novnc/manager/docs v11 0/6] Feature VNC-Clipboard

2023-09-08 Thread Markus Frank
overall changes v11: * renamed vnc-clipboard to clipboard and changed it to a string overall changes v9: * renamed vnc_clipboard to vnc-clipboard qemu-sever: changes v10: * separated "vnc-clipboard return at status/current" to its own patch * added missing trailing comma * changed capitalizatio

[pve-devel] [PATCH qemu-sever v11 3/6] test cases for clipboard spice & std

2023-09-08 Thread Markus Frank
add one test case for a spice display and one for std Signed-off-by: Markus Frank --- test/cfg2cmd/VNC-clipboard-spice.conf | 1 + test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 +++ test/cfg2cmd/VNC-clipboard-std.conf | 1 + test/cfg2cmd/VNC-clipboard-std.conf.cm

[pve-devel] [PATCH novnc v11 4/6] add "show clipboard button" patch to series

2023-09-08 Thread Markus Frank
Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show-clipboard-button.patch diff --git a/debian/patches/0019-sho

[pve-devel] [PATCH qemu-sever v11 1/6] enable VNC clipboard parameter in vga_fmt

2023-09-08 Thread Markus Frank
added option to use the qemu vdagent implementation to enable the VNC clipboard. When enabled with SPICE the spice-vdagent gets replaced with the QEMU implementation. This patch does not solve #1406, but does allow copy and paste with a running X-session, when spice-vdagent is installed on the gue

[pve-devel] [PATCH qemu-sever v11 2/6] add clipboard variable to return at status/current

2023-09-08 Thread Markus Frank
By that noVNC is able to check if clipboard is active. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8a2fdef..49d0420 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2697,6 +2697,13

[pve-devel] applied: [PATCH qemu] Fix spelling error in function name

2023-09-08 Thread Fiona Ebner
Am 08.09.23 um 10:49 schrieb Filip Schauer: > Signed-off-by: Filip Schauer > --- applied, thanks! > diff --git > a/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch > b/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch > index d873601..717845c 1006

[pve-devel] applied: [PATCH docs] vzdump: mention file-restore log file

2023-09-08 Thread Fiona Ebner
Am 05.09.23 um 09:43 schrieb Fabian Grünbichler: > it was only documented in the proxmox-backup source code so far. > > Signed-off-by: Fabian Grünbichler > --- applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.prox

[pve-devel] [PATCH qemu] Fix spelling error in function name

2023-09-08 Thread Filip Schauer
Signed-off-by: Filip Schauer --- ...30-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch b/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-pat