[pve-devel] [PATCH qemu 2/2] d/rules: explicitly disable building slirp

2022-12-14 Thread Fiona Ebner
Otherwise, it depends on whether libslirp-devel is installed or not. See the previous commit message for more context. Signed-off-by: Fiona Ebner --- debian/rules | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/rules b/debian/rules index 0226c43..89c234a 100755 --- a/debian/rules +++

[pve-devel] applied-series: [PATCH V3 firewall 0/2] allow non zero ip address host bits to be entered

2022-12-14 Thread Wolfgang Bumiller
applied both patches, thanks On Tue, Dec 13, 2022 at 04:14:17PM +0100, Stefan Hrdlicka wrote: > V2 -> V3 > * review fix: removed closure from clean_cidr > > V1 -> V2 > * zero out host bits instead of ignoring error > * regex "cleanup" > > Stefan Hrdlicka (2): > allow non zero ip address host b

[pve-devel] [PATCH V7 manager 1/2] fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes

2022-12-14 Thread Stefan Hrdlicka
This adds a dropdown box for iSCSI, LVM, LVMThin & ZFS storage options where a cluster node needs to be chosen. As default the current node is selected. It restricts the the storage to be only availabe on the selected node. Signed-off-by: Stefan Hrdlicka --- www/manager6/Makefile

[pve-devel] [PATCH V7 manager 2/2] cleanup: "var" to "let", fix some indentation in related files

2022-12-14 Thread Stefan Hrdlicka
Signed-off-by: Stefan Hrdlicka --- www/manager6/storage/Base.js| 10 +- www/manager6/storage/IScsiEdit.js | 6 +++--- www/manager6/storage/LVMEdit.js | 14 +++--- www/manager6/storage/LvmThinEdit.js | 18 +- www/manager6/storage/ZFSPoolEdit.js | 23 +

[pve-devel] [PATCH V7 manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs

2022-12-14 Thread Stefan Hrdlicka
V6 -> V7: # pve-manager(1/2) * remove initially selected scan node * add node restriction always when a scan node is selected V5 -> V6: # pve-manager (1/2) * set default value of "Scan node" to Proxmox.NodeName * don't allow empty "Scan node" V4 -> V5: # pve-manager (1/2) * s/lookupReference/lo

[pve-devel] applied: [PATCH access-control v2 1/2] realm: sync: allow 'none' for 'remove-vanished' option

2022-12-14 Thread Thomas Lamprecht
Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > with that, the api call can now override the default option > that is set on the realm (if any) by providing 'none' > > it was not possible previously to override the realm default > when one wanted no properties to delete > > no other code changes

[pve-devel] applied: [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment

2022-12-14 Thread Thomas Lamprecht
Am 29/10/2021 um 13:16 schrieb Fabian Ebner: > No functional change is intended. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > Dependency bump for pve-common is needed. > > src/PVE/LXC.pm | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > applied, thank

Re: [pve-devel] [PATCH access-control v2 2/2] add realmsync plugin for jobs and CRUD api for domainsync-jobs

2022-12-14 Thread Dominik Csapak
On 12/13/22 14:43, Thomas Lamprecht wrote: Some mostly API and slightly higher level or cosmetical comments, but also some issue with how you use the cfs domain locks at the end. Also, a patch-wide s/realmsync/realm-sync/ would be great. sure, no problem Am 06/12/2022 um 12:06 schrieb Dom

Re: [pve-devel] applied: [PATCH manager v2 1/3] ui: realm: sync: don't use realm defaults for remove-vanished

2022-12-14 Thread Dominik Csapak
On 12/13/22 15:15, Thomas Lamprecht wrote: Am 06/12/2022 um 12:06 schrieb Dominik Csapak: if we don't manually set it to the empty string, it will use the realm default, which might be unexpected. this way, the sync always does what the user saw in the sync window. Signed-off-by: Dominik Csapak

Re: [pve-devel] [PATCH pve-docs v2] updated tags docs

2022-12-14 Thread Stefan Sterz
On 12/13/22 15:56, Noel Ullreich wrote: > updated the tags doc with slight rephrasing, corrected grammar, > and fixed typos. > > Signed-off-by: Noel Ullreich > --- > changes since v1: > * removed changes in datacenter.cfg.5-opts.adoc since it is an > autogenerated file (thanks @Dominik;) ) > pve

Re: [pve-devel] [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment

2022-12-14 Thread Fiona Ebner
Am 29.10.21 um 13:16 schrieb Fabian Ebner: > No functional change is intended. > > Signed-off-by: Fabian Ebner > --- Ping. This one is still missing. > > No changes from v1. > > Dependency bump for pve-common is needed. > The dependency is already new enough nowadays :) __