On 14.03.22 17:49, Aaron Lauterer wrote:
> On 2/22/22 09:44, Thomas Lamprecht wrote:
>> On 18.02.22 12:38, Aaron Lauterer wrote:
> [...]
>
>>
>> In general I see lots of repetition, and in this case I'd rather have a
>> single
>> enpoint that accepts one (or maybe better a list of) service-type(s
On 2/22/22 09:44, Thomas Lamprecht wrote:
On 18.02.22 12:38, Aaron Lauterer wrote:
[...]
In general I see lots of repetition, and in this case I'd rather have a single
enpoint that accepts one (or maybe better a list of) service-type(s), and an
action (stop/destroy) let's encode in the nam
applied qemu-server patches except 11 and 14-16, see comments on
indivudal patches.
some unrelated but possibly fix-able as followup things I noticed:
- cloning a running VM with an EFI disk fails, the EFI disk is not
mirrorable (so we need another check like for TPM state?)
- cancelling a run
On March 9, 2022 11:09 am, Fabian Ebner wrote:
> Co-developed-by: Fabian Grünbichler
> Signed-off-by: Dominic Jäger
> [split into its own patch + minor improvements/style fixes]
> Signed-off-by: Fabian Ebner
> ---
> PVE/API2/Qemu/Makefile | 2 +-
> PVE/API2/Qemu/OVF.pm | 55 +
On March 9, 2022 11:09 am, Fabian Ebner wrote:
> and also when source and target drivename are different. In those
> cases, it is done via qemu-img convert/dd.
>
> In preparation to allow import from existing PVE-managed disks.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/API2/Qemu.pm | 2 ++
>
On March 9, 2022 11:09 am, Fabian Ebner wrote:
> From: Dominic Jäger
>
> Extend qm importdisk functionality to the API.
>
> Co-authored-by: Fabian Grünbichler
> Co-authored-by: Dominic Jäger
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v11:
> * Require relevant parameters to be s
On 11.03.22 17:04, Stoiko Ivanov wrote:
> Since all our zfs installs use proxmox-boot-tool the compatibility is
> not an issue anymore
>
> Signed-off-by: Stoiko Ivanov
> ---
> tested the zstd option by pushing the updated proxinstall to the current
> 7.1-2 ISO
>
> proxinstall | 3 +--
> 1 file
first call $rpcenv->get_user() if user was 'undef'. if that doesn't
return then we set it to root@pam.
Signed-off-by: Oguz Bektas
---
v1->v2:
* do get_user() first, set to 'root@pam' as fallback
* drop first patch for pve-container (not needed anymore)
src/PVE/RESTEnvironment.pm | 7 ++-
1
Am 14.03.22 um 11:00 schrieb Fabian Ebner:
> Am 14.03.22 um 10:26 schrieb Hannes Laimer:
>> Signed-off-by: Hannes Laimer
>> @@ -274,6 +274,25 @@ sub synchronize_job_states_with_config {
>> die $@ if $@;
>> }
>>
>> +sub remove_vmid_from_jobs {
>> +my ($vmid) = @_;
>> +
>> +cfs_lock_
Am 14.03.22 um 10:26 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer
> ---
> PVE/Jobs.pm| 21 -
> PVE/Jobs/Plugin.pm | 7 +++
> PVE/Jobs/VZDump.pm | 13 +
> 3 files changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Jobs.pm b/PVE/Jobs
Double negated properties make it harder than necessary to parse
conditions.
Signed-off-by: Aaron Lauterer
Reviewed-by: Fabian Ebner
---
www/manager6/form/BusTypeSelector.js| 4 ++--
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CDEdit.js | 2 +-
www/manage
Using the actual config key instead of the pluralization, makes it
easier in the situations where we need to match against it.
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js | 8 +++-
www/manager6/lxc/MPEdit.js | 2 +-
www/manager6/lxc/MultiMPEdit.js | 4 ++--
www/man
Signed-off-by: Aaron Lauterer
---
changes since
v3:
* code cleanup
* fix padding
* create 'url' in one place, no need for submitURL
v2:
* switch from generic window to proxmox edit
v1: much of the feedback to the HDReassign.js from the
first patch has been incorporated here as well.
www/manag
For the new HDReassign component, we follow the approach of HDMove to
have one componend for qemu and lxc.
To avoid button clutter, a new "Disk/Volume action" button is
introduced. It holds the Move, Reassign and Resize buttons in a submenu.
Signed-off-by: Aaron Lauterer
---
changes since
v3:
*
This series adds the UI to reassign a disk / volume from one guest to another.
To avoid button clutter, the Move, Reassing and Resize buttons are moved
into a new submenu called "Disk/Volume Action".
Patch 3 to 6 are optional. Patch 3 changes the labels for Move, Reassign
and Resize to remove Vol
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js | 17 +
1 file changed, 17 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..5190f750 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1803,6 +1803,23 @@ Ext.define('P
We already know that we are acting upon a disk / volume due to the
submenu we are in.
Signed-off-by: Aaron Lauterer
---
www/manager6/lxc/Resources.js | 6 +++---
www/manager6/qemu/HardwareView.js | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/www/manager6/lxc/Reso
Signed-off-by: Hannes Laimer
---
PVE/Jobs.pm| 21 -
PVE/Jobs/Plugin.pm | 7 +++
PVE/Jobs/VZDump.pm | 13 +
3 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm
index ba3685ec..5b2c4c7b 100644
--- a/PVE/Jobs.pm
+++ b/
... on destroy if 'purge' is selected
Signed-off-by: Hannes Laimer
---
v2->v3: no changes
PVE/API2/Qemu.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 9be1caf..465abc2 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -31,6 +31,7 @@ use
... on destroy if 'purge' is selected
Signed-off-by: Hannes Laimer
---
v2->v3: no changes
src/PVE/API2/LXC.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 84712f7..095f421 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -16,
... if 'purge'.
v3, based on Fabian Ebner's feedback:
- correctly handle 'exclude'
- move plugin specific stuff into the corresponding plugin(currently
just VZDump)
- add missing call to remove_job, when removing job
v2, based on Fabian Ebner's feedback:
- rewrote remove_vmid_from_jobs su
akin to get_guest_config_property, but with a list of properties.
uses the new CFS_IPC_GET_GUEST_CONFIG_PROPERTIES
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 765f
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index c65ba17..49022c3 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -363,7 +363,7 @@ sub get_guest_config_properties
for getting multiple properties from the in memory config of the
guests. I added a new CSF_IPC_ call to maintain backwards compatibility.
It basically behaves the same as
CFS_IPC_GET_GUEST_CONFIG_PROPERTY, but takes a list of properties
instead.
The old way of getting a single property is now als
On 3/14/22 09:18, Fabian Ebner wrote:
Am 11.03.22 um 15:38 schrieb Aaron Lauterer:
On 3/10/22 11:49, Fabian Ebner wrote:
Am 07.03.22 um 11:07 schrieb Aaron Lauterer:
+ cbindData: function() {
+ let me = this;
+ return {
+ vmid: me.vmid,
+ disk: me.disk,
+ isQemu
Am 11.03.22 um 15:38 schrieb Aaron Lauterer:
> On 3/10/22 11:49, Fabian Ebner wrote:
>> Am 07.03.22 um 11:07 schrieb Aaron Lauterer:
>>> + cbindData: function() {
>>> + let me = this;
>>> + return {
>>> + vmid: me.vmid,
>>> + disk: me.disk,
>>> + isQemu: me.type === 'q
26 matches
Mail list logo
