This series adds the UI to reassign a disk / volume from one guest to another.
To avoid button clutter, the Move, Reassing and Resize buttons are moved into a new submenu called "Disk/Volume Action". Patch 3 to 6 are optional. Patch 3 changes the labels for Move, Reassign and Resize to remove Volume & Disk as we already have this in the context of the submenu. Patch 4 only changes a double negated option. Patch 5 happend in the process of working on an interface for the reassign functionality. Since the work of modernizing this componend is done, why not use it Patch 6 changes how we store the max number of MPs possible because I ran into the issue, that I cannot easily match against the object key if it is 'mps' instead of 'mp'. v4: * add PVE.Util.nextFreeMP helper * filter templates in the reassign target guest list * code cleanup on multiple locations * fix padding v3: * change to Edit window, removing quite some boilerplate code * create new submenu for disk/volume actions * incorporate smaller style nits * simplify other labels as well, removing 'Volume' and 'Disk' as the context gives that away already v2: incorporated feedback I got off list, mainly * using more modern approaches * more arrow functions * reducing use of predefined cbind values and using inline functions when possible Aaron Lauterer (6): ui: utils: add nextFreeMP ui: lxc/qemu: add disk reassign and action submenu ui: lxc/qemu: disk/volume action simplify menu items ui: BusTypeSelector: change noVirtIO to withVirtIO ui: hdmove: modernize/refactor ui: util: refactor mps to mp www/manager6/Makefile | 1 + www/manager6/Utils.js | 19 +- www/manager6/form/BusTypeSelector.js | 4 +- www/manager6/form/ControllerSelector.js | 4 +- www/manager6/lxc/MPEdit.js | 2 +- www/manager6/lxc/MultiMPEdit.js | 4 +- www/manager6/lxc/Resources.js | 66 ++++-- www/manager6/qemu/CDEdit.js | 2 +- www/manager6/qemu/CIDriveEdit.js | 2 +- www/manager6/qemu/HDMove.js | 185 +++++++--------- www/manager6/qemu/HDReassign.js | 272 ++++++++++++++++++++++++ www/manager6/qemu/HardwareView.js | 69 ++++-- 12 files changed, 490 insertions(+), 140 deletions(-) create mode 100644 www/manager6/qemu/HDReassign.js -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
