[pve-devel] [PATCH v3 qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.

This option don't have any impact on device itself. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 25 + 1 file changed, 25 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 076ce59..2c63826 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuSer

[pve-devel] [PATCH docs 1/2] qm: add note about secure boot and new efidisk behaviour

Signed-off-by: Stefan Reiter --- qm.adoc | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/qm.adoc b/qm.adoc index 80734e3..93576c7 100644 --- a/qm.adoc +++ b/qm.adoc @@ -733,10 +733,13 @@ the operating system. By default QEMU uses *SeaBIOS* for

[pve-devel] [PATCH docs 2/2] qm: add section about TPM

Signed-off-by: Stefan Reiter --- qm.adoc | 30 ++ 1 file changed, 30 insertions(+) diff --git a/qm.adoc b/qm.adoc index 93576c7..b9f4269 100644 --- a/qm.adoc +++ b/qm.adoc @@ -775,6 +775,36 @@ you need to set the client resolution in the OVMF menu (which you can reac

Re: [pve-devel] trousers error in latest test repo?

Hi, Nope, I haven't edited /etc/init.d/trousers. (I did view it, because of this post and curiosity but didn't make any changes). I just tested a reinstall, as suggested -

Re: [pve-devel] trousers error in latest test repo?

Hi Thomas, Ah - interesting - as a data-point, this was a new install of Proxmox 7.0-2 (from the ISO image), and then I ran an apt update, apt dist-upgrade directly after first boot. I just did an apt update, apt dist-upgrade again - and there was one package to update (trousers). I am still get

[pve-devel] applied: [PATCH storage] btrfs: free image: only remove snapshots for current subvol

On 13.09.21 11:01, Fabian Ebner wrote: > instead of all in the same directory. > > Reported in the community forum: > https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/ > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/BTRFSPlugin.pm | 4 +++- > 1 file c

Re: [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol

Ping, because more people ran into this (see forum thread). Am 13.09.21 um 11:01 schrieb Fabian Ebner: instead of all in the same directory. Reported in the community forum: https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/ Signed-off-by: Fabian Ebner -

[pve-devel] pending patches for review

Hi, Here a summary of my last patches pending review/apply. (just to be sure that they are not lost with the summer holiday) Could somebody have time to review them ? Regards, Alexandre IPAM - I really need to have a comment about this implementation. (adding ip options to vm nic). I w

[pve-devel] [PATCH v2 storage 5/6] partially fix #2285: api: disks: allow partitions for creation paths

The calls for directory and ZFS need slight adaptations. Except for those, the only thing that needs to be done is support partitions in the disk_is_used helper. Signed-off-by: Fabian Ebner --- No changes from v1. PVE/API2/Disks/Directory.pm | 28 PVE/API2/Disks/ZF

[pve-devel] [PATCH v2 manager 5/6] ui: zfs create: switch to using widget-toolkit's multiDiskSelector

Signed-off-by: Fabian Ebner --- No changes from v1. For this one, the dependency requirement is already new enough. www/manager6/node/ZFS.js | 80 ++-- 1 file changed, 4 insertions(+), 76 deletions(-) diff --git a/www/manager6/node/ZFS.js b/www/manager6/nod

[pve-devel] [PATCH v2 manager 6/6] partially fix #2285: ui: disk create: allow selecting partitions

Signed-off-by: Fabian Ebner --- No changes from v1. Dependency bump for widget-toolkit needed. www/manager6/node/Directory.js | 1 + www/manager6/node/LVM.js | 1 + www/manager6/node/LVMThin.js | 1 + www/manager6/node/ZFS.js | 1 + 4 files changed, 4 insertions(+) diff --git a/

[pve-devel] [RFC v2 manager 4/6] partially fix #2285: ui: ceph: allow selecting partitions

For DB and WAL disks, not only partitions will show up now, but one more type of disk, that didn't show up before: Namely, GPT-partitioned disks with any partitions detected as used. It's confusing as the size shown is of the full disk, with no indication that a new partition will be appended at t

[pve-devel] [RFC v2 manager 3/6] api: ceph: create osd: set correct partition type

Signed-off-by: Fabian Ebner --- No changes from v1. RFC, because the previous one is and this only makes sense with it. PVE/API2/Ceph/OSD.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index c511f315..18329eeb 100644 --- a/PVE/API

[pve-devel] [RFC v2 manager 2/6] partially fix #2285: api: ceph: create osd: allow using partitions

Note that this does not only allow partitions to be used, but for DB and WAL disks, one more type of disk, that wasn't allowed before. Namely, GPT-partitioned disks with any partitions detected as used. The reason is get_disks' behavior: * Without $include_partitions=1, the disk will have the sam

[pve-devel] [PATCH-SERIES v2 storage/widget-toolkit/manager] disk creation and wiping improvements

fixing the remaining parts of #2285, i.e. extending the diskmanage module and disk creation via API/UI to support partitions. Also change the partition type in the appropriate places as that information is used when querying disk info. pve-manager depends on both pve-storage and proxmox-widget-t

[pve-devel] [PATCH v2 storage 1/6] diskmanage: add change_parttype and is_partition helpers

For change_parttype, only GPT-partitioned disks are supported, as I didn't see an option for sgdisk to make it also work with MBR-partitioned disks. And while sfdisk could be used instead (or additionally) it would be a new dependency, and AFAICS require some conversion of partition type GUIDs to M

[pve-devel] [PATCH v2 storage 6/6] api: disks: create: set correct partition type

Signed-off-by: Fabian Ebner --- No changes from v1. PVE/API2/Disks/Directory.pm | 5 - PVE/API2/Disks/LVM.pm | 5 + PVE/API2/Disks/LVMThin.pm | 5 + PVE/API2/Disks/ZFS.pm | 11 +++ 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Disks

[pve-devel] [PATCH v2 storage 4/6] api: disks: initgpt: explicitly abort for partitions

In preparation to extend disk_is_used to support partitions. Without this new check, initgpt would also allow partitions once disk_is_used supports partitions, which is not desirable. Signed-off-by: Fabian Ebner --- Changes from v1: * is_partition helper is now already added in an earlier pa

[pve-devel] [PATCH v2 storage 3/6] diskmanage: don't set usage for unused partitions

The disk type is already 'partition' so there's no additional information here. And it would need to serve as a code-word for unused partitions. The cleaner approach is to not set the usage. Signed-off-by: Fabian Ebner --- No changes from v1. Was not a smart decision back then...If this is cons

[pve-devel] [PATCH v2 widget-toolkit 1/1] disk list: allow wiping individual partitions

Signed-off-by: Fabian Ebner --- No changes from v1. src/panel/DiskList.js | 8 1 file changed, 8 deletions(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index 90a6553..eb8b1a8 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -399,14 +399,6 @@ Ext.defin

[pve-devel] [PATCH v2 storage 2/6] diskmanage: wipe blockdev: also change partition type

when called with a partition. Since get_disks uses the partition type (among other things) to detect LVM and ZFS volumes, such volumes would still be seen as in-use after wiping. Thus, also change the partition type and simply use 0x83 "Linux filesystem". Signed-off-by: Fabian Ebner --- No chang

[pve-devel] [PATCH v2 manager 1/6] api: ceph: create osd: set correct parttype for DB/WAL

The get_ceph_journals function in pve-storage uses this information. Signed-off-by: Fabian Ebner --- No changes from v1. Dependency bump for pve-storage needed. PVE/API2/Ceph/OSD.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm ind

Re: [pve-devel] trousers error in latest test repo?

On 06.10.21 10:39, Victor Hooi wrote: > root@mgmt1:/etc/apt/sources.list.d# ls -l /dev/tmp* >> ls: cannot access '/dev/tmp*': No such file or directory argh, misspelled tpm with tmp -.- can you retry: ls -l /dev/tpm* - Thomas ___ pve-devel mailing li

Re: [pve-devel] trousers error in latest test repo?

On 06.10.21 10:39, Victor Hooi wrote: > Hi, > > Nope, I haven't edited /etc/init.d/trousers. (I did view it, because of this > post > > and > curiosity but didn't make any c

Re: [pve-devel] trousers error in latest test repo?

Hi Victor, On 06.10.21 10:15, Victor Hooi wrote: > Ah - interesting - as a data-point, this was a new install of Proxmox 7.0-2 > (from the ISO image), and then I ran an apt update, apt dist-upgrade > directly after first boot. very interesting indeed, I mainly tested on a cluster that was install

[pve-devel] [PATCH pve-cluster] sysctl: disable net.ipv4.igmp_link_local_mcast_reports

currently, when veth or tap interfaces are plugged to bridge, an igmp v3 report is broadcasted to the network, with the bridge mac adddress. Users have reported problems with hetzner for example, blocking the server because of the unknown mac flooding the network. https://forum.proxmox.com/threads

Re: [pve-devel] trousers error in latest test repo?

On 06.10.21 00:51, Victor Hooi wrote: > Hi, > > I just installed a new box (Intel NUC7i5BNK) with Proxmox 7.0-2, and then > ran an apt update/dist-upgrade, using the PVE test repos: > > There seems to be some error whilst upgrading some "trousers" module: > > Setting up trousers (0.3.14+fixed1-1

Re: [pve-devel] [PATCH storage 06/10] api: disks: initgpt: explicitly abort for partitions

Am 30.09.21 um 18:02 schrieb Thomas Lamprecht: On 28.09.21 13:39, Fabian Ebner wrote: In preparation to extend disk_is_used to support partitions. Without this new check, initgpt would also allow partitions once disk_is_used supports partitions, which is not desirable. Signed-off-by: Fabian Ebn

Re: [pve-devel] [PATCH-SERIES v3] fix #3111: fix interaction of snapshot operations with replication

Any feedback for this? Am 12.08.21 um 13:00 schrieb Fabian Ebner: For more context, see also: https://lists.proxmox.com/pipermail/pve-devel/2021-August/049694.html Changes from v2: * Many new patches, as the approach is different: For one, only replication snapshots that are blockin