[pve-devel] Updating translations

2021-09-24 Thread Claudio Ferreira
Hi I was taking a look in pt-BR translation and I saw a lot of commented fuzzy translations at the end of the file. I haven't idea if this strings are or not necessary, so I I took a peek in Makefile to see what is possible to do. I saw an option "update" that updates repo and tries to update pot

Re: [pve-devel] [RFC storage 6/6] pbs: integrate support for protected

2021-09-24 Thread Dominik Csapak
On 9/24/21 13:32, Fabian Ebner wrote: Am 24.09.21 um 10:55 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: free_image doesn't need to check for protection, because that will happen on the server. Getting/updating notes has also been refactored to re-use the code for the PBS api c

Re: [pve-devel] [RFC storage 6/6] pbs: integrate support for protected

2021-09-24 Thread Fabian Ebner
Am 24.09.21 um 10:55 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: free_image doesn't need to check for protection, because that will happen on the server. Getting/updating notes has also been refactored to re-use the code for the PBS api calls. Signed-off-by: Fabian Ebner ---

Re: [pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes

2021-09-24 Thread Fabian Ebner
Am 24.09.21 um 13:16 schrieb Dominik Csapak: On 9/24/21 13:05, Fabian Ebner wrote: Am 24.09.21 um 10:54 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: replacing the ones for handling notes. The generic implementation in Plugin.pm will fall back to the methods for notes to ensure

Re: [pve-devel] [RFC storage 4/6] fix #3307: make it possible to set protection for backups

2021-09-24 Thread Fabian Ebner
Am 24.09.21 um 10:54 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: A protected backup is not removed by free_image and ignored when pruning. The protection_file_path function is introduced in Storage.pm, so that it can also be used by vzdump itself and in archive_remove. Signed

Re: [pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes

2021-09-24 Thread Dominik Csapak
On 9/24/21 13:05, Fabian Ebner wrote: Am 24.09.21 um 10:54 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: replacing the ones for handling notes. The generic implementation in Plugin.pm will fall back to the methods for notes to ensure backwards compatibility with external plugins

Re: [pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes

2021-09-24 Thread Fabian Ebner
Am 24.09.21 um 10:54 schrieb Dominik Csapak: On 9/17/21 15:02, Fabian Ebner wrote: replacing the ones for handling notes. The generic implementation in Plugin.pm will fall back to the methods for notes to ensure backwards compatibility with external plugins. This is mainly done to avoid the nee

Re: [pve-devel] [PATCH storage 1/6] dir plugin: update notes: don't attempt to remove non-existent notes

2021-09-24 Thread Fabian Ebner
Am 24.09.21 um 11:03 schrieb Thomas Lamprecht: On 24.09.21 10:54, Dominik Csapak wrote: On 9/17/21 15:02, Fabian Ebner wrote: Signed-off-by: Fabian Ebner ---   PVE/Storage/DirPlugin.pm | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage

Re: [pve-devel] [PATCH storage 1/6] dir plugin: update notes: don't attempt to remove non-existent notes

2021-09-24 Thread Thomas Lamprecht
On 24.09.21 10:54, Dominik Csapak wrote: > On 9/17/21 15:02, Fabian Ebner wrote: >> Signed-off-by: Fabian Ebner >> --- >>   PVE/Storage/DirPlugin.pm | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm >> index 2267f11..04

Re: [pve-devel] [RFC storage 6/6] pbs: integrate support for protected

2021-09-24 Thread Dominik Csapak
On 9/17/21 15:02, Fabian Ebner wrote: free_image doesn't need to check for protection, because that will happen on the server. Getting/updating notes has also been refactored to re-use the code for the PBS api calls. Signed-off-by: Fabian Ebner --- Needs new external dependency for strptime (

Re: [pve-devel] [RFC storage 4/6] fix #3307: make it possible to set protection for backups

2021-09-24 Thread Dominik Csapak
On 9/17/21 15:02, Fabian Ebner wrote: A protected backup is not removed by free_image and ignored when pruning. The protection_file_path function is introduced in Storage.pm, so that it can also be used by vzdump itself and in archive_remove. Signed-off-by: Fabian Ebner --- Needs an APIAGE+AP

Re: [pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes

2021-09-24 Thread Dominik Csapak
On 9/17/21 15:02, Fabian Ebner wrote: replacing the ones for handling notes. The generic implementation in Plugin.pm will fall back to the methods for notes to ensure backwards compatibility with external plugins. This is mainly done to avoid the need to add new methods every time a new attribut

Re: [pve-devel] [PATCH storage 1/6] dir plugin: update notes: don't attempt to remove non-existent notes

2021-09-24 Thread Dominik Csapak
On 9/17/21 15:02, Fabian Ebner wrote: Signed-off-by: Fabian Ebner --- PVE/Storage/DirPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm index 2267f11..0423e5f 100644 --- a/PVE/Storage/DirPlugin.pm +++ b/PVE/Storage

[pve-devel] [PATCH qemu-server 2/3] vm_start/vm_resume : add_nets_bridge_fdb

2021-09-24 Thread Alexandre Derumier
on vm start (no live migration), we can simply add mac address in fdb. In case of a live migration, we add the mac address just before the resume. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH qemu-server 3/3] migration : add del_nets_bridge_fdb

2021-09-24 Thread Alexandre Derumier
at the end of a live migration, we need to remove old mac entries on source host (vm is not yet stopped), before resume vm on target host Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm| 1 + PVE/QemuServer.pm | 20 test/Migr

[pve-devel] [PATCH pve-container 1/1] net : add support for bridge disable mac learning

2021-09-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm | 11 --- src/lxcnetaddbr | 6 +- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index dbdec23..66c972f 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -939,8 +939,13 @@ sub upd

[pve-devel] [PATCH pve-network 2/4] zones : tap_plug: add support for disable bridge learning

2021-09-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm| 4 +++- PVE/Network/SDN/Zones/Plugin.pm | 2 +- PVE/Network/SDN/Zones/QinQPlugin.pm | 1 + PVE/Network/SDN/Zones/VlanPlugin.pm | 5 + 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN

[pve-devel] [PATCH pve-network 1/4] vnets: fix get_vnet

2021-09-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Vnets.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/Network/SDN/Vnets.pm b/PVE/Network/SDN/Vnets.pm index 86967a3..f6d7ab0 100644 --- a/PVE/Network/SDN/Vnets.pm +++ b/PVE/Network/SDN/Vnets.pm @@ -54,15 +54,

[pve-devel] [PATCH qemu-server 1/3] tap_plug: add support for bridge disable learning

2021-09-24 Thread Alexandre Derumier
This disabling mac learning && unicast flood for the tap interface for vmstart, we don't add mac directly to fdb. We set it latter if it's a migration or a fresh start. for nic hotplug, we directly add mac to fdb Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 7 ++-

[pve-devel] [PATCH qemu-server 0/3] add disable bridge learning feature

2021-09-24 Thread Alexandre Derumier
following pve-common https://lists.proxmox.com/pipermail/pve-devel/2021-September/050090.html Alexandre Derumier (3): tap_plug: add support for bridge disable learning vm_start/vm_resume : add_nets_bridge_fdb migration : add del_nets_bridge_fdb PVE/QemuMigrate.pm| 1 +

[pve-devel] [PATCH pve-container 0/1] add disable bridge learning feature

2021-09-24 Thread Alexandre Derumier
following pve-common https://lists.proxmox.com/pipermail/pve-devel/2021-September/050090.html Alexandre Derumier (1): net : add support for bridge disable mac learning src/PVE/LXC.pm | 11 --- src/lxcnetaddbr | 6 +- 2 files changed, 13 insertions(+), 4 deletions(-) -- 2.30.2

[pve-devel] [PATCH pve-network 0/4] add disable bridge learning feature

2021-09-24 Thread Alexandre Derumier
following pve-common https://lists.proxmox.com/pipermail/pve-devel/2021-September/050090.html Alexandre Derumier (4): vnets: fix get_vnet zones : tap_plug: add support for disable bridge learning zones: add add_bridge_fdb zones: add del_bridge_fdb PVE/Network/SDN/Vnets.pm|

[pve-devel] [PATCH pve-network 4/4] zones: add del_bridge_fdb

2021-09-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index 011446f..39988b6 100644 --- a/PVE/Network/SDN/Zones.pm +++ b/PVE/Network/SDN/Zones.pm @@ -337,5 +337,19 @@ s

[pve-devel] [PATCH pve-network 3/4] zones: add add_bridge_fdb

2021-09-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index c59a724..011446f 100644 --- a/PVE/Network/SDN/Zones.pm +++ b/PVE/Network/SDN/Zones.pm @@ -323,5 +323,19 @@ s

[pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature

2021-09-24 Thread Alexandre Derumier
Currently, if bridge receive an unknown dest mac (network bug/attack/..), we are flooding packets to all bridge ports. This can waste cpu time, even more with firewall enabled. Also, if firewall is used with reject action, the src mac of RST packet is the original unknown dest mac. (This can block

[pve-devel] [PATCH pve-common 1/2] network: add support for disabling bridge learning on tap|veth|fwln ports

2021-09-24 Thread Alexandre Derumier
Currently, if bridge receive an unknown dest mac (network bug/attack/..), we are flooding packets to all bridge ports. This can waste cpu time, even more with firewall enabled. Also, if firewall is used with reject action, the src mac of RST packet is the original unknown dest mac. (This can block

[pve-devel] [PATCH pve-common 2/2] Inotify: add bridge-disable-mac-learning option to bridges.

2021-09-24 Thread Alexandre Derumier
This is an internal option, only used by proxmox, and not ifupdown1/2 Signed-off-by: Alexandre Derumier --- src/PVE/INotify.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 4ff63e8..db942b1 100644 --- a/src/PVE/INotify.pm +++