Re: [pve-devel] [PATCH v2 manager 5/5] ui/UplaodToStorage: check file extension

2021-08-02 Thread Dominik Csapak
comment inline On 7/22/21 15:06, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 17 + 1 file changed, 17 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index

Re: [pve-devel] [PATCH v2 manager 3/5] ui/UploadToStorage: add checksum and algorithm

2021-08-02 Thread Dominik Csapak
comments inline On 7/22/21 15:06, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 32 ++ 1 file changed, 32 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage

Re: [pve-devel] [PATCH v2 manager 2/5] ui: refactor UploadToStorage.js

2021-08-02 Thread Dominik Csapak
comments inline: On 7/22/21 15:06, Lorenz Stechauner wrote: this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. the check for FormData() is also removed, because this is supported by all maj

Re: [pve-devel] [PATCH v1 storage 2/9] add disk rename feature

2021-08-02 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: Functionality has been added for the following storage types: * directory ones, based on the default implementation: * directory * NFS * CIFS * gluster * ZFS * (thin) LVM * Ceph A new feature `rename` has been introduced to mark w

Re: [pve-devel] [PATCH v1 storage 1/9] storage: expose find_free_diskname

2021-08-02 Thread Fabian Ebner
Am 19.07.21 um 16:52 schrieb Aaron Lauterer: We do not expose the parameter 'add_fmt_suffix' used by the internal implemantion of 'find_free_diskname'. This is something only the plugins themselves know but cannot be determined easily and reliably from an outside caller. This is why the new 'wan

[pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension re

2021-08-02 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- changes to v1: * factored $compressor_extension_re out of $backup_extension_re should now be less confusing PVE/Storage.pm| 14 +- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/PVE/Sto

Re: [pve-devel] [PATCH v2 qemu-server 3/3] restore: remove efidisk from config if not backed up

2021-08-02 Thread Stefan Reiter
On 7/23/21 11:02 AM, Thomas Lamprecht wrote: On 08.07.21 13:46, Stefan Reiter wrote: If it doesn't exist, there's no need to keep it around at all. Such a backup might easily be created if an efidisk is configured with BIOS set to anything but 'OVMF'. Unbreaks live-restore for such cases too.

Re: [pve-devel] [PATCH pve-storage] fix #3555: BTRFSPlugin: call free_image correctly

2021-08-02 Thread Wolfgang Bumiller
On Mon, Aug 02, 2021 at 10:29:32AM +0200, Fabian Ebner wrote: > Am 30.07.21 um 13:04 schrieb Hannes Laimer: > > Signed-off-by: Hannes Laimer > > --- > > PVE/Storage/BTRFSPlugin.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/St

Re: [pve-devel] [PATCH pve-storage] fix #3555: BTRFSPlugin: call free_image correctly

2021-08-02 Thread Fabian Ebner
Am 30.07.21 um 13:04 schrieb Hannes Laimer: Signed-off-by: Hannes Laimer --- PVE/Storage/BTRFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm index 4596b30..411cab9 100644 --- a/PVE/Storage/BTRFSPlugin.pm ++