See added patches for more info, overview:
0044: slightly increase PBS performance by reducing allocations
0045: slightly increase block-stream performance for Ceph
0046: don't crash with block-stream on RBD
0047: add alloc-track driver for live restore
Signed-off-by: Stefan Reiter
---
v3:
* imp
On 15.03.21 15:32, Dominik Csapak wrote:
> thanks, applied all 5 patches and pushed 2 small fixups after
> please take a look :)
>
Thanks, both look OK!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/l
thanks, applied all 5 patches and pushed 2 small fixups after
please take a look :)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
series looks mostly fine, just a comment inline below...
On Wed, Mar 03, 2021 at 10:56:04AM +0100, Stefan Reiter wrote:
> See added patches for more info, overview:
> 0044: slightly increase PBS performance by reducing allocations
> 0045: slightly increase block-stream performance for Ceph
> 0046:
On 11.03.21 11:26, Fabian Ebner wrote:
> Commit d02262048cbbe91ca8b12f98e3dc7bbab28e4c64 made the property de-facto
> non-optional. Partially revert this and instead adapt the printing, making the
> behavior match the API description again. The conditional assignment is
> already there further down
On 11.03.21 11:26, Fabian Ebner wrote:
> because they are valid for '-list' formats and it makes the behavior match
> with
> what we do for VM configs. The new pattern is the same that is used for VM
> configs. Because it is a non-greedy pattern, trailing whitespaces will not be
> included in the
On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'pct status --verbose' if it's false.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Breaks pve-manager without the first patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
>
same here, looks OK, but
On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'qm status --verbose' if it's false.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
>
we need to hold that on
On 11.03.21 11:26, Fabian Ebner wrote:
> The API doesn't advertise the property as non-optional and it's safer and more
> in line with the surrounding code.
>
> Signed-off-by: Fabian Ebner
> ---
>
> New in v2.
>
> Needed for the next two patches to work.
>
> www/manager6/lxc/Config.js | 2 +-
On 12.03.21 10:50, Fabian Ebner wrote:
> Previously, $count was not increased and no test failure was reported.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Found by messing up in the previous patch at first with:
> my $res = map { $_ => [] } keys %{$ids};
> instead of
> my $res = { map { $
On 12.03.21 10:50, Fabian Ebner wrote:
> Only these storages are activated in the first place, and it's bad behavior to
> list images when no appropriate content type is not set.
>
> For example, on VM destruction, this avoids unreferenced images to be deleted
> from a storage with only 'backup' c
On 12.03.21 10:50, Fabian Ebner wrote:
> Only these storages are activated in the first place, and it's bad behavior to
> list images when no appropriate content type is not set.
>
> For example, on VM destruction, this avoids unreferenced images to be deleted
> from a storage with only 'backup' c
On 15.03.21 12:57, Fabian Ebner wrote:
> At this stage, there are no keys in %storage_limits to iterate over. The
> refactoring in commit 9f3d73bc353c79f84498122b779764184f504005 broke the logic
> by accident.
>
> Also explicitly set zero if there is no limit to avoid repeating the
> get_bandwith_
At this stage, there are no keys in %storage_limits to iterate over. The
refactoring in commit 9f3d73bc353c79f84498122b779764184f504005 broke the logic
by accident.
Also explicitly set zero if there is no limit to avoid repeating the
get_bandwith_limit call for the same storage. When accessing the
The initial value is '' and in getSubmitValue(), previously the branch
if (v == 0 || v == 0.0) return null;
was taken, because of the lax '==' comparision. Make sure we still return null
for '' by explicitly checking for it.
Signed-off-by: Fabian Ebner
---
www/manager6/form/BandwidthSelector.
by allowing zero and updating the field name. Otherwise the hint mentioning zero
is wrong. Also, it's not only a read limit as the emptyText already indicates.
Signed-off-by: Fabian Ebner
---
www/manager6/window/Restore.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www
On March 9, 2021 11:43 am, Dominic Jäger wrote:
> This is required to import from LVM storages
>
> Signed-off-by: Dominic Jäger
> ---
> v5->v6: unchanged
>
> PVE/Storage.pm | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index
still a few more comments inline - but this is taking up shape (and the
next iteration will be shorter ;)).
On March 9, 2021 11:43 am, Dominic Jäger wrote:
> Extend qm importdisk/importovf functionality to the API.
>
> Signed-off-by: Dominic Jäger
>
> ---
> v5->v6:
> More parsing
> Fix regex
>
Signed-off-by: Thomas Lamprecht
---
PVE/Status/InfluxDB.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
index d7ea6ce2..e5dfca39 100644
--- a/PVE/Status/InfluxDB.pm
+++ b/PVE/Status/InfluxDB.pm
@@ -192,7 +192,7 @@ sub _connect
I normally use a reverse proxy in front of my influxdb instances,
proxying all from the /influx/ path to the only locally listening
influxdb. So here I'd need to set "influx" as api-path-prefix.
Signed-off-by: Thomas Lamprecht
---
PVE/Status/InfluxDB.pm | 23 +++
1 file chang
Signed-off-by: Thomas Lamprecht
---
www/manager6/dc/MetricServerView.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/dc/MetricServerView.js
b/www/manager6/dc/MetricServerView.js
index edb40cc5..c599886f 100644
--- a/www/manager6/dc/MetricServerView.js
+++ b/www/m
Not a hard error, some network box (proxy) down the line could add it
for us, or it could be just not required, so ...
Signed-off-by: Thomas Lamprecht
---
PVE/Status/InfluxDB.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/Influ
Signed-off-by: Thomas Lamprecht
---
PVE/Status/InfluxDB.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
index e5dfca39..712a30ff 100644
--- a/PVE/Status/InfluxDB.pm
+++ b/PVE/Status/InfluxDB.pm
@@ -207,6 +207,11 @@ sub test_connection {
23 matches
Mail list logo
