On 12.03.21 10:50, Fabian Ebner wrote: > Only these storages are activated in the first place, and it's bad behavior to > list images when no appropriate content type is not set. > > For example, on VM destruction, this avoids unreferenced images to be deleted > from a storage with only 'backup' content type set, which is supposedly what > happened in this[0] forum thread. > > (Some) callers expect all keys to be present and valid array references in the > result, so initialization is needed. > > Now, the enabled check is already done by the preceding code for every element > that is iterated over, and thus isn't needed in the main loop anymore. > > [0]: > https://forum.proxmox.com/threads/erasing-all-vm-disks-after-a-failed-vm-migration-task.85068 > > Signed-off-by: Fabian Ebner <f.eb...@proxmox.com> > --- > > Why isn't 'iterand' a word? >
Seems like it has at least some use in the wild, and may be clear enough to no cause confusion when used. https://softwareengineering.stackexchange.com/a/310191 > PVE/Storage.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
