On 19.08.20 17:01, Stefan Reiter wrote:
> Makes the log output more useful for dirty bitmap backups and fixes some minor
> issues.
>
> A new QMP call is introduced to avoid shoving even more data in the possibly
> often called 'query-backup' and not having to do some hacky special casing for
> the
On 27.07.20 15:55, Aaron Lauterer wrote:
> Edid support was added with Qemu 5. Windows guests seem to not be able
> to get all possible resolutions if the default std VGA device is used as
> GPU and the VM boots in BIOS mode. The result is that only one of the
> following three resolutions can be c
When $target is 0, that means we don't have to upload any data, in which
case we're immediately done.
Otherwise incremental backups with no changes display a really weird
status: 0% (0.0 B of 0.0 B), duration 0, read: 0 B/s, write: 0 B/s
when they're actually done already.
Signed-off-by: Stefan
Makes the log output more useful for dirty bitmap backups and fixes some minor
issues.
A new QMP call is introduced to avoid shoving even more data in the possibly
often called 'query-backup' and not having to do some hacky special casing for
the first query iteration.
The new QMP call is gated b
Previously 'read' and 'write' would always show the same value, which is
of little use. Change it so 'write' excludes reused bytes, thus
displaying the actual upload speed.
$last_reused needs to be initialized to contain reused data from 'clean'
dirty bitmaps to ensure the first output line is cor
Returns advanced information about dirty bitmaps used (or not used) for
the latest PBS backup.
Signed-off-by: Stefan Reiter
---
monitor/hmp-cmds.c | 28 ++-
pve-backup.c | 117 ---
qapi/block-core.json | 57 -
3 file
Uses the new 'query-pbs-bitmap-info' QMP call to retrieve additional
information about each drive's dirty bitmap. Returned info is also used
to calculate $target by simply adding all the dirty values (dirty is
equal to size in case the entire drive will be backed up).
"Backup is sparse" message is
There can't be a dirty bitmap when the VM was off, and if it was off we
will also shut it down after the backup, so no point in creating one.
Signed-off-by: Stefan Reiter
---
PVE/VZDump/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/VZDump/QemuServer.pm b
Signed-off-by: Thomas Lamprecht
---
replaces
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044629.html
www/manager6/storage/PBSEdit.js | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index
On 13.08.20 12:57, Fabian Grünbichler wrote:
> and unify encryption key generation strings.
>
> Signed-off-by: Fabian Grünbichler
> ---
> I don't think this check for isCreate makes sense, but maybe I am
> missing something?
yeah, we cannot trust "original" value in the !get('isCreate') case..
On 13.08.20 13:50, Stefan Reiter wrote:
> Both the PBS and VMA dump callbacks assume that a NULL pointer can be
> passed as *pbuf, but that never happens, as backup-dump.c calls this
> function with contents of an iovec.
>
> So first, remove that assumption and add an 'assert' to verify.
>
> Seco
On 19.08.20 12:21, Luc Milland wrote:
> something is wrong :)
>
> "Abonnement mixtes" > "Abonnements mixtes"
arg, pesky plural.. Fixed, thanks!
cheers,
Thomas
>
> and "clé d'abonnement" does not sound great to me, but I do not have better
> to suggest right now...
>
> cheers,
> Luc
>
> Le 1
something is wrong :)
"Abonnement mixtes" > "Abonnements mixtes"
and "clé d'abonnement" does not sound great to me, but I do not have
better to suggest right now...
cheers,
Luc
Le 19/08/2020 12:15, Thomas Lamprecht a écrit :
Thanks to both of you, I now applied the following commit:
https:/
Since it was necessary to switch to 'Type=Simple' in the systemd
service (see 545d6f0a13ac2bf3a8d3f224c19c0e0def12116d ),
'systemctl start pve-container@ID' would not wait for the 'lxc-start'
command anymore. Thus every container start was reported as a success
and the 'post-start' hook would trigg
Thanks to both of you, I now applied the following commit:
https://git.proxmox.com/?p=proxmox-i18n.git;a=commitdiff;h=e04cfca4e734234bddd56775c8e0519f4bb4a6bd
Please holler me if there's something wrong.
cheers,
Thomas
___
pve-devel mailing list
pve-d
Signed-off-by: Hannes Laimer
---
v1->v2: - split into two patches: [3/5]v1 into [2/6]+[3/6]v2
src/window/SafeDestroy.js | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index 81c7c27..a456aba 100644
--- a/src/wi
Signed-off-by: Hannes Laimer
---
I could not find any, already existing, langstring to use here.
"Can I re-add the same one after wards?" No, since the disk contains partitions
and data. It
has to be cleared before it may be re-"created" again.
www/DirectoryList.js | 25 +++
Signed-off-by: Hannes Laimer
---
v1->v2: NEW
src/Utils.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Utils.js b/src/Utils.js
index 4be95b2..6373440 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -641,6 +641,7 @@ utilities: {
stopall: ['', gettext('Stop all VMs and Container
Signed-off-by: Hannes Laimer
---
v1->v2: - kept name
- introduced purgeable and taskName as config in SafeDestroy, in
order to avoid having downstream logic here
- fixed eslint related issues
src/Makefile | 1 +
src/window/SafeDest
Signed-off-by: Hannes Laimer
---
v1->v2: - no changes
src/api2/node/disks/directory.rs | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs
index 0d9ddeef..90d0ee76 100644
--- a/src/api2/node/disks/directory.rs
+++ b/src/api
Signed-off-by: Hannes Laimer
---
v1->v2: - adjusted usages of SafeDestroy
www/manager6/Makefile | 1 -
www/manager6/ceph/Pool.js | 5 +-
www/manager6/lxc/Config.js | 5 +-
www/manager6/qemu/Config.js | 5 +-
www/manager6/storage/ContentView.js |
Added functionality to remove directories in the PBS WebUI. In order to do that
SafeDestroy had to be refactored from pve-manager into proxmox-widget-toolkit
and the possibility to show a small note in the dialog was added. Due to the
refactorization the usages of SafeDestroy in pve-manager had
On 13.08.20 14:03, Stefan Reiter wrote:
> Returns advanced information about dirty bitmaps used (or not used) for
> the latest PBS backup.
>
removing the "dirty" field breaks reporting in older qemu-server versions, I'd
would like to avoid that if it isn't to big of a hassle..
_
Signed-off-by: Aaron Lauterer
---
rfc -> v1: nothing changed
PVE/Storage/CephFSPlugin.pm | 5 +
PVE/Storage/DRBDPlugin.pm| 5 +
PVE/Storage/GlusterfsPlugin.pm | 5 +
PVE/Storage/ISCSIDirectPlugin.pm | 5 +
PVE/Storage/ISCSIPlugin.pm | 4
PVE/Storage/ZFSP
Signed-off-by: Aaron Lauterer
---
rfc -> v1: nothing changed
PVE/CLI/qm.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 282fa86..c947884 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -913,6 +913,8 @@ our $cmddef = {
move_disk => [ "PVE::API
Functionality has been added for the following storage types:
* dir based ones
* directory
* NFS
* CIFS
* ZFS
* (thin) LVM
* Ceph RBD
Signed-off-by: Aaron Lauterer
---
rfc -> v1: nothing changed
PVE/Storage.pm | 10 ++
PVE/Storage/LVMPlugin.pm | 15 ++
This RFC series implements a new feature which allows users to easily
reassign disks between VMs. Currently this is only possible with one of
the following manual steps:
* rename the disk image/file and do a `qm rescan`
* configure the disk manually and use the old image name, having an
image
The goal of this new API endpoint is to provide an easy way to move a
disk between VMs as this was only possible with manual intervention
until now. Either by renaming the VM disk or by manually adding the
disks volid to the config of the other VM.
The latter can easily cause unexpected behavior s
Signed-off-by: Aaron Lauterer
---
rfc -> v1: nothing changed
src/Utils.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Utils.js b/src/Utils.js
index 4be95b2..c022084 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -583,6 +583,7 @@ utilities: {
qmigrate: ['VM', gettext('Migrate
Hi,
I was about to second the choice of "souscription", but something does
not fit : in french, a subscription has no validity status per se.
Maybe "abonnement" would be better then, as it widely used for all kind
of services subscriptions (phone, dsl, ...).
cheers,
Luc
Le 19/08/2020 08:50
On 30.07.20 11:04, Dominik Csapak wrote:
> to call out/err/logfunc with each line, we search for a newline and call
> outfunc/logfunc with everything before that
>
> since we do a select/read (with 4096 size) in a loop, this means
> that if we have very long lines, we search for a newline in an
>
31 matches
Mail list logo