Re: [Update] math/octave 9.2.0

2024-12-04 Thread Volker Schlecht
On 2024-12-03 16:57, Stuart Henderson wrote: On 2024/11/20 21:58, Volker Schlecht wrote: Index: configure --- configure.orig +++ configure I recommend patching the autoconf input file and regenerating configure with autoconf. (I realise it's already done like that, but it could be changed).

Re: [Update] math/octave 9.2.0

2024-12-03 Thread Stuart Henderson
On 2024/11/20 21:58, Volker Schlecht wrote: > Index: configure > --- configure.orig > +++ configure I recommend patching the autoconf input file and regenerating configure with autoconf. (I realise it's already done like that, but it could be changed). It tends to result in less breakage in upd

Re: [Update] math/octave 9.2.0

2024-12-02 Thread Volker Schlecht
Ping. On 2024-11-24 22:53, Volker Schlecht wrote: On 2024-11-24 19:49, Christian Weisgerber wrote: +- canonical_host_type=$host ++ canonical_host_type=$host_cpu-$host_vendor-$host_os Why this part? configure --host=... should already set this. I removed this part of the patch, ran config

Re: [Update] math/octave 9.2.0

2024-11-24 Thread Volker Schlecht
On 2024-11-24 23:02, Kirill A. Korinsky wrote: Maybe something like this? Probably it makes support much easy. pre-configure: @sed -i 's,readline,ereadline,g' ${WRKSRC}/configure I leave that one to MAINTAINER. Personally, I'm not a fan of this approach, though.

Re: [Update] math/octave 9.2.0

2024-11-24 Thread Kirill A . Korinsky
On Sun, 24 Nov 2024 22:53:57 +0100, Volker Schlecht wrote: > > Index: configure > --- configure.orig > +++ configure > -@@ -80591,7 +80591,7 @@ printf "%s\n" "$as_me: WARNING: $warn_rapidjson" > >&2;} > +@@ -82150,21 +82150,21 @@ fi > + case "$found_dir" in > + */$ac

Re: [Update] math/octave 9.2.0

2024-11-24 Thread Volker Schlecht
On 2024-11-24 19:49, Christian Weisgerber wrote: +- canonical_host_type=$host ++ canonical_host_type=$host_cpu-$host_vendor-$host_os Why this part? configure --host=... should already set this. I removed this part of the patch, ran configure, and canonical_host_type was set to "x86_64-unkn

Re: [Update] math/octave 9.2.0

2024-11-24 Thread Christian Weisgerber
Volker Schlecht: > --- patches/patch-configure 24 Aug 2022 19:53:39 - 1.18 > +++ patches/patch-configure 20 Nov 2024 20:39:33 - > @@ -1,9 +1,66 @@ > -Use GNU readline as our base readline lacks rl_prefer_env_winsize. > +* Use GNU readline as our base readline lacks rl_prefer_env_w