Re: Review Request 111849: custom first week for plasmaclock.

tings → locale → country/region & language → calendar → first day of the week? - Martin Tobias Holmedahl Sandsmark On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review87736 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On

Review Request 128164: Use QIcon for background icon for folder thumbnails

--- Tried running both without: https://iskrembilen.com/screenshots/withoutplasmaintegration.png and with plasma-integration: https://iskrembilen.com/screenshots/withplasmaintegration.png Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasm

Re: Review Request 128164: Use QIcon for background icon for folder thumbnails

com/screenshots/withoutplasmaintegration.png and with plasma-integration: https://iskrembilen.com/screenshots/withplasmaintegration.png Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128429: Fix strings in tooltips

. Repository: libksysguard Description --- Changed the strings to use proper kuit markup. Diffs - processui/ProcessModel.cpp c55cea6 Diff: https://git.reviewboard.kde.org/r/128429/diff/ Testing --- Viewed all the tooltips. Thanks, Martin Tobias Holmedahl Sandsmark

Review Request 128431: Fix race condition when new applications open

t. Diffs - processui/ProcessModel.cpp c55cea6 Diff: https://git.reviewboard.kde.org/r/128431/diff/ Testing --- It doesn't happen anymore. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-deve

Re: Review Request 128429: Fix strings in tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128429/#review97330 ----------- On July 12, 2016, 7:24 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > -

Re: Review Request 128431: Fix race condition when new applications open

On July 12, 2016, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 128431: Fix race condition when new applications open

iff: https://git.reviewboard.kde.org/r/128431/diff/ Testing --- It doesn't happen anymore. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

/ Testing --- Now it is possible to run applications that have tray icons with the plasma platform plugin even when the status notifier item host is down or unavailable. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

: https://git.reviewboard.kde.org/r/128473/#review97514 ------- On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

create a systray > > icon before Plasma is started. > > Martin Tobias Holmedahl Sandsmark wrote: > it still creates a systray icon, it just creates an "old style" tray icon. > > Martin Gräßlin wrote: > > it still creates a systray icon, it just create

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

create a systray > > icon before Plasma is started. > > Martin Tobias Holmedahl Sandsmark wrote: > it still creates a systray icon, it just creates an "old style" tray icon. > > Martin Gräßlin wrote: > > it still creates a systray icon, it just create

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

create a systray > > icon before Plasma is started. > > Martin Tobias Holmedahl Sandsmark wrote: > it still creates a systray icon, it just creates an "old style" tray icon. > > Martin Gräßlin wrote: > > it still creates a systray icon, it just create

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

rrect either, that's what I thought was the "proper" way to do it) - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128473/#review97506 ----

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

ecks if we're using the KDE platform theme (albeit in a > > slightly weird way) > > > > Not saying yours is "worse" but we don't want two fixes in two places. > > > > Could you check you have that patch? and why it doesn't work? > > Marti

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

create a systray > > icon before Plasma is started. > > Martin Tobias Holmedahl Sandsmark wrote: > it still creates a systray icon, it just creates an "old style" tray icon. > > Martin Gräßlin wrote: > > it still creates a systray icon, it just create

Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

well. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

cpi.c acf54e1 Diff: https://git.reviewboard.kde.org/r/128491/diff/ Testing --- It works very well. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

iffs (updated) - ksysguardd/Linux/acpi.h e50b281 ksysguardd/Linux/acpi.c acf54e1 Diff: https://git.reviewboard.kde.org/r/128491/diff/ Testing --- It works very well. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

g devices have a percentage of activity, they're > not boolean on or off. > > I'll reverse the tabs->spaces later, if needed. > > > Diffs > - > > ksysguardd/Linux/acpi.h e50b281 > ksysguardd/Linux/acpi.c acf54e1 > > Diff: https://git.reviewboard.kde.o

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

cpi.c acf54e1 Diff: https://git.reviewboard.kde.org/r/128491/diff/ Testing --- It works very well. Thanks, Martin Tobias Holmedahl Sandsmark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

ecks if we're using the KDE platform theme (albeit in a > > slightly weird way) > > > > Not saying yours is "worse" but we don't want two fixes in two places. > > > > Could you check you have that patch? and why it doesn't work? > > Marti

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

ecks if we're using the KDE platform theme (albeit in a > > slightly weird way) > > > > Not saying yours is "worse" but we don't want two fixes in two places. > > > > Could you check you have that patch? and why it doesn't work? > > Marti

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

ommit this soonish. - Martin Tobias Holmedahl Sandsmark On July 21, 2016, 2:25 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

ecks if we're using the KDE platform theme (albeit in a > > slightly weird way) > > > > Not saying yours is "worse" but we don't want two fixes in two places. > > > > Could you check you have that patch? and why it doesn't work? > > Marti

Re: Review Request 128429: Fix strings in tooltips

/ Testing --- Viewed all the tooltips. Thanks, Martin Tobias Holmedahl Sandsmark

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

activity, they're not boolean on or off. I'll reverse the tabs->spaces later, if needed. Diffs - ksysguardd/Linux/acpi.h e50b281 ksysguardd/Linux/acpi.c acf54e1 Diff: https://git.reviewboard.kde.org/r/128491/diff/ Testing --- It works very well. Thanks,

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

ecks if we're using the KDE platform theme (albeit in a > > slightly weird way) > > > > Not saying yours is "worse" but we don't want two fixes in two places. > > > > Could you check you have that patch? and why it doesn't work? > > Marti

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

/kdeplatformtheme.cpp 5f0407c Diff: https://git.reviewboard.kde.org/r/128473/diff/ Testing --- Now it is possible to run applications that have tray icons with the plasma platform plugin even when the status notifier item host is down or unavailable. Thanks, Martin Tobias Holmedahl Sandsmark

Re: Review Request 128761: Fix crash on exit

explicitly not supported by Qt, it will lead to random crashes all over the place. See e. g. https://quickgit.kde.org/?p=konsole.git&a=commit&h=fe334292b5402ad0fd4b934291160ece9a12d953 and https://bugreports.qt.io/browse/QTBUG-48709 - Martin Tobias Holmedahl Sandsmark On Aug. 27, 2016, 9:12 a.m

Re: Review Request 128429: Fix strings in tooltips

/r/128429/diff/ Testing --- Viewed all the tooltips. Thanks, Martin Tobias Holmedahl Sandsmark

Re: Review Request 128429: Fix strings in tooltips

to use proper kuit markup. Diffs - processui/ProcessModel.cpp 8151dfe Diff: https://git.reviewboard.kde.org/r/128429/diff/ Testing --- Viewed all the tooltips. Thanks, Martin Tobias Holmedahl Sandsmark

D28651: Load and use global animation settings

sandsmark created this revision. sandsmark added a reviewer: Breeze. sandsmark added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sandsmark requested review of this revision. REVISION SUMMARY In addition to the specific Breeze animation settings, KD

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79914. sandsmark added a comment. Also made it store to the global configuration. This way it is backwards compatible, but the config can also be changed from both places. I think it makes sense to have it both places, having it in the breeze setti

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#643681 , @ndavis wrote: > I don't know enough about KDE configuration management to judge the code, but with this patch, changing animation speeds in SySe works if I restart apps after the change. The

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79916. sandsmark added a comment. Now should reload the animation settings when changed anywhere. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28651?vs=79914&id=79916 REVISION DETAIL https://phabricator.kde.org/D28

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#646572 , @ndavis wrote: > You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. I usually just push normally after approval, but I'

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#647122 , @davidedmundson wrote: > As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically rep

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 80551. sandsmark added a comment. Remove the duplication of animation control, and don't override the animation settings if people haven't adjusted it globally. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28651?vs=7

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added a comment. > It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now. > I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up. I assume this is for p

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added inline comments. INLINE COMMENTS > ConnectionMapping.cpp:157 > +// Should be within the first 16 characters. > +size_t data_start = data.find(':'); > +if (data_start >= 16) { if we're going for ultra optimized, const everything I guess. > ConnectionMappin

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added inline comments. INLINE COMMENTS > sandsmark wrote in ConnectionMapping.cpp:167 > instead of 87 + 1, maybe have a `constexpr int lineLength = strlen("0: > 0100:0277 : > 0A : 00:

D27034: Fix message box when passing a remote url that includes a file

sandsmark added a comment. This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27034 To: apol, #frameworks,

D28651: Load and use global animation settings

sandsmark added a comment. Should I move this to invent, or just push it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-D