sandsmark added inline comments.
INLINE COMMENTS
> sandsmark wrote in ConnectionMapping.cpp:167
> instead of 87 + 1, maybe have a `constexpr int lineLength = strlen("0:
> 00000000000000000000000001000000:0277 00000000000000000000000000000000:0000
> 0A 00000000:00000000 00:00000000 00000000 0 0 16741");` above with
> the comment?
> or:
>
> constexpr const char *exampleLine = "0:
> 00000000000000000000000001000000:0277 00000000000000000000000000000000:0000
> 0A 00000000:00000000 00:00000000 00000000 0 0 16741";
> constexpr int lineLength = strlen(exampleLine);
>
> both more understandable and less prone to accidentally putting in the wrong
> number.
>
> same with all other magic string offset numbers here.
To see that it is actually optimized properly: https://godbolt.org/z/sL2_pK
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D29808
To: dkorth, ahiemstra
Cc: sandsmark, ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
