Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-18 Thread Lars Pontoppidan
-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10 Thanks, Lars Pontoppidan ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-18 Thread Lars Pontoppidan
/mediaframeplugin.h PRE-CREATION applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing (updated) --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-21 Thread Lars Pontoppidan
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review91257 ------- On Jan. 18, 2016, 11:27 a.m., Lars Pontoppidan wrote: > > -

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Lars Pontoppidan
f the fixes? What do you guys usually do? - Lars --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92041 ------- O

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-05 Thread Lars Pontoppidan
aframe/plugin/mediaframe.cpp, line 142 > > <https://git.reviewboard.kde.org/r/126793/diff/1/?file=434185#file434185line142> > > > > I wonder if this should be done in another thread, have a look at > > [plasma-workspace]/wallpapers/image/image.cpp where it does that.

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-05 Thread Lars Pontoppidan
/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-05 Thread Lars Pontoppidan
t; function also as an applet. > > > > You have a lot of empty lines with whitespace in your code. Please check > > your editor settings. > > Marco Martin wrote: > let's have it back, then let's think about how to semplify it by loading > wallpaper plug

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-06 Thread Lars Pontoppidan
applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-08 Thread Lars Pontoppidan
/plugin/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan ___ Plasma-devel

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-08 Thread Lars Pontoppidan
t; function also as an applet. > > > > You have a lot of empty lines with whitespace in your code. Please check > > your editor settings. > > Marco Martin wrote: > let's have it back, then let's think about how to semplify it by loading > wallpaper plug

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-08 Thread Lars Pontoppidan
> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote: > > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see > > get in once all the issues have been addressed. Family members are > > depending upon it. ;) > > Lars Pontoppidan wrote: &g

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92661 --- On Feb. 8, 2016, 11:34 a.m., Lars Pontoppidan wrote: > >

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
onfig? Good question :) - Lars --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92661 --- On Feb. 8, 2016, 1

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
t I think we're all good > > to go. > > Lars Pontoppidan wrote: > No worries - I just hope we can make it to the release :) All issues fixed - how should I proceed from here? - Lars --- This is an au

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
to use QtQuickControls.Button not > > PlasmaComponents > > Lars Pontoppidan wrote: > I'm having trouble showing the SVG icons - how do I obtain the URL for > the iconSource? > > Marco Martin wrote: > on QtQuickcontrols to use icon names you shou

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-23 Thread Lars Pontoppidan
/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan ___ Plasma

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92714 --- Ship it! Ship It! - Lars Pontoppidan On Feb. 23, 2016

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
t I think we're all good > > to go. > > Lars Pontoppidan wrote: > No worries - I just hope we can make it to the release :) > > Lars Pontoppidan wrote: > All issues fixed - how should I proceed from here? > > Luca Beltrame wrote: > Given that yo

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
t I think we're all good > > to go. > > Lars Pontoppidan wrote: > No worries - I just hope we can make it to the release :) > > Lars Pontoppidan wrote: > All issues fixed - how should I proceed from here? > > Luca Beltrame wrote: > Given that yo

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
> On Feb. 24, 2016, 10:34 a.m., Lars Pontoppidan wrote: > > Ship It! > > Marco Martin wrote: > you can do the actual merge now, you still have to do it via git. I've done my best - it's in master now :) - Thanks - Lars ---

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
/mediaframeplugin.cpp PRE-CREATION applets/mediaframe/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126793/diff/ Testing --- kdeplasma-addons builds on Kubuntu 15.10. Thanks, Lars Pontoppidan ___ Plasma-devel mailing list

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-24 Thread Lars Pontoppidan
> On Feb. 24, 2016, 10:34 a.m., Lars Pontoppidan wrote: > > Ship It! > > Marco Martin wrote: > you can do the actual merge now, you still have to do it via git. > > Lars Pontoppidan wrote: > I've done my best - it's in master now :) - Thanks >