> On Feb. 23, 2016, 1:38 p.m., David Edmundson wrote: > > Sorry for the massive delay. That's really messed up on our side. > > > > We have a feature freeze next wednesday, it would be great to get this all > > merged by then. I just had a few tiny comments, but I think we're all good > > to go.
No worries - I just hope we can make it to the release :) > On Feb. 23, 2016, 1:38 p.m., David Edmundson wrote: > > applets/mediaframe/package/contents/ui/main.qml, line 26 > > <https://git.reviewboard.kde.org/r/126793/diff/4/?file=443795#file443795line26> > > > > whilst the video code is commented out, comment this out too. > > > > (or remove it) > > > > Otherwise we potentially have plasma failing to start if it's not > > installed for no benefit Yeah you're so right - I removed the ``` import QtGraphicalEffects 1.0 ``` as well - not used > On Feb. 23, 2016, 1:38 p.m., David Edmundson wrote: > > applets/mediaframe/package/contents/ui/ConfigPaths.qml, line 176 > > <https://git.reviewboard.kde.org/r/126793/diff/4/?file=443794#file443794line176> > > > > if this is a config page you need to use QtQuickControls.Button not > > PlasmaComponents I'm having trouble showing the SVG icons - how do I obtain the URL for the iconSource? - Lars ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92661 ----------------------------------------------------------- On Feb. 8, 2016, 11:34 a.m., Lars Pontoppidan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126793/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:34 a.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > KF5 version of the (Picture) Frame widget > > > Diffs > ----- > > applets/CMakeLists.txt ed938f8 > applets/mediaframe/CMakeLists.txt PRE-CREATION > applets/mediaframe/Messages.sh PRE-CREATION > applets/mediaframe/package/contents/config/config.qml PRE-CREATION > applets/mediaframe/package/contents/config/main.xml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION > applets/mediaframe/package/contents/ui/main.qml PRE-CREATION > applets/mediaframe/package/metadata.desktop PRE-CREATION > applets/mediaframe/plugin/mediaframe.h PRE-CREATION > applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION > applets/mediaframe/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126793/diff/ > > > Testing > ------- > > kdeplasma-addons builds on Kubuntu 15.10. > > > Thanks, > > Lars Pontoppidan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
