Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

s.txt 92eb3c7ae98660eb00e33fbe608de1580ea75912 thumbnail/jpegcreator.h 5cab30ff6a0881863ec66d739063f6dbfb4a48f7 thumbnail/jpegcreator.cpp 9191fbacd21c65c9fc845fd7c77365005cd8df00 Diff: https://git.reviewboard.kde.org/r/129851/diff/ Testing --- Thanks, Alexander Volkov

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

129851/#review102089 --- On Jan. 18, 2017, 11:36 p.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

marked as submitted. Review request for Plasma. Changes --- Submitted with commit c249f8547f2d1913e0570d78a0240c5f8865c336 by Alexander Volkov to branch master. Repository: kio-extras Description --- QImageReader::setScaledSize() allows to use fast downscaling for jpeg images (by

D4939: Get rid of KDELibs4Support

volkov added a comment. Please, replace QWeakPointer with QPointer in a separate commit. As for Solid::PowerManagement, it was actually added to the solid library as Solid::Power, but it's not built by default. Try to port to that new API. REPOSITORY R122 Powerdevil REVISION DETAIL

D4939: Get rid of KDELibs4Support

volkov added a reviewer: afiestas. volkov added a comment. Will it be hard to reanimate it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D4939: Get rid of KDELibs4Support

volkov added a comment. Actually we depend only on Solid::PowerManagement::supportedSleepStates(). But there is PowerDevil::BackendInterface::supportedSuspendMethods(). I guess it would be right to use it instead. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/

D4939: Get rid of KDELibs4Support

volkov added a comment. 1. Extract QWeakPointer/QPointer change into a separate commit. 2. Use PowerDevil::BackendInterface::supportedSuspendMethods() instead of Solid::PowerManagement::supportedSleepStates(). REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939

D4939: Get rid of KDELibs4Support

volkov added inline comments. INLINE COMMENTS > CMakeLists.txt:111 > +qt5_add_dbus_adaptor(powerdevil_SRCS > ${SOLID_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.xml > powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementfdoadaptor > PowerManagementFdoAdaptor) > +qt5_ad

D4939: Get rid of KDELibs4Support

volkov added inline comments. INLINE COMMENTS > denisshienkov wrote in CMakeLists.txt:111 > Where I need to take an appropriate XML files then? Copy them here. > denisshienkov wrote in powerdevilcore.cpp:102 > > It seems to be more reasonable to request supported methods from powerdevil > > da

D4970: Get rid of QWeakPointer

volkov added a comment. From the the documentation of QObject::~QObject: "Warning: Deleting a QObject while pending events are waiting to be delivered can cause a crash." REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano,

D4970: Get rid of QWeakPointer

volkov added a comment. https://community.kde.org/Infrastructure/Get_a_Developer_Account "After you obtained your KDE Identity, visit the Developer Application page to apply for a KDE Developer Account." "Normally, any developer who has done some work on projects hosted by KDE can appl

D4939: Get rid of KDELibs4Support

volkov added inline comments. INLINE COMMENTS > denisshienkov wrote in CMakeLists.txt:111 > Are you sure that I need to copy a files as > kf5_org.freedesktop.PowerManagement.xml and > kf5_org.freedesktop.PowerManagement.Inhibit.xml from: > /usr/share/dbus-1/interfaces/ to this project? What f

D4939: Get rid of KDELibs4Support

volkov added a comment. Looks good to me. powerdevilpowermanagement.{h,cpp} should be extracted into a library, but it can be done in a separate commit. Since they deal with org.freedesktop.PowerManagement interface which is obsolete and implemented only by PowerDevil, I suppose such

D26032: feat: add Control API for auto rotation

volkov added inline comments. INLINE COMMENTS > control.cpp:266 > +const auto val = info[QStringLiteral("autorotate")]; > +return !val.canConvert() || val.toBool(); > +} Why treat an inconvertible value as true and not false? REPOSITORY R104 KScreen REVISION D

D14562: Introduce Theme.smallestFont

volkov updated this revision to Diff 76554. volkov added a comment. registered for 2.2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14562?vs=38964&id=76554 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14562 AFFECTED FILES src/contr

D28683: Get rid of workaround that prevents file dialog from being blocked

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Invisible proxy QDialog blocks input when the native dialog is shown, and the workaround is to show the native file dialog with a de

D28683: Get rid of workaround that prevents file dialog from being blocked

volkov added a comment. DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28683 To: volkov, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Fere

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

volkov abandoned this revision. volkov added a comment. Moved to https://invent.kde.org/plasma/breeze/-/merge_requests/7 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc: graesslin, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, T

D28683: Get rid of workaround that prevents file dialog from being blocked

volkov abandoned this revision. volkov added a comment. Moved to https://invent.kde.org/plasma/plasma-integration/-/merge_requests/1 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28683 To: volkov, #plasma Cc: plasma-devel, Orage, L

D14562: Introduce Theme.smallestFont

volkov created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It can be useful in itself and when porting code from Plasma. REPOSITORY R169 Kirigami BRANCH

D14562: Introduce Theme.smallestFont

volkov added inline comments. INLINE COMMENTS > mart wrote in kirigamiplugin.cpp:173 > this will break completely every import < 2.6 So, should it be registered for both versions 2.2 and 2.6? I tried to use revisions, but it looks like they don't work for properties of attached property objects

D14562: Introduce Theme.smallestFont

volkov added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: > https://doc.qt.io/qt-5/qtqml-cppinteg

D14562: Introduce Theme.smallestFont

volkov added a comment. Why add it to qml-base theme implementations? Aren't they obsolete? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein

D14793: Update connection details only when necessary

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY They are needed only when the Details tab is visible. In other cases, their update is just eating CP

D14794: Port away from KLocale and KDELibs4Support

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14794

D14793: Update connection details only when necessary

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14793 To: volkov, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14794: Port away from KLocale and KDELibs4Support

volkov updated this revision to Diff 39618. volkov added a comment. QLocale::nativeCountryName() may return an empty string, fallback to using QLocale::countryToString() in this case. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D14794: Port away from KLocale and KDELibs4Support

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14794 To: volkov, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It's more correct to get information about devices from a single source, i.e. from NetworkManager. Besides it allows to show the t

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov added inline comments. INLINE COMMENTS > broulik wrote in networkmodel.cpp:220 > Would it be better to only request the data when the statistics are open to > avoid wakeups and processing? Yes, good point. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://pha

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov updated this revision to Diff 39790. volkov added a comment. update device statistics only when it's shown REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39698&id=39790 BRANCH master REVISION DETAIL https://pha

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov added a comment. Unfortunately KDE Neon is based on Ubuntu 16.04 (Xenial) which is using NM 1.2: https://packages.ubuntu.com/source/xenial/network-manager REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgru

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov updated this revision to Diff 40632. volkov added a comment. minimize the number of setDeviceStatisticsRefreshRateMs() callings REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14835?vs=39790&id=40632 BRANCH master REVISION

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich, sitter, jriddell Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D15289: Use lambda instead of QSignalMapper

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY QSignalMapper is obsolete and the code with lambda is shorter and clearer. REPOSITORY R111 KSysguard Library BRANCH master REVI

D15289: Use lambda instead of QSignalMapper

volkov updated this revision to Diff 41045. volkov added a comment. revert change of actionTriggered's signature REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15289?vs=41043&id=41045 BRANCH master REVISION DETAIL https://phabricator.kde.org

D15289: Use lambda instead of QSignalMapper

volkov closed this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D15289 To: volkov, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15297: Use QOverload to select overloaded functions

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D15297 AFFECTED FILES kded/notifica

D15297: Use QOverload to select overloaded functions

volkov closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15297 To: volkov, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15946: Avoid creation of needless temporary containers

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Found by clazy. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D15946 AFFECTED FI

D15946: Avoid creation of needless temporary containers

volkov added inline comments. INLINE COMMENTS > broulik wrote in waylandoutput.cpp:64 > I think we typically use `const...()` instead of `c...()` but since this > method is `const`, shouldn't be neccessary to begin with Isn't it better to follow STL style? cbegin is also popular in KDE project

D15946: Avoid creation of needless temporary containers

volkov updated this revision to Diff 42860. volkov added a comment. fixed REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15946?vs=42859&id=42860 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15946 AFFECTED FILES backends/kwayla

D15946: Avoid creation of needless temporary containers

volkov added inline comments. INLINE COMMENTS > broulik wrote in output.cpp:101 > The previous code also compared the contents of both, or does your new loop > below do that? Yes, the check is in the loop below: `after` and `before` are of the same sizes, and if `after` contains each key from

D15946: Avoid creation of needless temporary containers

volkov closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D15946 To: volkov, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15969: Add support for systemd's suspend-then-hibernate

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D15969 AFFECTED FILES daemon/actions/bundled/handlebutton

D16400: Prefer to set current mode in resolution combobox

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Preferred resolution may be lower than current resolution (e.g. on KVM), in this case it will be selected in the combobox instead of

D16547: Connect slots explicitly instead of using auto-connections

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Auto-connections is bad practice cause object renames break code and it can't be detected at compile time. REPOSITORY R121 Policy

D16547: Connect slots explicitly instead of using auto-connections

volkov updated this revision to Diff 44551. volkov added a comment. rename slot REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16547?vs=44550&id=44551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16547 AFFECTED FILE

D16547: Connect slots explicitly instead of using auto-connections

volkov closed this revision. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D16547 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16400: Prefer to set current mode in resolution combobox

volkov closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16400 To: volkov, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

volkov added a comment. I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed. One can see the current speed on the graph. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL ht

D16269: Show correct current download and upload speed

volkov added a comment. The problem with this change is that speed is shown in bytes, not in bytes/s. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D16269 To: jgrulich, #plasma, broulik Cc: volkov, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D17659: Set parent window for dialogs

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY This requires fix in Qt to work for standard dialogs: https://codereview.qt-project.org/#/c/248559/ REPOSITORY R838 Flatpak Suppo

D17659: Set parent window for dialogs

volkov added a comment. Is it possible to implement support for foreign windows in KWin QPA plugin? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol

D17659: Set parent window for dialogs

volkov closed this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17659: Set parent window for dialogs

volkov added a comment. I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol, plasma-devel, kvanton, jralei

D17659: Set parent window for dialogs

volkov added a comment. Oh, I see. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D18300: [Mouse KCM] Port away from KDELibs4Support

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18300 AFFECTED FILES kcms/mouse/CMakeLists.txt kcm

D18300: [Mouse KCM] Port away from KDELibs4Support

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18300 To: volkov, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18449: Remove dependency on KDELibs4Support for some KCM modules

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D18449 AFFECTED FILES kcms/access/CMakeLists.txt

D18449: Remove dependency on KDELibs4Support for some KCM modules

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18449 To: volkov, broulik Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18454: Fonts KCM: Port from kde_file.h to QFileInfo

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18454 AFFECTED FILES kcms/fonts/kxftconfig.cpp kcm

D18454: Fonts KCM: Port from kde_file.h to QFileInfo

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18454 To: volkov, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Amend 2f83a4434a888cd17b03af1f9925cbb054256ade . REPOSITO

D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:14d6402abc34: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp} (authored by volkov). REPOSITORY R119 Plasma

D26244: Install all kcm plugins into kcms subdir

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY To reduce clutter in the plugins dir. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.or

D26244: Install all kcm plugins into kcms subdir

volkov updated this revision to Diff 72390. volkov added a comment. build metadata from desktop files into the plugins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26244?vs=72249&id=72390 BRANCH master REVISION DETAIL https://phabricator.kde.

D20445: signalplotter: Add highdpi support

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20445 AFFECTED FILES signalplotter/ksignalplotter

D20445: signalplotter: Add highdpi support

volkov added a comment. Hi, thanks for the review. I know about the issues, I've uploaded the patch to avoid losing it :) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20445 To: volkov Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, les

D20445: signalplotter: Add highdpi support

volkov updated this revision to Diff 56079. volkov added a comment. reduced beam width REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20445?vs=55922&id=56079 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20445 AFFECTED FILES

D20445: signalplotter: Add highdpi support

volkov updated this revision to Diff 56102. volkov added a comment. use QPen::setWidthF() instead of QPen::setWidth() REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20445?vs=56079&id=56102 BRANCH master REVISION DETAIL https://phabricator.kd

D20445: signalplotter: Add highdpi support

volkov added inline comments. INLINE COMMENTS > zzag wrote in ksignalplotter.cpp:897-899 > Could you please explain why we have to do this? To avoid artifacts when painting beams. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20445 To: volkov Cc: zzag, pla

D20445: signalplotter: Add highdpi support

volkov added a comment. Beams look ugly when their width is >= 4 pixels. The idea is to draw them with the same width regardless of DPI. Another option is to not set Qt::FlatCap for thick pens, but I prefer this one. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricat

D22482: WIP: Show file dialog in directory mode when only directory is requested

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D22482 AFFECTED FILES

D22482: WIP: Show file dialog in directory mode when only directory is requested

volkov added a comment. This is for non-sandboxed applications that want to use KDE file dialog. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D22482 To: volkov, apol, jgrulich Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22766: Fix positioning of output identifiers on screens with different dprs

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Find QScreen corresponding to KScreen::Output and use its geometry to position the output identifier. REPOSITORY R104 KScreen BR

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > kiconloader.cpp:1368 > > -if (group >= 0 && group < KIconLoader::LastGroup) { > +if (group >= 0) { > img = d->mpEffect.apply(img, group, state); Why this line reverts D12002 ? REPOSITORY R30

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:1368 > Dunno, probably oversight or forgotten to rebase.. Looks like a rebase: https://phabricator.kde.org/D6313?vs=31197&id=34779&whitespace=ignore-most#toc REPOSITORY R302 KIconThemes REVISION DETAIL https:

D7013: Middle-click on QSystemTrayIcon сauses context menu

volkov added a comment. Restricted Application added a subscriber: plasma-devel. Is there a reason why KDEPlatformSystemTrayIcon is supported? Why don't drop it and rely on Qt's dbus tray implementation? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://p

D9625: Require Qt 5.7

volkov added a reviewer: Plasma. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9625: Require Qt 5.7

volkov updated this revision to Diff 24659. volkov added a comment. move to master Require Qt 5.7 -> Require Qt 5.9 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9625?vs=24637&id=24659 BRANCH master REVISION DETAIL

D9625: Require Qt 5.9

volkov retitled this revision from "Require Qt 5.7" to "Require Qt 5.9". volkov edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff

D9643: Support submenus in context menu for systray icon

volkov added reviewers: Plasma, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

volkov added a comment. BTW, why do we need to support KDEPlatformSystemTrayIcon? Why don't rely on QDBusTrayIcon? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwo

D9625: Require Qt 5.9

volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9643: Support submenus in context menu for systray icon

volkov added a comment. Thanks for the real-world example. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progw

D9643: Support submenus in context menu for systray icon

volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D9733: Display exclusive actions correctly in systray menus

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Add exclusive actions to their own action groups so that they could be diplayed as radio buttons by

D9733: Display exclusive actions correctly in systray menus

volkov added a reviewer: Plasma. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

volkov added a comment. Testing example: F5629785: tray-exclusive-actions.tar.xz REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, l

D9733: Display exclusive actions correctly in systray menus

volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D10036: Bump Qt version to 5.9

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY For Plasma/5.12. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://ph

D10036: Bump Qt version to 5.9

volkov added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10036 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10036: Bump Qt version to 5.9

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10036 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10037: Remove QT_VERSION checks

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY We require Qt 5.9, so these checks are redundant. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5

D10037: Remove QT_VERSION checks

volkov added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10037 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10037: Remove QT_VERSION checks

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10037 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10038: Use QTemporaryDir::filePath() instead of path concatenation

volkov created this revision. volkov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY This is the preferred way to get a file path in a temporary directo

D10038: Use QTemporaryDir::filePath() instead of path concatenation

volkov added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10038 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10038: Use QTemporaryDir::filePath() instead of path concatenation

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10038 To: volkov, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

  1   2   >