volkov added inline comments.

INLINE COMMENTS

> control.cpp:266
> +            const auto val = info[QStringLiteral("autorotate")];
> +            return !val.canConvert<bool>() || val.toBool();
> +        }

Why treat an inconvertible value as true and not false?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26032

To: romangg, #plasma
Cc: volkov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to