hein added a comment.
No, unsetting taskManagerItem is dumb code IMHO. I'll address your concern a
different way. Thanks for the input.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4525
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpr
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4532
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, apol, hein
Cc: pla
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4531
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, apol, hein
Cc: plasma-
hein accepted this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4534
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, fvogt, #plasma, davidedmundson, dfaure, hein
Cc: plasma-devel, lesliezhai, ali-mohamed,
anthonyfieroni added a comment.
You can try in Task.qml
onHighlightedChanged: {
if (highlighted) {
backend.cancelHighlightWindows();
}
}
If it can help :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4525
EMAIL PR
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ecfcc8ea6e49: fix discover desktopid in favorties
(authored by sitter).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4532?vs=11123&id=11147
REVISION DETAI
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:12193b07f12b: add discover to the system application tab
in kickoff (authored by sitter).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4531?vs=11122&id=111
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/607/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 09:16:07 +
Build duration: 5 min 45 sec
CHANGE SET
Revision 5eb79cf68eb7883da4a4b8d132b70f
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/608/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 09:25:07 +
Build duration: 5 min 34 sec
CHANGE SET
Revision 12193b07f12b7620a04248cc66b126
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 09:15:02 +
Build duration: 19 min
CHANGE SET
Revision ecfcc8ea6e494fa118e2d613c5
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
Had a ConfigC
broulik updated the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4543
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4543
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: brouli
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:29179f115c81: Avoid a crash on Kwin decoration KCM
teardown (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4533?vs=11126&id=11151
REVISI
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4535
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
broulik changed the repository for this revision from R131 Plasma Wallpapers to
R108 KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4530
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #kwin
Cc: plasma-devel, l
graesslin added a comment.
We do have autotests for this in
autotests/integration/screenedge_client_show_test.cpp
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4530
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:51c4d6c8db82: Fix crash in Screen Locker KCM on teardown
(authored by davidedmundson).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4535?vs=11128&id=11152
graesslin added inline comments.
INLINE COMMENTS
> client.cpp:2086-2094
> +const auto &screenGeometry = screens()->geometry(screen());
> +
> +switch (border) {
> +case ElectricTop:
> +if (geometry().top() == screenGeometry.top())
bbuch requested changes to this revision.
bbuch added a reviewer: bbuch.
bbuch added a comment.
This revision now requires changes to proceed.
This doesn't work for Usernames and the resulting keyFile is different from
the old behavior. (It contains the closing ": ")
Please change the reg
hein added a comment.
I feel like both of those are papering over the real bug, which that we never
figured out how to exempt the GroupDialog successfully from the highlight
effect. This just breaks highlight for group members ...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://p
hein updated this revision to Diff 11153.
hein added a comment.
- Do highlighting from the group dialog properly instead of intentionally
breaking it via a side effect that caused this crash.
- Some extra crash guards.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://ph
hein updated this revision to Diff 11154.
hein added a comment.
Drop stray debug.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4525?vs=11153&id=11154
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4525
AFFECTED FILES
applet
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise when dropping onto a fold
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4544
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, hein, #plasma
Cc: plasma-devel, leslie
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5becf5bc114e: [ConfigModel] Emit dataChanged when a
ConfigCategory changes (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
hein closed this revision.
hein added a comment.
Forgot to close.
REVISION DETAIL
https://phabricator.kde.org/D2932
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mart
Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:32c7d2d060c7: [Folder View] Support extracting files to
sub-directories with drag and drop… (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4544?vs=11157&id=11159#toc
REP
hein updated this revision to Diff 11160.
hein added a comment.
Drop another stray debug.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4525?vs=11154&id=11160
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4525
AFFECTED FILES
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 11:35:35 +
Build duration: 5 min 55 sec
CHANGE SET
Revision 32c7d2d060c7a942f677
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
hein/fastFoldersNew
REVISION DETAIL
https://phabricator.kde.org/D4343
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/em
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/609/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 11:39:30 +
Build duration: 15 min
CHANGE SET
Revision 32c7d2d060c7a942f67737cec63f50dc85e0
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b893dc9ad6a2: Remove the TextFix workaround for QML text
mouse handling bug. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4345?vs=10701
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7fd62b59b77f: Delay setting the model on the view until
listing is finished. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4344?vs=10704
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:99c903059f59: Greatly improve Folder View performance and
mem usage. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4343?vs=10705&id=1116
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/610/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 11:57:30 +
Build duration: 5 min 31 sec
CHANGE SET
Revision 99c903059f591f2e9dd15b64e73422
idekels updated this revision to Diff 11164.
idekels added a comment.
- changes requested by bbuch
1. Updating https://phabricator.kde.org/D4540: fix bug with git after update
to Plasma 5.9 in neon #
2. Enter a brief description of the changes included in this update.
3. The first lin
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6f2b57b4925d: Make notifications execute the "default"
action on click. (authored by albertvaka, committed by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.
apol created this revision.
apol added reviewers: Plasma, mart, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Make sure clicking on them will work the same on the popup and the delegate,
there were some
apol added a reviewer: albertvaka.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, mart, davidedmundson, albertvaka
Cc: plasma-devel, lesliezhai, ali-mohame
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/741/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 12:19:51 +
Build duration: 13 min
CHANGE SET
Revision 6f2b57b4925d7d24bf9b9b7945c4c806ba
hein created this revision.
hein added reviewers: Plasma, mart.
hein added a subscriber: plasma-devel.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Without being able to get the menu size it's not possible to
broulik added a comment.
We have this openRelateive thing with "bottom left posed" and what not,
shouldn't it have a thing for "have the bottom left corner of the menu be at
the top of the parent item"?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.o
hein created this revision.
hein added reviewers: Plasma, mart.
hein added a subscriber: plasma-devel.
hein added a dependency: D4546: Add more API to enable custom menu positioning..
Restricted Application added a project: Plasma.
REVISION SUMMARY
openRelative() will position the menu at the to
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/742/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 12:34:21 +
Build duration: 14 min
CHANGE SET
Revision 86b7aaf408383aad4f27910c9259494e7d
hein added a comment.
I'm not convinced it's worth it. This patch allows writing the same sort of
code we already have in ContainmentInterface for context menu placement. If we
resort to doing it there then clearly we need it in other places as well.
(And I wrote openRelative ...)
I
hein added a comment.
Although ... maybe one hack we could do is change the meaning of
"TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent"
instead of "0,0 of menu at top of visualParent". Marco?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://ph
hein added a dependent revision: D4547: Use new PlasmaComponents.ContextMenu
API for improved placement when at bottom edge..
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4546
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:49dbf1beaff2: Fix KCModule::setAuthAction error checking
(authored by davidedmundson).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4471?vs=10991&id=11172
mart added a comment.
In https://phabricator.kde.org/D4546#84979, @hein wrote:
> Although ... maybe one hack we could do is change the meaning of
"TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent"
instead of "0,0 of menu at top of visualParent". Marco?
thi
ppalaga created this revision.
ppalaga set the repository for this revision to R119 Plasma Desktop.
ppalaga added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This improves the rendering when the task manager is oriented vertically.
Before this ch
ppalaga added reviewers: broulik, davidedmundson, hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ppalaga, broulik, davidedmundson, hein
Cc: plasma-devel, lesliezhai,
albertvaka added a comment.
What? This shouldn't have been pushed! It still has the old behaviour...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4215
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #plasm
albertvaka added inline comments.
INLINE COMMENTS
> NotificationDelegate.qml:36-37
>
> -enabled: true
> -checked: notificationItem.containsMouse
> -
This was there so they highlight on hover. Is it not needed anymore?
> NotificationItem.qml:70
> +action("default")
> +
vishalrao created this revision.
vishalrao set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is a patch to make the Network Monitor desktop plasmoid widget
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/743/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 13:45:18 +
Build duration: 14 min
CHANGE SET
Revision 1c513a0dcd9a26bcdd4129271014db300c
davidedmundson added a comment.
In general fine.
INLINE COMMENTS
> net.qml:42
>
> -delegate: DoublePlotter {}
> -}
> \ No newline at end of file
> +function formatBitSize(value) {
> +if (value > 1048576) {
formatBitSpeed ?
Otherwise it's confusing
> net.qml:44
> +
Zren added a comment.
Any reason for not using
if (...) {
} else if (...) {
} else {
}
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4551
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vishalrao
Cc: Zren, d
vishalrao added a comment.
In https://phabricator.kde.org/D4551#85039, @Zren wrote:
> Any reason for not using
>
> if (...) {
> } else if (...) {
> } else {
> }
No real reason, the statements are single lines and returns so thought this
is okay - should I change to us
vishalrao updated this revision to Diff 11178.
vishalrao added a comment.
Updated per David's comments.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4551?vs=11176&id=11178
REVISION DETAIL
https://phabricator.kde.org/D4551
AFFECTED FILES
app
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4551
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
sebas added inline comments.
INLINE COMMENTS
> net.qml:43
> +function formatBitSpeed(value) {
> +if (value > 1048576) {
> +return i18nc("%1 is the data transfer speed in megabits per
> second", "%1 Mbps", (value / 1048576).toFixed(1));
Perhaps explain this "magic number"
hein abandoned this revision.
hein added a comment.
Abandon for an approach in frameworks.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4547
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mart
Cc: plasma
hein updated this revision to Diff 11180.
hein added a comment.
New approach.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4546?vs=11168&id=11180
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4546
AFFECTED FILES
sr
hein added a comment.
I'm sorry, but I'm not inclined to accept this patch - I think this is
over-configurability. It might make more sense to do this in a fork on the KDE
Store for people who want a combo of extremely narrow panels and a column of
multi-line text.
REPOSITORY
R119 Plasma
hein added a comment.
To expand on the updated patch (I wrote a new commit message, but Phab
doesn't notice automatically): The TM appears to be the only user of
TopPosedLeftAlignedPopup currently, and the new behavior is also in line with
the "Popup positioned on the top" docstring for the
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4546
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mar
vishalrao updated this revision to Diff 11181.
vishalrao marked 3 inline comments as done.
vishalrao added a comment.
Update per sebas' comments.
Instead of a comment for the magic number, used a perhaps more recognisable
(1024 * 1024) value.
Added the word "displayed" to the i18nc c
vishalrao marked 2 inline comments as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4551
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vishalrao, davidedmundson
Cc: sebas, Zren, davidedmundson, plasma-devel, leslie
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:701771833ee1: Align bottom edge to top edge of
visualParent in the TopPosedLeftAlignedPopup… (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabri
broulik added a comment.
-1
Can we please stay at *Bytes* per second instead of *Bits*. We don't use that
anywhere else, copying files also doesn't use Bytes instead of Bits.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4551
EMAIL PREFERENCES
http
vishalrao added a comment.
In https://phabricator.kde.org/D4551#85078, @broulik wrote:
> -1
>
> Can we please stay at *Bytes* per second instead of *Bits*. We don't use
that anywhere else, copying files also uses Bytes instead of Bits.
>
> Also, what's up with the 1024 everywhere,
Zren added a comment.
Ah, just noticed the title (bytes => bits), and I agree it should remain
bytes, or at least be optional.
> I proposed bits per second for network monitor only since users internet
speeds are advertised/shown as "Mbps" or "Kbps" or the like.
Do the math (divide
https://bugs.kde.org/show_bug.cgi?id=376301
Bug ID: 376301
Summary: sftp.so not closing connections when ProxyCommand is
configured
Product: kio-extras
Version: unspecified
Platform: Ubuntu Packages
OS: Linu
anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4525
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, a
anthonyfieroni requested changes to this revision.
anthonyfieroni added a comment.
This revision now requires changes to proceed.
One more change, wait for me :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4525
EMAIL PREFERENCES
https://phabricator.kde.o
anthonyfieroni added a comment.
Task.qml line 145 add
backend.cancelHighlightWindows();
So when it's pressed button (left, middle, right) on task it show always stop
highlight effect :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4525
EMAIL PREFERENCE
broulik added a comment.
I agree, adding options for everything and the kitchen sink is not the way to
go.
INLINE COMMENTS
> ConfigGeneral.qml:105
> +Label {
> +text: i18n("Minimum characters per line:")
> +}
gridUnit is not a character bu
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c2f74cc8c8dd: [Folder View] Don't show script execution
prompt on desktop:/ (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4534?vs=111
broulik added a comment.
This can be abandoned now, right?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4171
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, hein, subdiff
Cc: anthonyfi
broulik abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4171
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, hein, subdiff
Cc: anthonyfieroni, mart, Fuchs, plasma-dev
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D4400
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kvermette, #plasma
anthonyfieroni added a comment.
It should be :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4171
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, hein, subdiff
Cc: anthonyfieroni, mart
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 17:58:56 +
Build duration: 6 min 39 sec
CHANGE SET
Revision c97c6024ca3276966258
broulik closed this revision.
broulik added a comment.
Has been submitted as
https://cgit.kde.org/breeze.git/commit/?id=e3fe5b5d84e076afc7ec0d03bc42f0fe7c446d56
(Phab doesn't let me close non-accepted revisions…)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D440
https://bugs.kde.org/show_bug.cgi?id=376301
Andreas changed:
What|Removed |Added
Severity|critical|major
--- Comment #1 from Andreas ---
Reducing sever
anthonyfieroni added a comment.
Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over
other window (not desktop or taskmanager) grabbing stays in taskmanager. I will
investigate for workaround, if someone has a purpose i'll be happy :)
REPOSITORY
R119 Plasma Desktop
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/611/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 18:04:26 +
Build duration: 6 min 6 sec
CHANGE SET
Revision c97c6024ca3276966258f82f3181a23
https://bugs.kde.org/show_bug.cgi?id=375732
Elvis Angelaccio changed:
What|Removed |Added
Component|bars: location |default
Product|dolphin
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is needed so Plasma::DataEngine can construct the metadata
TEST PLAN
Debug. Lots of deb
davidedmundson updated this revision to Diff 11191.
davidedmundson added a comment.
And another one
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4554?vs=11190&id=11191
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4554
AFF
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8da91cde831c: Display speeds in bits per second instead
of KiB/s (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4551?vs=11181
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/744/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 10 Feb 2017 21:08:00 +
Build duration: 14 min
CHANGE SET
Revision 8da91cde831c75111c62f2bc7e2e9481f2
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Just because the metadata is invalid doesn't mean the DataEngine
actual
There's a broken merge.
Please don't push patches in there
Also no making a 5.8 release.
I'll talk to sysadmins and get something fixed.
David
ppalaga added a comment.
Hi Eike und Kai Uwe,
Thanks for your feedback. This is my first submission here, although I am a
loyal user of KDE since 2001. Please be patient with me. I may have fully
inappropriate expectations and I may be violating your processes and rules.
I'll be glad to
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
I thought it was only GTK 3 apps that did that, but fair enough
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D4557
EMAIL
elvisangelaccio created this revision.
elvisangelaccio added reviewers: apol, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Replace true/false with 1/0. The former works only with GTK 3, but
breaks with GTK 2
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4554
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:4a06c4d34f2d: Fix gtk-primary-button-warps-slider with GTK
2 (authored by elvisangelaccio).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4557?vs=
1 - 100 of 110 matches
Mail list logo
