davidedmundson added a comment.
In general fine.
INLINE COMMENTS
> net.qml:42
>
> - delegate: DoublePlotter {}
> -}
> \ No newline at end of file
> + function formatBitSize(value) {
> + if (value > 1048576) {
formatBitSpeed ?
Otherwise it's confusing
> net.qml:44
> + if (value > 1048576) {
> + return i18nc("mbps", "%1 Mbps", (value / 1048576).toFixed(1));
> + }
the c in i18nc means "context"
so it's used as a description of what the message is for for translators so
they know what the string is for, as they can't see the code or where it's used.
Repeating the text doesn't help, we want something like "Transfer speed shown
on a graph label "
This is needed so that the german translation doesn't write an entire 200
character long sentence.
> net.qml:52
> + }
> + return i18nc("zero", "%1", value);
> + }
A context string of "zero" is even more confusing, maybe just return value here.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4551
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vishalrao
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
