Re: Review Request 128707: Add support for captive portals

> On Zář. 5, 2016, 3:47 odp., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DDo

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Zář. 6, 2016, 7:37 dop.) Review request for Network Management,

[Differential] [Closed] D2665: [Task Manager GroupDialog] Implement keyboard navigation

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPab262dff1eec: [Task Manager GroupDialog] Implement keyboard navigation (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

[Differential] [Request, 4 lines] D2667: [Task Manager] GroupDialog has no target but visualParent

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This has task items go to

Re: Review Request 128837: Remove references to kmail indexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128837/ --- (Updated Sept. 6, 2016, 8:18 a.m.) Status -- This change has been ma

[Differential] [Accepted] D2667: [Task Manager] GroupDialog has no target but visualParent

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma-dev

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 306 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/306/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Sep 2016 08:13:02 + Build duration: 11 min CHANGE SET Revision ab262dff1eecd0ea8701e83516e411fbbb08

[Differential] [Closed] D2667: [Task Manager] GroupDialog has no target but visualParent

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP29caa940011d: [Task Manager] GroupDialog has no target but visualParent (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 307 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/307/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Sep 2016 08:27:35 + Build duration: 5 min 50 sec CHANGE SET Revision 2ef21c57c42508833cd2f5dd7151f0

[Differential] [Request, 6 lines] D2668: Fix panelView updateEnabledBorders being skipped

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes the left/right panel edge shadows don't get drawn. A resize doesn't always call pos

Debug plasma crash when plasmoid calls serviceForSource

Hi, the plasmoid I'm developing makes plasma crash when I call serviceForSource. This happens sometimes, and I can reproduce it by flooding plasma with serviceForSource requests (scrolling the mouse wheel over the plasmoid creates a lot of this requests). My plasmoid implements a custom dataengine.

[Differential] [Request, 5 lines] D2669: Set offscreen highlight item to invisible when off screen or not being shown

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Gammaray showed a warning about us having a visible item off screen. This is obviously a wast

[Differential] [Request, 12 lines] D2670: Fix spelling mistake in property name Also mark read only property as readonly

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Grep REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2670

[Differential] [Request, 14 lines] D2671: Reduce duplicated code and document very difficult to parse code.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Panel still loads, is just code moving, so should be no changes. REPOSITORY rPLASMADESKTOP Plasma D

[Differential] [Request, 14 lines] D2672: Remove pointless code

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It doesn't make sense to emit a signal in someone elses layout object 1. only the containm

[Differential] [Changed Subscribers] D2671: Reduce duplicated code and document very difficult to parse code.

broulik added inline comments. INLINE COMMENTS > Panel.qml:97 > +//the size a margin should be to force a panel to be the > required size above > +readonly property real spacingAtMinSize: Math.max(1, > (verticalPanel ? root.width : root.height) - units.iconSizes.smallMed

[Differential] [Accepted] D2670: Fix spelling mistake in property name Also mark read only property as readonly

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2670 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D2669: Set offscreen highlight item to invisible when off screen or not being shown

broulik added a comment. Grepping showed AppletAppearance and AppletHandle also mess with the placeHolderPaint opacity, most likely breaking your binding REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2669 EMAIL PREFERENCES https://phabricator.kd

[Differential] [Commented On] D2671: Reduce duplicated code and document very difficult to parse code.

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in Panel.qml:97 > why real? You cannot (should not) have half pixels There's a Math.round in the usage below, and FrameMargins can also be real, so it's still needed there. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISIO

[Differential] [Accepted] D2669: Set offscreen highlight item to invisible when off screen or not being shown

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Err, nevermind, you didn't add a binding to "opacity" but "visible" REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 308 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/308/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Sep 2016 08:34:17 + Build duration: 11 min CHANGE SET Revision 29caa940011d94544e3fb8ce33c0f5967f01

[Differential] [Updated, 29 lines] D2613: Fix some status notifier items not appearing

davidedmundson updated this revision to Diff 6466. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Fixed Kai's comments REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2613?vs=6333&id=6466 BRANCH maste

[Differential] [Commented On] D2613: Fix some status notifier items not appearing

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in statusnotifieritemsource.cpp:85 > Wrong indentation There is in Phab, but there isn't on my computer... No idea why. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2613 EMAI

Re: Review Request 128707: Add support for captive portals

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DD

Re: Review Request 128707: Add support for captive portals

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DD

[Differential] [Accepted] D2668: Fix panelView updateEnabledBorders being skipped

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2668 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2671: Reduce duplicated code and document very difficult to parse code.

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > davidedmundson wrote in Panel.qml:97 > There's a Math.round in the usage below, and FrameMargins can also be real, > so it's still needed there

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98920 --- >From my perspective using www.kde.org for the browser part o

[Differential] [Closed] D2668: Fix panelView updateEnabledBorders being skipped

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE993983b3c310: Fix panelView updateEnabledBorders being skipped (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Accepted] D2672: Remove pointless code

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Updated] D2672: Remove pointless code

mart added a comment. removing it makes sense to me as that code is weird, here's my research on its history: looking at why it was inserted: commit https://phabricator.kde.org/rPLASMADESKTOP0cf01e3d2a5b8a2e23dad50cfdefffdc093c6bee "This patch fixes this warning and also some render

[Differential] [Commented On] D2672: Remove pointless code

davidedmundson added a comment. Good research, thanks. (I think that makes it my fault for removing half of it, and not the other half) REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2672 EMAIL PREFERENCES https://phabricator.

[Differential] [Closed] D2672: Remove pointless code

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPcb477299c8a4: Remove outdated code (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2672?vs=6465&id=6468 REVI

[Differential] [Closed] D2671: Reduce duplicated code and document very difficult to parse code.

davidedmundson closed this revision. davidedmundson added a comment. submitted REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2671 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc

[Differential] [Closed] D2669: Set offscreen highlight item to invisible when off screen or not being shown

davidedmundson closed this revision. davidedmundson added a comment. submitted REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2669 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik

[Differential] [Closed] D2670: Fix spelling mistake in property name Also mark read only property as readonly

davidedmundson closed this revision. davidedmundson added a comment. submitted REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2670 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik

[Differential] [Closed] D2590: Use new inline revealpassword action

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMANM304ba1978528: Use new inline revealpassword action (authored by davidedmundson). REPOSITORY rPLASMANM Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 309 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/309/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Sep 2016 09:26:48 + Build duration: 7 min 22 sec CHANGE SET Revision 08769ab7e4ca7e8578475da201da5a

[Differential] [Request, 4 lines] D2673: [AppletConfiguration] Don't call saveConfig() twice

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY root.saveConfig() already call

Re: Review Request 128819: grid layout for windowdecoration KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128819/#review98923 --- somethings to change, or is everything fine? - Andreas Kainz

[Differential] [Request, 374 lines] D2674: Add optional filtering by SkipPager window state.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY For use by desktop pagers using libtaskmanager. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVI

[Differential] [Updated, 54 lines] D2674: Add optional filtering by SkipPager window state.

hein updated this revision to Diff 6472. hein added a comment. Remove accidentally committed files. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2674?vs=6471&id=6472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D267

[Differential] [Request, 41 lines] D2675: Add desktop layout rows property.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY For use by Desktop Pagers using libtaskmanager. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH virtd REVIS

[Differential] [Updated] D2674: Add optional filtering by SkipPager window state.

hein added a dependent revision: D2676: Improved and optimized Pager and Activity Pager. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2674 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, davide

[Differential] [Updated] D2675: Add desktop layout rows property.

hein added a dependent revision: D2676: Improved and optimized Pager and Activity Pager. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, davide

[Differential] [Request, 2,551 lines] D2676: Improved and optimized Pager and Activity Pager

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. hein added dependencies: D2675: Add desktop layout rows property., D2674: Add optional filtering by SkipPager window state.. Restricted Application added a project: Plasma. REVISION SU

[Differential] [Updated] D2676: Improved and optimized Pager and Activity Pager

hein added a dependent revision: D2677: Reduce Activity Pager to .desktop file referencing the Pager package.. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2676 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hei

[Differential] [Request, 1,878 lines] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. hein added a dependency: D2676: Improved and optimized Pager and Activity Pager. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on https://phabricator.kde.or

[Differential] [Updated] D2652: Let the application control the menu further

apol marked an inline comment as done. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2652 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colomar, plasma-devel, apol

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

apol updated this revision to Diff 6477. apol added a comment. Fix naming REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6423&id=6477 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2652 AFFECTED FILES src/controls/GlobalDr

[Differential] [Abandoned] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin abandoned this revision. graesslin added a comment. Abandon as the theme changed and I'm rather for adding it to be shown from KWin. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Abandoned] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

graesslin abandoned this revision. graesslin added a comment. Don't think that's needed at all. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas

[Differential] [Accepted] D2674: Add optional filtering by SkipPager window state.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2674 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Request, 10 lines] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We locked favorites in Kickoff

Re: Kiosk Documentation?

On Thu, Aug 25, 2016 at 2:59 PM, Dennis Knorr wrote: > Hi, > i just wanted to look at the new kiosk implementation for plasma 5.7, but > i'm not really sure where to look. I tried > https://userbase.kde.org/KDE_System_Administration/Kiosk/Introduction but > further links there are brokenore empty:

Re: Review Request 128819: grid layout for windowdecoration KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128819/#review98927 --- Ship it! code now looks fine to me - Marco Martin On Se

[Differential] [Requested Changes To] D2652: Let the application control the menu further

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. almost good to go INLINE COMMENTS > GlobalDrawer.qml:369 > stackView.push(menuComponent, > {"model": modelData.children, "level": level + 1})

[Differential] [Accepted] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2678 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes please :D (after https://phabricator.kde.org/D2676 of course) REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator

[Differential] [Accepted] D2652: Let the application control the menu further

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2652 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colom

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

apol updated this revision to Diff 6479. apol added a comment. Ugh... REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6477&id=6479 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2652 AFFECTED FILES src/controls/GlobalDrawer

[Differential] [Request, 6 lines] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

dvratil created this revision. dvratil set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Workaround a crash when a KRunner plugin triggers libQt5Web

[Differential] [Updated] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

dvratil added reviewers: davidedmundson, broulik. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2679 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dvratil, davidedmundson, broulik Cc: plasma-devel, lesliezhai

[Differential] [Updated] D2676: Improved and optimized Pager and Activity Pager

davidedmundson added a comment. Generally awesome. One major bug, rest are tiny comments. Will give it a second review later, as it's a bit patch and I got tired :) INLINE COMMENTS > main.qml:175 > > -mainText: desktopName > -// our ToolTip has maximumLineCoun

[Differential] [Accepted] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

davidedmundson accepted this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D2677 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, davidedmundson, #plasma Cc: mart, plasma-devel

[Differential] [Closed] D2652: Let the application control the menu further

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIdd4173055e14: Let the application control the menu further (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6479&id=6481 REVISI

[Differential] [Changed Subscribers] D2676: Improved and optimized Pager and Activity Pager

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in pagermodel.cpp:250 > emit countChanged in both places couldn't be instead connected modelreset,rowsinserted,rowsdeleted signals to countchanged signal? > davidedmundson wrote in pagermodel.cpp:429 > this is a new feature? >

Re: Review Request 128819: grid layout for windowdecoration KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128819/ --- (Updated Sept. 6, 2016, 1:19 nachm.) Status -- This change has been

[Differential] [Accepted] D2673: [AppletConfiguration] Don't call saveConfig() twice

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2673 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 399 lines] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a

[Differential] [Updated] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #

[Differential] [Updated] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: plasma-devel, lesliezhai

[Differential] [Abandoned] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

dvratil abandoned this revision. dvratil added a comment. Found a way to fix the issue in Akonadi. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2679 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dvratil,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 310 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Sep 2016 13:28:10 + Build duration: 19 min CHANGE SET Revision 9c8b7b7e9aa3d319415d6be1a25367c06395

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

mart added a comment. the owner doesn't seem to be saved and restored anywhere, so it may happen that is not deterministic who owns it? (not sure if needed tough) (btw, if one had an Applet subclass implementation, there is a globalConfig() kconfiggroup thatsaves and reads in an area of app

[Differential] [Accepted] D2675: Add desktop layout rows property.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH virtd REVISION DETAIL https://phabricator.kde.org/D2675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

lbeltrame added a comment. A question: what would happen if a user has existing shortcuts defined already? (I know that's a non-default case) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

mart added a comment. In https://phabricator.kde.org/D2680#49893, @lbeltrame wrote: > A question: what would happen if a user has existing shortcuts defined already? (I know that's a non-default case) afaik then the corresponding shortcuts from the taskbar should be disabled by d

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik added a comment. > the owner doesn't seem to be saved and restored anywhere, so it may happen that is not deterministic who owns it? (not sure if needed tough) In Component.onCompleted it sets itself as owner if its config says the feature is Enabled > btw, if one had an App

[Differential] [Changed Subscribers] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

graesslin added inline comments. INLINE COMMENTS > CMakeLists.txt:35 > + KF5::WindowSystem > + KF5::XmlGui) > Do we really need KActionCollection? At least in KWin I ported away from it, because I don't want the xmlgui dependency. Overall KActionColle

Review Request 128849: [AppletQuickItem] Reduce string comparisons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128849/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Closed] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP9c8b7b7e9aa3: [Task Manager] Disallow adding/removing launchers when system immutable (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://pha

[Differential] [Request, 4 lines] D2681: Remove unused traces of kdesu

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Include is unused, and kdesu should die regardless REPOSITORY rPLASMAWORKSPACE Plasma Worksp

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik added a comment. > Do we really need KActionCollection? At least in KWin I ported away from it, because I don't want the xmlgui dependency. Isn't needed at all from what I can tell. I could just set the component name property manually and call it a day. REPOSITORY rPLASMADESK

[Differential] [Accepted] D2681: Remove unused traces of kdesu

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2681 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

graesslin added a comment. In https://phabricator.kde.org/D2680#49912, @broulik wrote: > > Do we really need KActionCollection? At least in KWin I ported away from it, because I don't want the xmlgui dependency. > > Isn't needed at all from what I can tell. I could just set the compon

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128849/#review98938 --- 1) That seems a somewhat premature optimisation? We do litera

[Differential] [Closed] D2681: Remove unused traces of kdesu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa2202472aa4d: Remove unused traces of kdesu (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2681?vs=648

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

> On Sept. 6, 2016, 2:32 p.m., David Edmundson wrote: > > 1) That seems a somewhat premature optimisation? We do literally millions > > of string comparisons elsewhere. > > > > 2) get rid of the string comparison and compare the metaObject to > > Applet::staticMetaObject() and you can kill th

[Differential] [Request, 9 lines] D2683: Simplify AbstractListItem logic

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it an Item rather than a rectangle, the background item is supposed to be the base item. Make sur

Review Request 128851: [AppletQuickItem] Break from loop when we found a layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128851/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Request, 2 lines] D2682: Make sure padding is respected in the GlobalDrawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sets it just like on the other components, could probably be refactored into a parent's margin REPOSITO

[Differential] [Updated] D2683: Simplify AbstractListItem logic

mart added a comment. good idea, shouldn't add api tough INLINE COMMENTS > AbstractListItem.qml:168 > > -Component.onCompleted: { > +function integrateBackground() { > if (background) { move it into itemMouse (or anywhere where gets hidden from the public api) REPOSITORY

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128849/#review98939 --- Ship it! Ship It! - Marco Martin On Sept. 6, 2016, 2:19

[Differential] [Updated] D2683: Simplify AbstractListItem logic

apol marked an inline comment as done. apol added a comment. Fixed issue REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2683 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Updated, 16 lines] D2683: Simplify AbstractListItem logic

apol updated this revision to Diff 6489. apol added a comment. address as suggested by marco REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2683?vs=6488&id=6489 BRANCH arcpatch-D2683 REVISION DETAIL https://phabricator.kde.org/D2683 AFFECTED FI

[Differential] [Accepted] D2683: Simplify AbstractListItem logic

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH arcpatch-D2683 REVISION DETAIL https://phabricator.kde.org/D2683 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart C

[Differential] [Closed] D2683: Simplify AbstractListItem logic

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI9261ecc98d10: Simplify AbstractListItem logic (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2683?vs=6489&id=6490 REVISION DETAIL h

[Differential] [Updated, 395 lines] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

broulik updated this revision to Diff 6491. broulik added a comment. Get rid of KActionCollection to drop KXmlGui dependency REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2680?vs=6482&id=6491 REVISION DETAIL https://phabricator.kde.org/

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. In https://phabricator.kde.org/D2365#45684, @dfaure wrote: > The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some sel

  1   2   >