> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > <https://git.reviewboard.kde.org/r/128707/diff/4/?file=474728#file474728line50> > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DDoS attack-like effect on it. Maybe > > someone from sysadmin should evaluate this. > > Jan Grulich wrote: > I don't think it will affect it, because when you are behind a captive > portal you will get redirected immediately so kde.org won't be loaded at all. > At least this is my understanding. > > Sebastian Kügler wrote: > The user-friendlier portals will redirect you to the site you were > originally going to, but I agree, kde.org can handle that (it's a static page > request, should be cheap enough). > > What could be pretty cool is if the user would be sent to a page that > allows donating, kde.org does that, so there may be a net advantage, still.
Looking at that angle it is Ok from my side :-) - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98901 ----------------------------------------------------------- On Sept. 6, 2016, 7:37 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128707/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 7:37 a.m.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque > Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: plasma-nm > > > Description > ------- > > Adds portal monitor to our kded module, which checks NetworkManager > connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we > are behind a captive portal), then we open a QWebEngineView trying to load > "http://kde.org"; page which is supposed to be redirected to the captive > portal page. Once user logs in and url changes, we re-check the connectivity > again and close the web view if we are no longer behind the captive portal. > > > Diffs > ----- > > CMakeLists.txt a27c1f2 > kded/CMakeLists.txt 1f0613e > kded/portalmonitor.h PRE-CREATION > kded/portalmonitor.cpp PRE-CREATION > kded/service.cpp 18ffd41 > > Diff: https://git.reviewboard.kde.org/r/128707/diff/ > > > Testing > ------- > > Tested with three different captive portals and it worked perfectly. > > > Thanks, > > Jan Grulich > >
