graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in shutdowndlg.cpp:182
> What are you trying to do here?
>
> (because I'm pretty sure this isn't going to do what you want, and you've got
> a possibility to infinite loop)
Detect when setScreen(QScreen*) is done and then
This revision was automatically updated to reflect the committed changes.
Closed by commit rKINFOCENTER91eea43b2a83: split load into two methods to
improve readability a tad (authored by sitter).
REPOSITORY
rKINFOCENTER KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2299?
On Mon, Aug 1, 2016 at 8:35 AM, Martin Graesslin wrote:
> On Monday, July 25, 2016 12:24:56 PM CEST Jens Reuterberg wrote:
>> KSPLASH
>> Ksplash is removed in favour for two clear effects, one is the "fade to
>> desktop" already present in Kwin, the other is an effect where SDDM fades in
>> a very
On Monday, August 1, 2016 10:49:16 AM CEST Harald Sitter wrote:
> On Mon, Aug 1, 2016 at 8:35 AM, Martin Graesslin wrote:
> > On Monday, July 25, 2016 12:24:56 PM CEST Jens Reuterberg wrote:
> >> KSPLASH
> >> Ksplash is removed in favour for two clear effects, one is the "fade to
> >> desktop" alr
jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
add separate autostart file for klipper
TEST PLAN
install
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
jriddell added a subscriber: graesslin.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2323
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell
Cc: graesslin, plasma-devel, ali-mohamed, jensreuterberg, abet
jriddell updated the summary for this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2323
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell
Cc: graesslin, plasma-devel, ali-mohamed, jensreuterbe
On 07/28/2016 07:11 PM, Jonathan Riddell wrote:
> There's also the issue that if we move for one distro we'll end up
> with accusations of favouratism and requests for moving for other
> distros. But then maybe we do like openSUSE :)
I think it'd show we care about getting shipped and try to wo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/291/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 01 Aug 2016 10:00:10 +
Build duration: 31 min
CHANGE SET
Revision 995a2351c2b2e898d6ed0d87a0037f3575
> On Juli 27, 2016, 12:01 nachm., Jarosław Staniek wrote:
> > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON,
> > nevertheless everyone who compiles breeze-icons needs to know it's needed.
> > It's hard to say not buiulding the rcc files gives any important
> > optimizati
mart closed this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1170
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson, sebas
Cc: plasma-devel, ali-mohamed, jensreuterberg, abet
Minutes Plasma 'hangout', 1-8-2016, 12:00 CET
Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, andreas_k, romangg
bshah:
- mobile images
- Mobile image update
- Did new image with kactivitymanagerd preinstalled on mobile
- Disabled qtvirtualkeyboard on that iamge due to various issues
jriddell added reviewers: graesslin, Plasma.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2323
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell, graesslin, #plasma
Cc: graesslin, plasma-devel, ali-moha
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2323
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jriddell, #
> On July 27, 2016, 2:01 p.m., Jarosław Staniek wrote:
> > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON,
> > nevertheless everyone who compiles breeze-icons needs to know it's needed.
> > It's hard to say not buiulding the rcc files gives any important
> > optimization.
We're testing Mumble for meetings today. It's an app you need to
install then set up then connect to server weegie.edinburghlinux.co.uk
then you can talk to me or whoever is around
It's reliable for audio when I've used it but the setup is a bit of
faff and there's no video.
Please try it and p
> On Juli 27, 2016, 12:01 nachm., Jarosław Staniek wrote:
> > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON,
> > nevertheless everyone who compiles breeze-icons needs to know it's needed.
> > It's hard to say not buiulding the rcc files gives any important
> > optimizati
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in shutdowndlg.cpp:182
> Detect when setScreen(QScreen*) is done and then update the geometry based on
> that screen.
setSecreen will be called when the QWindow geometry changes from code inside
QWindow.
So you don't want
davidedmundson closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2268
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, ivan
Cc: ivan, plasma-devel, ali-mohamed, jensreu
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP14d48bac5f95: Workaround searching lockup
(authored by davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2239?vs=5370&id=559
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP79f842066d05: Remove dead code (authored by
davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2241?vs=5372&id=5600
REVISION
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/233/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 01 Aug 2016 12:51:28 +
Build duration: 5 min 39 sec
CHANGE SET
Revision 28a60da51819ffb0d668d97b281f81b
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/233/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 01 Aug 2016 12:51:28 +
Build duration: 5 min 39 sec
CHANGE SET
Revision 28a60da51819ffb0d668d97b281f81b
On 26.07.2016 18:21, Ivan Čukić wrote:
On Tue, Jul 26, 2016 at 4:01 PM, Dan Leinir Turthra Jensen
wrote:
On Tuesday, 26 July 2016 15:52:41 BST Sebastian Kügler wrote:
bridge to the current logo.
I quite like that one indeed.
Quite keen on that one, yes :)
It is one of my other favs, behind
On Monday 01 August 2016, Thomas Pfeiffer wrote:
> > But I don't give it a +1 on the 'bridge to the current logo' since
> > /that/ Plasma logo is largely unknown (I'd give it +0.5 on that note -
> > while v2 gets both +0.5 because of the recognizable KDE logo, and +0.5
> > for the current plasma 5
> The disadvantages of the second one are that the gears become a bit
> muddled in small sizes and it resembles the gear which is often used
> as a settings icon,
This 'disadvantage' is a bit artificial.
I agree the gears would not be visible on small icon sizes. But small
icons do not need to co
On Monday 01 August 2016, Marco Martin wrote:
> > So, it looks like there are two variants which people are quite fond of,
> > Ken's modifications of Andy's logo (his fourth), and of Alex's logo (his
> > second).
>
> hmm, I'm a bit surprised, as I tought the leading ones so far were ken's
> second
On 01.08.2016 15:16, Marco Martin wrote:
On Monday 01 August 2016, Thomas Pfeiffer wrote:
But I don't give it a +1 on the 'bridge to the current logo' since
/that/ Plasma logo is largely unknown (I'd give it +0.5 on that note -
while v2 gets both +0.5 because of the recognizable KDE logo, and +0
broulik created this revision.
broulik added reviewers: Plasma, afiestas.
broulik set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
A button press (technically
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAINTEGRATION0ad34650c2a7: FEATURE:Switch to Hack
monospace font. (authored by jriddell).
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We were just checking on the lower bounds
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
master
REVISION DETA
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2326
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasm
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/292/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 01 Aug 2016 14:58:26 +
Build duration: 21 min
CHANGE SET
Revision 4c6e6ce91c696fc79d9d6b7d1dc0f5becc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/
---
(Updated Aug. 1, 2016, 5:47 p.m.)
Status
--
This change has been mar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/
---
(Updated Aug. 1, 2016, 3:47 p.m.)
Status
--
This change has been mar
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMIe24d9e255616: Properly check if the page is in bounds
(authored by apol).
REPOSITORY
rKIRIGAMI Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2326?vs=5605&id=5608
REVISION DE
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I'm not sure why it was done like that, but otherwise we're forced into
some margins which look weird, e
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE7ff606de2c7b: add separate autostart file for
klipper (authored by jriddell).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2323?vs
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/
---
(Updated Авг. 1, 2016, 7:22 след обяд)
Review request for Plasma and Eike
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 01 Aug 2016 16:11:27 +
Build duration: 21 min
CHANGE SET
Revision 7ff606de2c7bcd8d2ea2893f01390b48f8
mart added a comment.
i'm concerned existing applicatons will look broken as they risk the drawer
to not have margins and is very probablt text will arrive to the very end of
the drawer edge.
all the components are designed for the developernot to have set margins by
hand (because assumes,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128571/
---
Review request for Plasma and Marco Martin.
Bugs: 366278
http://bugs.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128571/#review97983
---
Ship it!
explanation looks good to me.. Martin?
- Marco M
broulik abandoned this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2044
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, sitter
Cc: mart, graesslin, plasma-devel, ali-mohamed, jensr
apol updated the summary for this revision.
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D2327
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasma-devel
___
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
FileDialog is very slow to load. Despite us using the platform theme is
will also load the /e
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMIcf7ea0a6adda: Let the drawer contents take the full
width (authored by apol).
REPOSITORY
rKIRIGAMI Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2327?vs=5609&id=5615
REVISIO
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I'm not sure why it was done like that, but otherwise we're forced into
some margins which look weird, e
sebas created this revision.
sebas added a reviewer: dvratil.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When enabling outputs, it's possible that a KScreen::Output's current
mode i
On Mon, Aug 1, 2016 at 12:19 PM, Eike Hein wrote:
>
> On 07/28/2016 07:11 PM, Jonathan Riddell wrote:
>> There's also the issue that if we move for one distro we'll end up
>> with accusations of favouratism and requests for moving for other
>> distros. But then maybe we do like openSUSE :)
>
> I
On Mon, Aug 1, 2016 at 2:28 PM, Jonathan Riddell wrote:
> We're testing Mumble for meetings today. It's an app you need to
> install then set up then connect to server weegie.edinburghlinux.co.uk
> then you can talk to me or whoever is around
>
> It's reliable for audio when I've used it but the
sebas added a comment.
Here's the backtrace I get without this patch. The crash actually happens
inside the debug message, but when it happens, it also means that the mode id
we try to pass into xcb_randr_set_crtc_config is invalid (most likely 0)
with disabled output:
kscreen-docto
sebas updated this revision to Diff 5621.
sebas added a comment.
- make mode id fallback faster
REPOSITORY
rLIBKSCREEN KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2330?vs=5620&id=5621
BRANCH
sebas/modefallback
REVISION DETAIL
https://phabricator.kde.org/D2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128571/#review97990
---
Ship it!
Good investigation!
- Martin Gräßlin
On Aug. 1
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2328
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel
graesslin added inline comments.
INLINE COMMENTS
> xrandrconfig.cpp:517-520
> +int modeId = kscreenOutput->currentModeId().toInt();
> +if (!kscreenOutput->currentMode()) {
> +modeId = kscreenOutput->preferredModeId().toInt();
> +}
it looks strange to me that you first access
56 matches
Mail list logo
