davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in shutdowndlg.cpp:182
> Detect when setScreen(QScreen*) is done and then update the geometry based on
> that screen.
setSecreen will be called when the QWindow geometry changes from code inside
QWindow.
So you don't want to do a setGeometry() from inside that - especially if you
also have the case of overlapping screens.
setScreen manually is only useful if you want to use initial screen data before
your first show/setGeometry.
Otherwise calling it manually will get you in a messy state.
Either call reposition(QScreen*) from adoptScreen instead of setScreen (but
leave this connect)
or get rid of the connect and make this an explicit method called from
adoptScreen.
> shutdowndlg.cpp:194
> + );
> + connect(screen(), &QScreen::geometryChanged, this, [this] {
> + rootContext()->setContextProperty(QStringLiteral("screenGeometry"),
> this->screen()->geometry());
you don't have a disconnect on this in screenChanged
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2264
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
