Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94325 --- You really don't want to create more Canvas elements than nec

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94326 --- a canvas element for a triangle seems a little bit too much f

[Differential] [Closed] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3a401739e2c8: [Applet / Wallpaper Configuration] Load config page with initial cfg… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabr

[Differential] [Closed] D1221: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7656fa02e680: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D1028: RFC: Remove custom RubberBand painter

broulik abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1028 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, hein Cc: plasma-devel, sebas

[Differential] [Accepted] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rLIBKSYSGUARD KSysguard Library REVISION DETAIL https://phabricator.kde.org/D1085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Updated] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

broulik updated the summary for this revision. REPOSITORY rLIBKSYSGUARD KSysguard Library REVISION DETAIL https://phabricator.kde.org/D1085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas __

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 06 Apr 2016 07:18:35 + Build duration: 12 min CHANGE SET Revision 7656fa02e680bbc85dd03635149cc6643f5

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 7:03 vorm., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? T

[Differential] [Updated] D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*

graesslin added a dependent revision: D1329: [server] Support sub-surfaces from PointerInterface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1319 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasm

[Differential] [Request, 195 lines] D1329: [server] Support sub-surfaces from PointerInterface

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The idea behind this change is to make the existance of sub-surfaces an implementation detail for point

[Differential] [Updated] D1329: [server] Support sub-surfaces from PointerInterface

graesslin added a dependency: D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSYSGUARD4b14421cf723: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to… (authored by broulik). REPOSITORY rLIBKSYSGUARD KSysguard Library CHANGES SINCE LAST UPDATE https:

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

> On April 5, 2016, 5:43 p.m., David Rosca wrote: > > src/pulseaudio.h, line 64 > > > > > > I think this change (adding AbstractStreamModel) is not needed. > > Yoann Laissus wrote: > I had some issues with rb

Re: Review Request 127585: integrate pasma-pa kcm docs properly into helpsystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127585/#review94329 --- Fix it, then Ship it! Thanks src/kcm/module.cpp (line 52

Review Request 127588: SortFilterModel: Invalidate filter when changing filter callback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127588/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Commented On] D1296: AppletConfiguration: Respect button visibility preference of KCModules

drosca added inline comments. INLINE COMMENTS desktoppackage/contents/configuration/AppletConfiguration.qml:338 The enum value is defined in KDeclarative::ConfigModule and is only accessible from the QML KCM itself. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabric

Re: Review Request 127588: SortFilterModel: Invalidate filter when changing filter callback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127588/#review94331 --- Ship it! Ship It! - Kai Uwe Broulik On April 6, 2016, 8

Re: Review Request 127588: SortFilterModel: Invalidate filter when changing filter callback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127588/ --- (Updated April 6, 2016, 9:16 a.m.) Status -- This change has been ma

bbcukmet feature in bugfix branch?

Not that I know what an ion is but I am pretty sure [1] is a feature and not a bug fix, yet it is in the bug fix branch for 5.6 :-( [1] https://phabricator.kde.org/rPLASMAWORKSPACEcf5cca38788407f80d07080fb72e55308a02f0f1 ___ Plasma-devel mailing list Pl

[Differential] [Accepted] D1329: [server] Support sub-surfaces from PointerInterface

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH pointer-sub-surface REVISION DETAIL https://phabricator.kde.org/D1329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH surface-at REVISION DETAIL https://phabricator.kde.org/D1319 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1296: AppletConfiguration: Respect button visibility preference of KCModules

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1296 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote: > > src/pulseaudio.h, line 64 > > > > > > I think this change (adding AbstractStreamModel) is not needed. > > Yoann Laissus wrote: > I had some issues wi

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

> On April 5, 2016, 5:43 p.m., David Rosca wrote: > > src/pulseaudio.h, line 64 > > > > > > I think this change (adding AbstractStreamModel) is not needed. > > Yoann Laissus wrote: > I had some issues with rb

[Differential] [Request, 336 lines] D1330: [server] Pass keyboard focus to child surface on pointer click

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY [server] Split KeyboardInterface::Private into dedicated header [server] Pass keyboard focus to chil

[Differential] [Updated] D1329: [server] Support sub-surfaces from PointerInterface

graesslin added a dependent revision: D1330: [server] Pass keyboard focus to child surface on pointer click. REPOSITORY rKWAYLAND KWayland BRANCH pointer-sub-surface REVISION DETAIL https://phabricator.kde.org/D1329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Updated] D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*

graesslin added a dependent revision: D1330: [server] Pass keyboard focus to child surface on pointer click. REPOSITORY rKWAYLAND KWayland BRANCH surface-at REVISION DETAIL https://phabricator.kde.org/D1319 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D1330: [server] Pass keyboard focus to child surface on pointer click

graesslin added dependencies: D1329: [server] Support sub-surfaces from PointerInterface, D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1330 EMAIL PREFERENCES https

[Differential] [Closed] D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDa2a3ceb52da5: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) ->… (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org

Re: bbcukmet feature in bugfix branch?

Hi Harald, Am Mittwoch, 6. April 2016, 11:23:04 CEST schrieb Harald Sitter: > Not that I know what an ion is but I am pretty sure [1] is a feature > and not a bug fix, yet it is in the bug fix branch for 5.6 :-( thanks for speaking out when seeing possible rule breaking, very appreciated. This o

[Differential] [Closed] D1329: [server] Support sub-surfaces from PointerInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND14653e631e34: [server] Support sub-surfaces from PointerInterface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1329?vs=3155&id=

[kio-extras] [Bug 361454] New: fish: No information on disk space

https://bugs.kde.org/show_bug.cgi?id=361454 Bug ID: 361454 Summary: fish: No information on disk space Product: kio-extras Version: unspecified Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity:

[Differential] [Closed] D1296: AppletConfiguration: Respect button visibility preference of KCModules

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPa033fcda01cb: AppletConfiguration: Respect button visibility preference of KCModules (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabr

[Differential] [Accepted] D1330: [server] Pass keyboard focus to child surface on pointer click

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH keyboard-sub-surface-arc REVISION DETAIL https://phabricator.kde.org/D1330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Updated, 4 lines] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

colomar retitled this revision from "Fix search keyword "animation speed" pointing to the wrong KCM" to "Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM". colomar updated the summary for this revision. colomar updated this revision to Diff 3163.

[Differential] [Accepted] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1326 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: colomar, Pla

[Differential] [Request, 89 lines] D1331: Provide the platform() -> AbstractBackend* in KWin::Application

graesslin created this revision. graesslin added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is the first change in a refactoring series. The aim is to: - rename AbstractBackend to P

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ --- (Updated avr. 6, 2016, 5:24 après-midi) Review request for Plasma. Chan

[Differential] [Accepted] D1331: Provide the platform() -> AbstractBackend* in KWin::Application

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-application REVISION DETAIL https://phabricator.kde.org/D1331 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, Plasma

[Differential] [Closed] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd847ddf84189: Fix search keywords between Desktop Effects KCM and Compositing KCM (authored by colomar). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1326?vs=3163&i

Re: RFC: Enabling users to report issues with Plasma widgets

Hi, I agree with Friedrich and Kainz.a, but what user ? I feel what Friedrich speak a basic user and Kainz.a a advanced user. All process the bug info report is for advanced user; it happen. I am enduser and I have KDE for everyone. Hazlo simple. Cheers. El mar., 5 de abril de 2016 10:59 PM, Th

Re: Review Request 121903: Clean up how we deal with debug input

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903/ --- (Updated April 7, 2016, 12:55 a.m.) Status -- This change has been d

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

[Differential] [Request, 1 line] D1338: Fix null values in currency conversion

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We would check if the string (unit1) matched any known units (s) using a case insensitve comp

[Differential] [Closed] D1330: [server] Pass keyboard focus to child surface on pointer click

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND700d7fe1997e: [server] Split PoointerInterface::Private into dedicated header (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1330?vs=3158&id=3181#toc REPOSITORY

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94351 --- Ship it! Ship It! - David Rosca On April 6, 2016, 5:24

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote: > > You really don't want to create more Canvas elements than neccessary, they > > all have their own FBO. > > > > Can't you make the grid canvas draw the triangles, too? Or make a simple > > item with a triangle shaped QSGGeometryNode? >

[Differential] [Closed] D1331: Provide the platform() -> AbstractBackend* in KWin::Application

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7996d954c526: Provide the platform() -> AbstractBackend* in KWin::Application (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1331?vs=3165&id=3182#toc REPOSITORY rKWI

[Differential] [Commented On] D1292: Add mute microphone global shortcut

drosca added inline comments. INLINE COMMENTS applet/contents/ui/main.qml:91 Yeah, that looks better. Will change it in next commit. src/qml/volumeosd.cpp:42 It's generated from XML, so it does not introspect. But indeed should be constructed just once. REPOSITORY rPLASMAPA Plasma Audio