Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-19 Thread Kai Uwe Broulik
> On Jan. 19, 2016, 11:27 nachm., Luca Beltrame wrote: > > This broke the task manager: > > > > file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/main.qml:223:5: > > Type ToolTipDelegate unavailable > > file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/conten

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-19 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review91354 --- This broke the task manager: file:///usr/share/plasma/plasmo

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 19, 2016, 9:47 p.m.) Status -- This change has been ma

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review91207 --- Ship it! Ship It! - Eike Hein On Jan. 7, 2016, 9:05 p.m

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review91201 --- Ping - Kai Uwe Broulik On Jan. 7, 2016, 9:05 nachm., Kai U

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 7, 2016, 9:05 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90691 --- +1 i think it's pure sexy now :D - Marco Martin On Jan. 6,

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 6, 2016, 12:11 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-06 Thread Marco Martin
> On Jan. 6, 2016, 9:08 a.m., Heiko Tietze wrote: > > The blurred shadow looks wrong. As reference I would use the HIG about > > images https://techbase.kde.org/Projects/Usability/HIG/Layout/Image "Use a > > semi-transparent background behind the (was: caption text) controls to > > preserve co

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90689 --- I like the idea a lot, the detail i don't like much is the gra

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-06 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90685 --- The blurred shadow looks wrong. As reference I would use the H

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 5, 2016, 11:40 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 5, 2016, 11:21 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- (Updated Jan. 5, 2016, 11:15 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90674 --- I agree with the album art suggestion - or we could build on y

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Thomas Pfeiffer
> On Jan. 5, 2016, 9:28 p.m., Martin Klapetek wrote: > > One idea I was thinking about for this case - why not replace > > the audio player window thumbnail with the album cover art? > > > > The window of the player is not really useful in the thumbnail; > > it's mostly just a window with some l

Re: Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90672 --- One idea I was thinking about for this case - why not replace

Review Request 126647: [Task Manager] Provide media controls in tooltips

2016-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/ --- Review request for Plasma, KDE Usability and Eike Hein. Bugs: 352126