-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 11:15 nachm.)
Review request for Plasma, KDE Usability and Eike Hein.
Changes
-------
* Show album art, if any
* Improve layout, show track title and artist
* While at it, I also simplified the close button to be larger
* Also split the mouse area for the tooltip delegate into a separate file
* I also changed the dialog sizing code a bit while keeping sizes as they were
Bugs: 352126
https://bugs.kde.org/show_bug.cgi?id=352126
Repository: plasma-desktop
Description (updated)
-------
This adds media player controls to the tooltip of a media player, using the
already existing mpris dataengine this was pretty straightforward to implement.
When album art is available, no window thumbnails will be shown, instead the
album art. There will be a close button on the album art closing the first
window. Multiple windows for a player is uncommon and you can still access them
all by clicking the task manager entry.
Interestingly enough, Amarok does not expose its album art through MPris. Also,
if it wouldn't crash whilst doing so, you could control Amarok when it's main
window is closed if you have a launcher pinned to your task manager, basically
rendering its tray icon obsolete.
Diffs (updated)
-----
applets/taskmanager/package/contents/ui/Task.qml 2a88886
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62
applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126647/diff/
Testing
-------
Works with VLC and Audacious, does not work with Dragon as the player announces
itself as "dragonplayer" while its Desktop file says "dragon"
File Attachments (updated)
----------------
VLC with album art
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/3058dacb-1dfd-464d-a1ec-be90bc9e58a8__mpristaskmanagerreview1.png
Amarok without album art
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/6799d6f6-d505-4f56-9531-3013a3e34ae6__mpristaskmanagerreview2.png
Thanks,
Kai Uwe Broulik
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
