Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Kai Uwe Broulik
> On Dez. 28, 2015, 2:02 nachm., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. > > Heiko Tietze wrote: > I agree with the idea to avoid changing UI structure. However, to disable > isn't good for tabs. > >

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- (Updated Dez. 28, 2015, 8:56 nachm.) Status -- This change has been

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Eike Hein
> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. > > Heiko Tietze wrote: > I agree with the idea to avoid changing UI structure. However, to disable > isn't good for tabs. > >

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Heiko Tietze
> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. I agree with the idea to avoid changing UI structure. However, to disable isn't good for tabs. Here is what we wrote in the tabcontrol H

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread David Edmundson
> On Dec. 28, 2015, 2:04 p.m., David Edmundson wrote: > > applets/kickoff/package/contents/ui/FullRepresentation.qml, line 65 > > > > > > why? > > > > if were we to do this it should only do it if that ta

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90209 --- I don't really like how this is going to decreaes the load tim

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90210 --- Maybe show it as disabled at least? It's weird that UI structu

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- (Updated Dez. 28, 2015, 2:01 nachm.) Review request for Plasma, KDE Usabi

Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- Review request for Plasma, KDE Usability and Eike Hein. Repository: plasm