> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. > > Heiko Tietze wrote: > I agree with the idea to avoid changing UI structure. However, to disable > isn't good for tabs. > > Here is what we wrote in the tabcontrol HIG: > * Do not disable a tab when it doesn't apply to the current context; > disable the controls on the page. > * Make tabs closable if their pages contain documents, but not if their > pages contain application's user interface. > > -> I recommend to neither hide nor deaktivate the tab.
I generally agree with Heiko here: Major UI elements appearing/disappearing conditionally is usually bad because it's jarring and missing an opportunity to teach the user what functionality they can expect to become available if they do certain things. It's a bit different here because the pitch is that the user can disable history tracking and then gets stuck with a guaranteed-to-be-empty tab they might want to get rid of. But I suggest this relationship then needs to be explicit: Disabling history tracking hides the tab. Not to make it magic based on the count in the model. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90210 ----------------------------------------------------------- On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126544/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 2:01 p.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Bugs: 347633 > https://bugs.kde.org/show_bug.cgi?id=347633 > > > Repository: plasma-desktop > > > Description > ------- > > This hides the "History" tab if it is empty. > > This can permanently happen if you use disable tracking in activity settings > or administrative means. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf > applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 > applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 > > Diff: https://git.reviewboard.kde.org/r/126544/diff/ > > > Testing > ------- > > Button comes and goes as I add and remove history entries. > > When I clear the history, it switches to the Favorites view so you don't end > up with a broken view. > > It doesn't seem to track application launches through Kickoff but I think > this is unrelated. > > > File Attachments > ---------------- > > No history tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
