Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Thomas Lübking
> On March 12, 2014, 2:51 p.m., Thomas Lübking wrote: > > Ship It! > > Thomas Lübking wrote: > Do you think the Qt API doc would require a BIG FAT WARNING on this? > > Martin Gräßlin wrote: > wouldn't hurt to have that better. Doesn't need to be a big fat warning, > but at least it sho

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Martin Gräßlin
> On March 12, 2014, 3:51 p.m., Thomas Lübking wrote: > > Ship It! > > Thomas Lübking wrote: > Do you think the Qt API doc would require a BIG FAT WARNING on this? wouldn't hurt to have that better. Doesn't need to be a big fat warning, but at least it should be mentioned that it doesn't g

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- (Updated March 12, 2014, 3:35 p.m.) Status -- This change has been m

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52785 --- This review has been submitted with commit b3ca2443d6bbe206f5

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Thomas Lübking
> On March 12, 2014, 2:51 p.m., Thomas Lübking wrote: > > Ship It! Do you think the Qt API doc would require a BIG FAT WARNING on this? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52764 --- Ship it! Ship It! - Thomas Lübking On March 12, 2014, 6:43

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- (Updated March 12, 2014, 7:43 a.m.) Review request for kwin, Plasma and S

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52692 --- Duely noted. Good catch, as well. - Sebastian Kügler On Mar

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52665 --- tried passing "this" as context? QMetaObject::Connection QObj

Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- Review request for kwin, Plasma and Sebastian Kügler. Repository: kde-wor