> On March 12, 2014, 2:51 p.m., Thomas Lübking wrote: > > Ship It!
Do you think the Qt API doc would require a BIG FAT WARNING on this? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52764 ----------------------------------------------------------- On March 12, 2014, 6:43 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116712/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:43 a.m.) > > > Review request for kwin, Plasma and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > [kwin] Disconnect lambda connection on destroy of slide effect > > Lambda connections are tricky: they do not get automatically > disconnected when the captured [this] gets destroyed, but they get > disconnected when the sender object gets destroyed. > > Thus the slide effect was crashing if it got disabled and a window > got deleted, because the connection was still present and tried to > access the destroyed this pointer. > > To circumvent we need to store the QMetaObject::Connection and > disconnect when the SlideEffect gets destroyed. To not clutter the > private variables it's using another lambda. > > -- > Plasma and sebas are only added to highlight this GOTCHA! > > > Diffs > ----- > > kwin/effects/slide/slide.cpp e6a8d588fe6ef7c7cb2981b0d49bf2c670753e2d > > Diff: https://git.reviewboard.kde.org/r/116712/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
