Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/ --- (Updated Jan. 19, 2016, 9:29 a.m.) Status -- This change has been ma

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread Marco Martin
> On Jan. 19, 2016, 8:52 a.m., Marco Martin wrote: > > I'm fine with the change, but... wasn't iconitem supposed to get a property > > for not using the svg? > > David Rosca wrote: > No idea, but I don't think the Plasma components should be used in > QtQuickControls windows, exactly becau

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread David Rosca
> On Jan. 19, 2016, 8:52 a.m., Marco Martin wrote: > > I'm fine with the change, but... wasn't iconitem supposed to get a property > > for not using the svg? No idea, but I don't think the Plasma components should be used in QtQuickControls windows, exactly because of this issue - using Plasma

Re: Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/#review91315 --- Ship it! I'm fine with the change, but... wasn't iconitem