> On Jan. 19, 2016, 8:52 a.m., Marco Martin wrote: > > I'm fine with the change, but... wasn't iconitem supposed to get a property > > for not using the svg? > > David Rosca wrote: > No idea, but I don't think the Plasma components should be used in > QtQuickControls windows, exactly because of this issue - using Plasma style.
yeah, in this case the patch makes sense regardless - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/#review91315 ----------------------------------------------------------- On Jan. 18, 2016, 6:47 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126800/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 6:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > PlasmaCore.IconItem uses plasma color scheme, which is not what we want in > applet config. > > > Diffs > ----- > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fc87c6f > > Diff: https://git.reviewboard.kde.org/r/126800/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel