Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119154/ --- (Updated July 7, 2014, 6:20 p.m.) Status -- This change has been mar

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Aleix Pol Gonzalez
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119154/#review61829 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 7, 2014, 11

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Aleix Pol Gonzalez
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Aleix Pol Gonzalez
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > > > > > We've used configure variables to do that. Doesn't it apply here? > > Eike Hein wrote: > Can you ela

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 9 > > > > > > Why is that change? does it have gui afterall? Well, yeah? :) It's a GUI app (multi-step wizard dialog) ..

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119154/#review61805 --- knetattach/CMakeLists.txt

Re: Review Request 119154: Install knetattach regularly instead of into libexec

2014-07-07 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119154/ --- (Updated July 7, 2014, 11:33 a.m.) Review request for Plasma and David Fa