> On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 9 > > <https://git.reviewboard.kde.org/r/119154/diff/1/?file=288163#file288163line9> > > > > Why is that change? does it have gui afterall?
Well, yeah? :) It's a GUI app (multi-step wizard dialog) ... > On July 7, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: > > knetattach/CMakeLists.txt, line 13 > > <https://git.reviewboard.kde.org/r/119154/diff/1/?file=288163#file288163line13> > > > > We've used configure variables to do that. Doesn't it apply here? Can you elaborate? - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119154/#review61805 ----------------------------------------------------------- On July 7, 2014, 11:33 a.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119154/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 11:33 a.m.) > > > Review request for Plasma and David Faure. > > > Bugs: 337167 > https://bugs.kde.org/show_bug.cgi?id=337167 > > > Repository: plasma-desktop > > > Description > ------- > > We currently have multiple launch locations for KNetAttach that are broken > because the .desktop execution machinery lost the ability to execute things > from libexec (probably due to KStandardDirs -> QStandardPaths, > KStandardDirs::findExecutable used to work differently). Namely the regular > menu entry, and the "Add Network Folder" virtual item generated by the > remote:/ kioslave (showing as "Network" in the Dolphin sidebar). > > This patch changes the build system to install knetattach regularly, to match > that we apparently want to be able to launch it regularly. > > See https://bugs.kde.org/show_bug.cgi?id=337117 for ticket. > > > Diffs > ----- > > knetattach/CMakeLists.txt e3853ec > > Diff: https://git.reviewboard.kde.org/r/119154/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
