D5249: [RFC] New effect plugin - projector (keystone) correction

2017-04-11 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > nalvarez wrote in projector.cpp:101-126 > I think it would be acceptable if the cursor is drawn just like it is now, on > its own layer, even if drawing it without the transformation would make it > slightly deformed visually. > > You just hav

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-04-11 Thread Nicolás Alvarez
nalvarez added inline comments. INLINE COMMENTS > nowicki wrote in projector.cpp:101-126 > The reason for taking over cursor drawing is that when transformation is > applied the pointer pixmap doesn't match the point where the cursor actually > hits the windows below it. Since there is no way t

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-04-06 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5249#100193, @nowicki wrote: > The idea that I have in mind ATM is to redirect drawing the whole screen into a FBO and then draw it screen by screen applying transformation where necessary. This should be fairly easy thanks to th

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-04-06 Thread Krzysztof Nowicki
nowicki added a comment. The idea that I have in mind ATM is to redirect drawing the whole screen into a FBO and then draw it screen by screen applying transformation where necessary. This should be fairly easy thanks to the render target stack in KWin. Doing it this way would get rid of the

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-03-29 Thread Thomas Lübking
luebking added a comment. ftr, not sure about --transform correctnes, but metamodes ViewportIn/ViewportOut work flawless on at least the nvidia blob. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5249 To: nowicki, #plasma, graesslin Cc: luebking, kwin, plasma-devel,

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-03-29 Thread Krzysztof Nowicki
nowicki added a comment. In https://phabricator.kde.org/D5249#98921, @graesslin wrote: > I think the effect system is the wrong place for it - at least if we want to add it to KWin directly. The transformation should be done directly in the Scene. I have done it this way initiall

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-03-29 Thread Martin Gräßlin
graesslin added a comment. I think the effect system is the wrong place for it - at least if we want to add it to KWin directly. The transformation should be done directly in the Scene. INLINE COMMENTS > projector.cpp:101-126 > +if (m_cursorTexture && m_cursorVisible) { > +QPoin

D5249: [RFC] New effect plugin - projector (keystone) correction

2017-03-29 Thread Krzysztof Nowicki
nowicki created this revision. nowicki added a project: KWin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: KWin. REVISION SUMMARY I have been using my laptop to display content on a projector and sometimes I have encountered some