[Differential] [Accepted] D3945: Remove unused class

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. This looks like some code to generate user avatars..? But anyway looks good. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabr

[Differential] [Accepted] D3944: Fix yet another KPluginMetaData::value porting mistake on stringlists

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3946: And fix yet another KPLuginMetaData::value breakage with QStringLists

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3946 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3803: Add support for on-screen-message to kwineffects

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH on-screen-message-effects REVISION DETAIL https://phabricator.kde.org/D3803 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Closed] D3789: [declarativeimports] Use QtRendering on phone devices

This revision was automatically updated to reflect the committed changes. Closed by commit R242:324232a745a8: [declarativeimports] Use QtRendering on phone devices (authored by bshah). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3789?vs=9287&id=93

[Differential] [Commented On] D3789: [declarativeimports] Use QtRendering on phone devices

bshah added a comment. I am not sure if QtQuickControls can be used in org.kde.plasma.components? no other component is using it? REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3789 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Request, 18 lines] D3789: [declarativeimports] Use QtRendering on phone devices

bshah created this revision. bshah added reviewers: Plasma, mart. bshah added a task: T4947: [bullhead] Fix issue with QtQuick Text items rendering. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.

[Differential] [Commented On] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

bshah added a comment. +1 REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3701: cmake: Raise KF5 requirement to 5.29.0

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3701 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f906e21f3dac: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version (authored by bshah). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3686?vs=9036&id=905

[Differential] [Accepted] D3575: [autotests/integration] Use socketpair for Wayland connection

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH autotests-socketpair REVISION DETAIL https://phabricator.kde.org/D3575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

bshah added inline comments. INLINE COMMENTS > bshah wrote in hwcomposer_backend.cpp:321 > I didn't get you on how it is not forward compatible? Oh actually nevermind. I got wrong line in email so was confused.. so idea here is you'll need to check 1.4 and 1.5 as there is also 2.0 and it is not

[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

bshah added inline comments. INLINE COMMENTS > graesslin wrote in hwcomposer_backend.cpp:321 > hmm that doesn' t look really forward compatible. Can we have something like > > #if VERSION > 1_4 > > ? I didn't get you on how it is not forward compatible? REPOSITORY R108 KWin REVISION DETA

[Differential] [Request, 20 lines] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

bshah created this revision. bshah added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY HWcomposer version 1.4 introduced setPowerMode, which replaces the blank(). This adds support for

[Differential] [Changed Subscribers] D3651: Add utility to send broadcast notifications

bshah added inline comments. INLINE COMMENTS > main.cpp:79 > +if (!uids.isEmpty()) { > +properties.insert(QStringLiteral("uids"), uids); > +} I wonder if it can take usernames instead of uids? It is slightly easier to remember usernames then uids REPOSITORY R126 K

[Differential] [Changed Subscribers] D3531: Drop kioslave folder, will be in KIO 5.30

bshah added inline comments. INLINE COMMENTS > CMakeLists.txt:8 > set(QT_MIN_VERSION "5.6.1") > -set(KF5_MIN_VERSION "5.26.0") > +set(KF5_MIN_VERSION "5.30.0") > set(INSTALL_SDDM_THEME TRUE) You can't do this, framework version is bumped by release script automatically, so when you push this

[Differential] [Accepted] D3447: Remove epoxy/egl.h from kwinglutils_func.h

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-egl-kwinglutils_funcs REVISION DETAIL https://phabricator.kde.org/D3447 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Requested Changes To] D3406: temporary visible panels out of availableScreenRect

bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added a comment. This revision now requires changes to proceed. Diff sounds messed up? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3406 EMAIL PREFERENCES https:/

[Differential] [Accepted] D3335: Move resolving glxSwapIntervalMesa into platform plugin

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH glx-resolve-in-platform REVISION DETAIL https://phabricator.kde.org/D3335 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. sounds sane. REPOSITORY rKWIN KWin BRANCH glide-no-atom REVISION DETAIL https://phabricator.kde.org/D3296 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Accepted] D3329: Move glx version check functionality to platform plugin

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. With @broulik 's comment addressed.. +1 REPOSITORY rKWIN KWin BRANCH glx-version-check-platform REVISION DETAIL https://phabricator.kde.org/D3329 EMAIL

[Differential] [Accepted] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Assuming this doesn't break any other 3rd party effects(?) REPOSITORY rKWIN KWin BRANCH effectshandler-drop-delete-root-property REVISION DETAIL https://

[Differential] [Accepted] D3289: Include to fix build on FreeBSD

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D3289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3150: [server] Fix crash on updating focused keyboard surface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH selection-ddi-keyboard-focus REVISION DETAIL https://phabricator.kde.org/D3150 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Accepted] D3149: [server] Fix possible crash on creation of DataDevice

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH selection-ddi-creation REVISION DETAIL https://phabricator.kde.org/D3149 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D3148: [server] Ensure we have a DataSource on the DataDevice in setSelection

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH set-selection-source REVISION DETAIL https://phabricator.kde.org/D3148 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Closed] D3155: Call GLRenderTarget::setVirtualScreenGeometry prior to self test

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf792c82528d4: Call GLRenderTarget::setVirtualScreenGeometry prior to self test (authored by graesslin, committed by bshah). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Accepted] D3155: Call GLRenderTarget::setVirtualScreenGeometry prior to self test

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-viewport-after-self-test REVISION DETAIL https://phabricator.kde.org/D3155 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah

[Differential] [Closed] D3084: [shell] Support autohide panel on wayland

This revision was automatically updated to reflect the committed changes. bshah marked an inline comment as done. Closed by commit rPLASMAWORKSPACEd0df5725d9ca: [shell] Support autohide panel on wayland (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3084: [shell] Support autohide panel on wayland

bshah marked an inline comment as done. bshah added inline comments. INLINE COMMENTS > graesslin wrote in panelview.cpp:651 > do we also need to request the slide for the panel on WAyland? I don't think so.. because from my testing panel sliding seems to work normally. REPOSITORY rPLASMAWORKS

[Differential] [Accepted] D3080: Panel auto hide support for Wayland panels

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good REPOSITORY rKWIN KWin BRANCH panel-autohide-wayland REVISION DETAIL https://phabricator.kde.org/D3080 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

bshah updated this revision to Diff 7460. bshah updated the test plan for this revision. bshah added a comment. edit message for real REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3084?vs=7459&id=7460 BRANCH panel-autohide REVISION

[Differential] [Updated, 7 lines] D3084: [shell] Support autohide panel on wayland

bshah updated this revision to Diff 7459. bshah added a comment. update commit message REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3084?vs=7458&id=7459 BRANCH panel-autohide REVISION DETAIL https://phabricator.kde.org/D3084 AF

[Differential] [Request, 7 lines] D3084: [shell] Support autohide panel on wayland

bshah created this revision. bshah added reviewers: Plasma, graesslin. bshah added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This m

[Differential] [Updated] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

bshah added a dependent revision: D3084: [shell] Support autohide panel on wayland. REPOSITORY rKWAYLAND KWayland BRANCH panel-auto-hide REVISION DETAIL https://phabricator.kde.org/D3007 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, seba

[Differential] [Request, 54 lines] D3022: [wayland] Support for hideClient in ShellClient

bshah created this revision. bshah added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This implements the hideClient for ShellClient which was previously not implmented. Also autotest

[Differential] [Closed] D3022: [wayland] Support for hideClient in ShellClient

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7843974a8a5b: [wayland] Support for hideClient in ShellClient (authored by bshah). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3022?vs=7306&id=7307 REVISION DETAI

[Differential] [Accepted] D3020: Set window state on QEvent::PlatformSurface on Qt 5.5+.

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3020 EMAIL PREFERENCES https://phabricator.

[Differential] [Updated] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55717, @bshah wrote: > In https://phabricator.kde.org/D2975#55709, @mart wrote: > > > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues

[Differential] [Closed] D3008: [shell] Don't resize or reposition panel if we are doing restore

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc63baa3ae354: [shell] Don't resize or reposition panel if we are doing restore (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Updated, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

bshah updated this revision to Diff 7271. bshah added a comment. fix REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3008?vs=7270&id=7271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3008 AFFECTED FILES shell/panel

[Differential] [Updated, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

bshah updated this revision to Diff 7270. bshah added a comment. rename var REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3008?vs=7269&id=7270 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3008 AFFECTED FILES shel

[Differential] [Request, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

bshah created this revision. bshah added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PanelView::restore sets various properties including length, thickness, which would result in panel resize

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55709, @mart wrote: > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues, we reconsider this one again? Okay looking onto it. REPO

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55706, @mart wrote: > adding an event compression timer (that by the way, it's a perfectly fine, many times even desired thing) and solving the useless restore() calls at startup are two ortogonal pissues. Double restore

[Differential] [Accepted] D3001: Avoid calling resize() with our current size

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. yep.. no more positionPanel call.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3001 EMAIL PREFERENCES https

[Differential] [Accepted] D2997: [server] Cancel previous selection from SeatInterface::setSelection

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-cancel-from-set-selection REVISION DETAIL https://phabricator.kde.org/D2997 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: grae

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55224, @mart wrote: > can it use QQmlParserStatus instead? Idea of using QQmlParserStatus is fine and it might save some cycles at start but problem remains same when I move panel around.. I don't think QQmlParser status

[Differential] [Request, 18 lines] D2975: [shell] Event compress resizePanel

bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At startup and as well when one moves panel, resizePanel is called multiple times. For instance, at startup res

[Differential] [Closed] D2970: [shell] Fix crash when moving panel between two monitors

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5cfb957c8799: [shell] Fix crash when moving panel between two monitors (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

[Differential] [Request, 4 lines] D2970: [shell] Fix crash when moving panel between two monitors

bshah created this revision. bshah added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When moving panel between two screens there is time when panel is on edge of screen and screenToFollow is

[Differential] [Closed] D2960: [shell] Fix non-interactive panelview on non-primary screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE9c94cd136006: [shell] Fix non-interactive panelview on non-primary screen (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Request, 4 lines] D2960: [shell] Fix non-interactive panelview on non-primary screen

bshah created this revision. bshah added reviewers: Plasma, mart, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If we don't pass the current screen to QCursor::pos, it will return position relative to primar

[Differential] [Accepted] D2882: Don't load QPT in kcminit

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH arcpatch-D2835 REVISION DETAIL https://phabricator.kde.org/D2882 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Accepted] D2837: Cleanup test case properly

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2837 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2775: Emit brightnessSupportQueried with the proper value

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2775 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pl

[Differential] [Accepted] D2773: [wayland] Fix release of TabBox on Wayland

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH tabbox-handle-release REVISION DETAIL https://phabricator.kde.org/D2773 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, #plas

[Differential] [Accepted] D2768: Remove not-wanted modifiers prior to evaluating global shortcuts

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shortcuts-consumed-modifiers REVISION DETAIL https://phabricator.kde.org/D2768 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah

[Differential] [Accepted] D2751: Fix interaction between decoration and fullscreen ShellClient

bshah accepted this revision. REPOSITORY rKWIN KWin BRANCH fullscreen-no-deco REVISION DETAIL https://phabricator.kde.org/D2751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas, bshah, #kwin Cc: plasma-devel, kwin,

[Differential] [Accepted] D2758: Fix updating layer when setting a ShellClient to fullscreen

bshah accepted this revision. REPOSITORY rKWIN KWin BRANCH shell-client-fullscreen-update-layer REVISION DETAIL https://phabricator.kde.org/D2758 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas, bshah, #kwin Cc: pl

[Differential] [Updated] D2751: Fix interaction between decoration and fullscreen ShellClient

bshah added a comment. mmm.. still konsole is not fullscreen. :-\ panel still visible. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, bshah

[Differential] [Accepted] D2745: Don't bind ShellClient::acceptsFocus to whether the window is shown

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH minimize-accepts-focus REVISION DETAIL https://phabricator.kde.org/D2745 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, #pla

[Differential] [Accepted] D2620: DebugConsole window does not take keyboard input

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH debug-console-no-keyboard-input REVISION DETAIL https://phabricator.kde.org/D2620 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D2727: don't list "NoDisplay" panels

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/nohidden REVISION DETAIL https://phabricator.kde.org/D2727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Accepted] D2661: Set componentDisplayName for global shortcuts

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2661 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #pl

[Differential] [Accepted] D2622: Support compose key in xkbcommon integration

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH compose-key-support REVISION DETAIL https://phabricator.kde.org/D2622 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D2587: Set proper component name for plasma-discover

This revision was automatically updated to reflect the committed changes. Closed by commit rDISCOVER663b245051ad: Set proper component name for plasma-discover (authored by bshah). REPOSITORY rDISCOVER Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2587?vs=629

[Differential] [Commented On] D2587: Set proper component name for plasma-discover

bshah added a comment. In https://phabricator.kde.org/D2587#48297, @apol wrote: > Are you sure it wasn't because of this? > http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8 setWindowIcon doesn't work on wayland.. See - https://blog.martin-graesslin.com/

[Differential] [Request, 2 lines] D2587: Set proper component name for plasma-discover

bshah created this revision. bshah added reviewers: Plasma, apol, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Plasma discover installs desktop file as org.kde.discover, but it instead sets its component na

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

bshah added inline comments. INLINE COMMENTS > compositing.ui:294 > + > + Allow windows to block compositing > + Even though windows is more correct term here technically, IMO it makes more sense to have it as "Allow applications to block compositing". what do you think? REPOSI

[Differential] [Accepted] D2582: [plugins/qpa] Call makeCurrent on the QOpenGLContext instead of the one in the platform context

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpa-opengl-context-make-current REVISION DETAIL https://phabricator.kde.org/D2582 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D2531: Warp the xcb pointer whenever pointer leaves an X11 surface

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Has been running it from start of day, and seems to fix the issue.. REPOSITORY rKWIN KWin BRANCH warp-x11-pointer-on-surface-leave REVISION DETAIL https://phabricator.kde.org/D2531 EM

[Differential] [Closed] D2529: Fix mistake between Lock and Leave action in lock_logout applet

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE060d5536af96: Fix mistake between Lock and Leave action in lock_logout applet (authored by ofelt, committed by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDA

[Differential] [Changed Subscribers] D2493: Set uniform icon sizes in UserManager gallery

bshah added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2493 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel

[Differential] [Changed Subscribers] D2494: Install avatar icons in subfolders

bshah added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2494 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel

[Differential] [Accepted] D2481: install new header

bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2481 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson, bshah Cc:

[Differential] [Closed] D2470: [upowerbackend] set cached brightness manually in case of led backlight

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL26a48f9dbfa8: [upowerbackend] set cached brightness manually in case of led backlight (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Updated, 21 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah updated this revision to Diff 6022. bshah marked 2 inline comments as done. bshah added a comment. make things simple REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2470?vs=6004&id=6022 BRANCH workaround-broken-backlight-driver (branched

[Differential] [Accepted] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

bshah accepted this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > org.kde.kcolorschemeeditor.desktop:28 > Terminal=false > -Categories=Qt;KDE;X-KDE-settings-looknfeel; > +NoDisplay=true > +OnlyShowIn=KDE;

[Differential] [Accepted] D2477: use RDN notiation for new desktop file

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2477 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Updated, 18 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah updated this revision to Diff 6004. bshah added a comment. - more readable variable name REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2470?vs=5998&id=6004 BRANCH workaround-broken-backlight-driver (branched from master) REVISION DETAIL

[Differential] [Accepted] D2471: Translate Qt key events through the unicode text with xkbcommon

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good.. REPOSITORY rKWIN KWin BRANCH virtualkeyboard-sym-translation REVISION DETAIL https://phabricator.kde.org/D2471 EMAIL PREFERENCES https://

[Differential] [Request, 18 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In normal backlight subsystem's drivers typical workflow is, - setBrightness gets called - it writ

[Differential] [Closed] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc04e7643699e: [platforms/hwcomposer] Reset old brightness when turning screen back on (authored by bshah). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5996

[Differential] [Updated, 14 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5996. bshah marked an inline comment as done. bshah added a comment. nitpick REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5995&id=5996 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISION

[Differential] [Updated, 14 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5995. bshah marked an inline comment as done. bshah added a comment. static-- REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5994&id=5995 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISIO

[Differential] [Updated, 16 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5994. bshah added a comment. appearantly I don't need ServiceWatcher dance REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5991&id=5994 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISION D

[Differential] [Request, 28 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah created this revision. bshah added reviewers: Plasma on Wayland, broulik, graesslin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Now powerdevil can adjust brightness using leds subsystem, how

[Differential] [Accepted] D2466: Introduce env variable KWIN_XKB_DEFAULT_KEYMAP to force default layout creation

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH xkb-layout-env-variable REVISION DETAIL https://phabricator.kde.org/D2466 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D2409: Update Color KCM

bshah accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting, colomar, andreaska,

[Differential] [Abandoned] D2409: Update Color KCM

bshah abandoned this revision. bshah added a comment. This has been submitted, I will just abandon changes.. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, andreask, #vdg, mart, #plasma, ochurlau

[Differential] [Commandeered] D2409: Update Color KCM

bshah commandeered this revision. bshah edited reviewers, added: ochurlaud; removed: bshah. This revision now requires review to proceed. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, andreask, #vdg

[Differential] [Accepted] D2409: Update Color KCM

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah C

[Differential] [Closed] D2411: Remove clone of battery monitor from plasma-phone-components

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPHONECOMPONENTSb536182f01ae: Remove clone of battery monitor from plasma-phone-components (authored by bshah). REPOSITORY rPLASMAPHONECOMPONENTS plasma-phone-components CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2412: [applets] Show battery monitor on all platforms and not just desktop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE030dc1f566f4: [applets] Show battery monitor on all platforms and not just desktop (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

[Differential] [Closed] D2419: [backlight helper] Support setting backlight through leds subclass

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL567c25786113: [backlight helper] Support setting backlight through leds subclass (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Updated, 37 lines] D2419: [backlight helper] Support setting backlight through leds subclass

bshah updated this revision to Diff 5857. bshah marked 3 inline comments as done. bshah added a comment. - use constFirst instead of first - prefer led backlights first if available - simplify QStringLiteral REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Commented On] D2419: [backlight helper] Support setting backlight through leds subclass

bshah added inline comments. INLINE COMMENTS > backlighthelper.cpp:121-124 > +if (!ledInterfaces.isEmpty()) { > +m_dirname = LED_SYSFS_PATH + ledInterfaces.first(); > return; > } Still, Due to ledInterfaces being last this won't work on Nexus 5 I fear, mostly because i

[Differential] [Request, 38 lines] D2419: [backlight helper] Support setting backlight through leds subclass

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some devices uses simple leds to provide the backlight to display, one such example is Nexus 5, which u

[Differential] [Request, 1 line] D2412: [applets] Show battery monitor on all platforms and not just desktop

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will also enable battery monitor on mobile. See also: https://phabricator.kde.org/D2411 REPOSI

  1   2   3   >