bshah added inline comments. INLINE COMMENTS
> CMakeLists.txt:8 > set(QT_MIN_VERSION "5.6.1") > -set(KF5_MIN_VERSION "5.26.0") > +set(KF5_MIN_VERSION "5.30.0") > set(INSTALL_SDDM_THEME TRUE) You can't do this, framework version is bumped by release script automatically, so when you push this there is no 5.30.0 version of KIO. Which will make it fail, you need to bump version once frameworks 5.30 is relased. REPOSITORY R120 Plasma Workspace BRANCH drop-slaves REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, davidedmundson, #plasma Cc: bshah, lbeltrame, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
