On 2015-03-04 15:58, Ilia Mirkin wrote:
On Wed, Mar 4, 2015 at 4:53 AM, Arthur Huillet
wrote:
From: Arthur Huillet
Don't look up uniform names for non-zero array elements, as this is
illegal per GL4.5.
From the discussion of GetProgramResourceIndex in the GL4.5 spec:
If
From: Arthur Huillet
Section 8.6 of the OpenGL 4.5 compatibility specification states:
"An INVALID_OPERATION error is generated by *TextureSubImage* if
the effective target of texture does not match the command, as shown in ta-
ble 8.23."
Piglit was expecting INVALID_ENUM.
Sig
From: Arthur Huillet
Hello,
there are a few things being tested by the direct_state_access* series that
don't appear correct to me.
I suggest that future tests in Piglit should have a comment that quotes the
part of the specification they are testing - this will make it easie
Hi,
On 2015-04-22 18:37, Ilia Mirkin wrote:
From the ARB_dsa spec:
An INVALID_ENUM error is generated by *TexSubImage* if
does
not match the command, as shown in table 8.subtarg.
An INVALID_OPERATION error is generated by *TextureSubImage* if the
effective target of does no
Hi,
On Thu, 23 Apr 2015 14:26:32 +0300
Martin Peres wrote:
> >>> Does the patch look OK to you?
> >> Yeah, patch looks perfectly fine. But I'd like to hear from Laura (or
> >> Martin perhaps, who reviewed a lot of these) about whether this was
> >> done on purpose or not, pending a spec fix.
>
From: Arthur Huillet
The pointer passed to CreateTextures() isn't required by the specification
to be checked for validity, and the implementation is allowed to crash (as
happens with NVIDIA's).
Remove the bogus tests.
Signed-off-by: Arthur Huillet
---
tests/spec/arb_direct_st
From: Arthur Huillet
Updated BindTextureUnit() to match the OpenGL specification:
GL_INVALID_OPERATION
is expected when the texture object doesn't exist, not GL_INVALID_ENUM.
When the texture unit doesn't exist, the specification doesn't strictly speaking
define the erro
Fix typo and indentation, specify GL spec version the quotes are from.
Thanks!
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
From: Arthur Huillet
Updated BindTextureUnit() to match the OpenGL specification:
GL_INVALID_OPERATION
is expected when the texture object doesn't exist, not GL_INVALID_ENUM.
When the texture unit doesn't exist, the specification doesn't strictly speaking
define the erro
On 2015-04-24 17:58, Arthur Huillet wrote:
Fix typo and indentation, specify GL spec version the quotes are from.
...
and I apologize for publicly shooting myself in the foot with
git-send-email. :)
--
Greetings,
A.H.
___
Piglit mailing list
On Wed, 22 Apr 2015 08:06:51 +0300
Tapani Pälli wrote:
> All other tests except invalid_enum_check pass on Nvidia
> binary driver (version 346.35),
What is failing on the NVIDIA binary driver, and can you prove that what Piglit
is testing is correct?
I believe quoting the spec in invalid_enum_
I'm not entirely following the first part, so get approval from somebody
else, but for the second part:
Reviewed-by: Arthur Huillet
(And actually even Suggested-by :p)
Thanks!
On 2015-04-29 13:46, Tapani Pälli wrote:
Check for GL_EXT_direct_state_access which was the original purpo
On 2015-11-10 2:08, Ian Romanick wrote:
On 11/09/2015 05:19 AM, Ilia Mirkin wrote:
On Thu, Sep 25, 2014 at 4:39 PM, Ian Romanick
wrote:
On 09/24/2014 09:47 AM, Ian Romanick wrote:
So, here it is. Finally.
The first two patches provide the infrastructure for generating
randomized UBO tests.
Hi Alex,
You're right on the theory, but your patch seems to have an issue (read
on).
On 2015-08-13 19:49, agoins wrote:
winsys-framework incorrectly assumed that it will always have ownership
of the
pixels in its own buffers. If using the default framebuffer (i.e., when
Piglit
is not runnin
Thanks :)
Reviewed by: Arthur Huillet
On Tue, 17 Nov 2015 11:33:31 -0800
Alex Goins wrote:
> From: agoins
>
> winsys-framework incorrectly assumed that it will always have ownership of the
> pixels in its own buffers. If using the default framebuffer (i.e., when Piglit
> is
From: Arthur Huillet
The test was passing a NULL indices pointer without an element buffer bound.
Nothing in the GL spec requires a NULL check, so drivers were free to crash
before checking the error condition that the test attempts to check. Fix this
by passing an index buffer.
Also swap
From: Arthur Huillet
The test was passing a NULL indices pointer without an element buffer bound.
Nothing in the GL spec requires a NULL check, so drivers were free to crash
before checking the error condition that the test attempts to check. Fix this
by passing an index buffer.
Also swap
Reviewed-by: Arthur Huillet
The test now passes with our change of behavior to out-of-bounds writes
(redirected to 0 instead of ignored). That change isn't present in any
currently available NVIDIA driver release.
Thanks!
On 25.08.2017 08:13, Samuel Iglesias Gonsálvez wrote:
From GLG
On Sun, 24 Dec 2017 15:41:38 -0700
Brian Paul wrote:
> + * Some drivers/GPUs may fail this test. NVIDIA, for example, appears to
> + * only store the MSAA coverage info, not the sample colors, for samples
> + * beyond the 8th sample. We may tune the way this test operates over time
> + * to be
I'm confused why the test is passing a bad enum when its purpose seems
to be to test a non-existent level.
In any case, your change looks correct to me.
Reviewed-by: Arthur Huillet
On 28.03.2018 17:15, Anthony Pesch wrote:
From: Anthony Pesch
Change expected error from INVALID_OPER
Reviewed-by: Arthur Huillet
Thanks
--
Arthur
On 28.03.2018 17:15, Anthony Pesch wrote:
From: Anthony Pesch
Change zero-sized texture queries to pass a valid depth parameter,
otherwise
they should error as per the OpenGL 4.6 Core spec:
"An INVALID_VALUE error is generated if the effe
I'm less confident than for the others but
Reviewed-by: Arthur Huillet
On 28.03.2018 17:15, Anthony Pesch wrote:
From: Anthony Pesch
Update cube map tests to complete the cube map before performing the
final
query. This final query is expected to succeed, however, querying a
cub
From: Arthur Huillet
Commit 57537d45b75218438716506594e16b91dade968f removed run_concurrent=False
from a bunch of tests, saying there was no reason for them to be marked as
such. This is wrong for at least two tests, which require a displayed window
(cannot render to an FBO). As such, when run
on NVIDIA driver is that we have a
unified backbuffer under some circumstances.
Thanks
--
Arthur
On 14.11.2018 13:41, arthur.huil...@free.fr wrote:
From: Arthur Huillet
Commit 57537d45b75218438716506594e16b91dade968f removed
run_concurrent=False
from a bunch of tests, saying there was no
are a LOT more tests that will have this problem.
-ilia
On Tue, Jan 22, 2019 at 5:40 AM Arthur Huillet
wrote:
Ping. Pixel ownership test makes it impossible for Piglit to blindly
assume that it can read back all the pixels of its backbuffer, so
tests
that don't use an FBO can't
25 matches
Mail list logo
