From: Arthur Huillet <ahuil...@nvidia.com>

Hello,

    there are a few things being tested by the direct_state_access* series that 
don't appear correct to me.
    I suggest that future tests in Piglit should have a comment that quotes the 
part of the specification they are testing - this will make it easier for 
others to review tests, or for implementors to ensure that they conform.

    I have one patch ready that fixes a Piglit test bug, there are other 
questionable expected error values in the direct_state_access* series.

    I believe there would be added value in future changes being done with spec 
language backing up every test. What do you think?

    Thanks


Arthur Huillet (1):
  DSA: fix error value for *TextureSubImage* when target doesn't match

 tests/spec/arb_direct_state_access/texture-errors.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

-- 
2.3.5
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to