Re: [Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

2018-11-22 Thread apinheiro
Hi, some weeks ago I sent a series with ubo/ssbo tests (still pending review) https://lists.freedesktop.org/archives/piglit/2018-September/025116.html All those has the name stripped. Could you try them and see if any of them triggers the NVIDIA bug you found? BR On 21/11/18 16:23, Józef Kucia

Re: [Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

2018-11-24 Thread apinheiro
On 23/11/18 19:41, Józef Kucia wrote: > On Thu, Nov 22, 2018 at 11:21 AM apinheiro wrote: >> some weeks ago I sent a series with ubo/ssbo tests (still pending review) >> >> https://lists.freedesktop.org/archives/piglit/2018-September/025116.html >> >> All those

Re: [Piglit] [PATCH] arb_enhanced_layouts: explicit-offset: add more corner cases

2018-12-17 Thread apinheiro
LGTM Reviewed-by: Alejandro Piñeiro On 16/12/18 6:15, Niklas Haas wrote: > From: Niklas Haas > > This adds a few tests: > - testing offsets that immediately follow a member whose actual size is > smaller than its actual alignment > - testing confusing interactions between explicit alignment a

Re: [Piglit] [PATCH] fbo-3d: test both POT and NPOT depths

2019-01-02 Thread apinheiro
I have a nitpick comment below. You can ignore it in any case: Reviewed-by: Alejandro Piñeiro On 2/1/19 1:02, Ilia Mirkin wrote: > This demonstrates issues on nv4x, which will use a different layout for > POT vs NPOT sizes. > > Signed-off-by: Ilia Mirkin > --- > tests/fbo/fbo-3d.c | 31 +++

Re: [Piglit] [PATCH] fbo-3d: test both POT and NPOT depths

2019-01-02 Thread apinheiro
On 2/1/19 16:09, Ilia Mirkin wrote: > On Wed, Jan 2, 2019 at 5:21 AM apinheiro wrote: >> I have a nitpick comment below. You can ignore it in any case: >> >> Reviewed-by: Alejandro Piñeiro >> >> On 2/1/19 1:02, Ilia Mirkin wrote: >>> This demonstrates

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread apinheiro
On 24/1/19 12:28, Lionel Landwerlin wrote: I'm not sure whether my understanding of block-layout-location.vk_shader_test is correct. Is the expectation that the location of %name (0) is added to the location of its field (a, b, c, d)? Not sure if added is the proper word, but derived. So for

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread apinheiro
onel On 24/01/2019 13:17, apinheiro wrote: On 24/1/19 12:28, Lionel Landwerlin wrote: I'm not sure whether my understanding of block-layout-location.vk_shader_test is correct. Is the expectation that the location of %name (0) is added to the location of its field (a, b, c, d)? Not su

Re: [Piglit] [PATCH] arb_shading_language_420pack: test invalid function return type

2019-02-22 Thread apinheiro
Perhaps a spec quote? With or without it: Reviewed-by: Alejandro Piñeiro On 21/2/19 12:50, Tapani Pälli wrote: Extension adds implicit conversion for return types. This test checks that driver does not incorrectly allow invalid return type. Signed-off-by: Tapani Pälli --- .../implicit-conv

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

2019-02-22 Thread apinheiro
On 22/2/19 15:51, Andres Gomez wrote: The property is supported by most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez It is really realistic to set 79 as

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

2019-02-23 Thread apinheiro
On 22/2/19 21:03, Ian Romanick wrote: On 2/22/19 8:25 AM, apinheiro wrote: On 22/2/19 15:51, Andres Gomez wrote: The property is supported by most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc

Re: [Piglit] [PATCH 00/63] ARB_gl_spirv full series

2019-03-02 Thread apinheiro
One of the bit advantages of MR is that you can keep updating big series (ie: rebases against master) without  spamning the list with tons of patches. So now that piglit MR got enabled, I have just created one for it. Consider this big series abandoned, and if anyone want to help with the revie

[Piglit] [MR] ARB_gl_spirv full series

2019-03-02 Thread apinheiro
https://gitlab.freedesktop.org/mesa/piglit/merge_requests/1 MR equivalent to this: https://lists.freedesktop.org/archives/piglit/2019-February/025762.html But rebased against master, and with some tweaks on the patches. At the point of this MR being created, the detailed overview on that email

Re: [Piglit] [PATCH] tests/deqp: use --deqp-case when generating case-list

2019-06-06 Thread apinheiro
I have realized that this solution have a big problem. You can pass extra args to deqp, so several people are already using it to pass --deqp-case through extra args. This patch would affect them. So Im dropping this patch. sorry for the noise. On 6/6/19 14:48, Alejandro Piñeiro wrote: Withou

Re: [Piglit] [PATCH] ssbo: fix min/max tests to specify std430

2019-06-26 Thread apinheiro
Reviewed-by: Alejandro Piñeiro On 26/6/19 4:15, Dave Airlie wrote: From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. This fixes the tests on softpipe --- .../execution/ssbo-atomicMax-int.shader_

Re: [Piglit] [PATCH] ssbo/shared: fix min/max tests to specify std430

2019-06-26 Thread apinheiro
Reviewed-by: Alejandro Piñeiro On 26/6/19 4:23, Dave Airlie wrote: From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. --- .../execution/shared-atomicMax-int.shader_test | 2 +- .

Re: [Piglit] [PATCH] arb_get_program_binary: test restore of SSO program

2019-07-11 Thread apinheiro
Reviewed-by: Alejandro Piñeiro On 11/7/19 2:38, Timothy Arceri wrote: This tests that a restored SSO doesn't fail validation once restored. This was happening in Mesa because we weren't storing the state of the program parameter PROGRAM_SEPARABLE. --- tests/opengl.py