On 22/2/19 21:03, Ian Romanick wrote:
On 2/22/19 8:25 AM, apinheiro wrote:
On 22/2/19 15:51, Andres Gomez wrote:
The property is supported by most of the editors, but not all:
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
Cc: Eric Engestrom <e...@engestrom.ch>
Cc: Eric Anholt <e...@anholt.net>
Signed-off-by: Andres Gomez <ago...@igalia.com>
It is really realistic to set 79 as max_line_length for piglit? Although
on mesa that limit is usually well respected, I found several source
files on piglit that are really loose on that limit, and Im not sure it
was considered as an error/problem.
A lot of patches land in piglit unreviewed. ;) I prefer lines < 80, but
there's always room for exceptions.
Fair enough, then I guess that I was assuming a looser rule that didn't
exist. Let's set then as 79, and let anyone else thinking that it's too
small complaining on the practice:
Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com>
---
.editorconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/.editorconfig b/.editorconfig
index c614fcca7..e0f13a949 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -4,15 +4,19 @@ root = true
indent_style = space
indent_size = 4
trim_trailing_whitespace = true
+max_line_length = 79
[*.{c,cpp,h,hpp}]
indent_style = tab
tab_width = 8
+max_line_length = 78
[*.{cmake,txt}]
indent_style = tab
tab_width = 8
+max_line_length = 78
[{README,HACKING}]
indent_style = tab
tab_width = 8
+max_line_length = 78
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
