Re: [Piglit] [PATCH] fbo: add a few quirk-tests for format-emulation

2018-10-26 Thread Erik Faye-Lund
On Thu, 2018-10-25 at 14:39 +0100, Emil Velikov wrote: > On Thu, 25 Oct 2018 at 11:07, Erik Faye-Lund > wrote: > > > > On Wed, 2018-10-24 at 16:32 +0100, Emil Velikov wrote: > > > Hi Erik, > > > > > > A bit of an open question, do we want this test on GLES? If yes, > > > see > > > the GLES > > >

[Piglit] [PATCH v2 0/6] port s3tc tests to gles2

2018-10-26 Thread Erik Faye-Lund
Here's version 2 of this series. Changes since v1: - Added a "_gles2"-suffix to the executable-names, to avoid name collisions with the desktop gl opens. - Avoid running parts of the test that calls glGetTexLevelParameteriv on gles 3.0 and below. To avoid too much churn in a single patch, the

[Piglit] [PATCH v2 6/6] s3tc-errors: port to gles20

2018-10-26 Thread Erik Faye-Lund
The glGetTexLevelParameteriv-function wasn't added to gles before gles31, so let's just skip those tests on earlier versions. This allows us to also run this test on gles20. Signed-off-by: Erik Faye-Lund --- tests/texturing/s3tc-errors.c | 51 ++- 1 file changed,

[Piglit] [PATCH v2 1/6] texturing: make sure s3tc tests require GL 1.1

2018-10-26 Thread Erik Faye-Lund
The EXT_texture_compression_s3tc spec lists that it requires OpenGL 1.1, not 1.0 like some of these list. In reality, this probably doesn't make a huge difference, as OpenGL 1.0 hardware/drivers are pretty much extinct, but let's just get it right to avoid confusion. Signed-off-by: Erik Faye-Lund

[Piglit] [PATCH v2 5/6] s3tc-errors: port to gles31

2018-10-26 Thread Erik Faye-Lund
This specification is also supported on gles2, so let's add support for gles31 to the test also. Sadly, because gles2 doesn't support glGetCompressedTexImage, we can't easily support the test-cases that re-uploads compressed data. Disabling them and keeping the others are better than nothing, so l

[Piglit] [PATCH v2 2/6] texturing: use piglit_draw_rect_tex instead of glBegin/glEnd

2018-10-26 Thread Erik Faye-Lund
This will make it easier to port these tests to gles. Signed-off-by: Erik Faye-Lund --- tests/texturing/s3tc-teximage.c| 9 ++--- tests/texturing/s3tc-texsubimage.c | 9 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/tests/texturing/s3tc-teximage.c b/tests/text

[Piglit] [PATCH v2 4/6] s3tc-texsubimage: port to gles2

2018-10-26 Thread Erik Faye-Lund
This specification is also supported on gles2, so let's add support for gles2 to the test also. Signed-off-by: Erik Faye-Lund --- tests/texturing/CMakeLists.gles2.txt | 1 + tests/texturing/s3tc-texsubimage.c | 48 2 files changed, 49 insertions(+) diff --git a/t

[Piglit] [PATCH v2 3/6] s3tc-teximage: port to gles2

2018-10-26 Thread Erik Faye-Lund
This specification is also supported on gles2, so let's add support for gles2 to the test also. Signed-off-by: Erik Faye-Lund --- tests/texturing/CMakeLists.gles2.txt | 5 +++ tests/texturing/s3tc-teximage.c | 48 2 files changed, 53 insertions(+) create mode

Re: [Piglit] [PATCH] gl-1.0: Bitmap test that draws zelda hearts.

2018-10-26 Thread kusmabite
On Fri, 2018-05-11 at 13:38 -0700, Laura Ekstrand wrote: > --- > tests/opengl.py| 1 + > tests/spec/gl-1.0/CMakeLists.gl.txt| 1 + > tests/spec/gl-1.0/bitmap-heart-dance.c | 219 > + > 3 files changed, 221 insertions(+) > create mode

Re: [Piglit] [PATCH] glsl/frexp: fix the incorrect expected values

2018-10-26 Thread andrey simiklit
Hello, Thanks a lot for reviewing. Regards, Andrii. On Fri, Oct 26, 2018 at 3:23 PM Haehnle, Nicolai wrote: > On 24.10.18 14:52, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > I guess that this test has the incorrect expected values. > > For instance the test expects that e

Re: [Piglit] [PATCH v2 1/6] texturing: make sure s3tc tests require GL 1.1

2018-10-26 Thread Emil Velikov
On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund wrote: > > The EXT_texture_compression_s3tc spec lists that it requires > OpenGL 1.1, not 1.0 like some of these list. > > In reality, this probably doesn't make a huge difference, as > OpenGL 1.0 hardware/drivers are pretty much extinct, but let's > ju

[Piglit] [PATCH v2 7/6] texturing: run gles2 variants as well

2018-10-26 Thread Erik Faye-Lund
It's nice if these tests also run automatically, so let's add them to opengl.py. Signed-off-by: Erik Faye-Lund --- Yeah, so Ilia pointed out on IRC that it would be a good idea to hook these up so they run automatically as well. So here's an additional patch for that. If desired, I can squash the

Re: [Piglit] [PATCH v2 1/6] texturing: make sure s3tc tests require GL 1.1

2018-10-26 Thread Erik Faye-Lund
On Fri, 2018-10-26 at 16:21 +0100, Emil Velikov wrote: > On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund > wrote: > > > > The EXT_texture_compression_s3tc spec lists that it requires > > OpenGL 1.1, not 1.0 like some of these list. > > > > In reality, this probably doesn't make a huge difference, a

Re: [Piglit] [PATCH] fbo: add a few quirk-tests for format-emulation

2018-10-26 Thread Emil Velikov
On Fri, 26 Oct 2018 at 12:35, Erik Faye-Lund wrote: > > On Thu, 2018-10-25 at 14:39 +0100, Emil Velikov wrote: > > On Thu, 25 Oct 2018 at 11:07, Erik Faye-Lund > > wrote: > > > > > > On Wed, 2018-10-24 at 16:32 +0100, Emil Velikov wrote: > > > > Hi Erik, > > > > > > > > A bit of an open question,

Re: [Piglit] [PATCH v2 1/6] texturing: make sure s3tc tests require GL 1.1

2018-10-26 Thread Emil Velikov
On Fri, 26 Oct 2018 at 16:39, Erik Faye-Lund wrote: > > On Fri, 2018-10-26 at 16:21 +0100, Emil Velikov wrote: > > On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund > > wrote: > > > > > > The EXT_texture_compression_s3tc spec lists that it requires > > > OpenGL 1.1, not 1.0 like some of these list. >

Re: [Piglit] [PATCH v2 3/6] s3tc-teximage: port to gles2

2018-10-26 Thread Emil Velikov
Hi Erik, On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund wrote: > +#ifdef PIGLIT_USE_OPENGL > + > piglit_ortho_projection(piglit_width, piglit_height, GL_FALSE); > + > +#else // PIGLIT_USE_OPENGL_ES2 > + > + tex_program = piglit_build_simple_program(vs_source, fs_source); > + gl