Hi Erik, On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund <erik.faye-l...@collabora.com> wrote:
> +#ifdef PIGLIT_USE_OPENGL > + > piglit_ortho_projection(piglit_width, piglit_height, GL_FALSE); > + > +#else // PIGLIT_USE_OPENGL_ES2 > + > + tex_program = piglit_build_simple_program(vs_source, fs_source); > + glUseProgram(tex_program); > + GLint proj_loc = glGetUniformLocation(tex_program, "proj"); > + piglit_ortho_uniform(proj_loc, piglit_width, piglit_height); > + I cannot spot anything wrong with the updated series, so sharing a wondering thought. Should we shouldn't fold this ES2 solution within the piglit_ortho_projection it already already supports GLES1. The helper library gets built in four flavours (gl, gles1, gles2, gles3), so the usual #ifdef approach should be just fine. There are some existing users of piglit_ortho_uniform, but t wouldn't bother with them. HTH Emil _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
