Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Sagar Ghuge
Thank you for such a constructive comments/suggestions. I took a reference from existing depth_clamp tests. I will apply your suggestions to both the new tests and existing tests and send next revision. Thank you so much for reviewing the series. On 08/22/2018 01:37 PM, Ian Romanick wrote: >

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Ian Romanick
On 08/21/2018 05:05 PM, Sagar Ghuge wrote: > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt | 1 + > .../CMakeLists.gl.txt | 15 ++ > .../amd_depth_clamp_separate/CMakeLists.txt

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Marek Olšák
The other two tests should also do: piglit_require_extension("GL_AMD_depth_clamp_separate"); Marek On Tue, Aug 21, 2018 at 8:05 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt |

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-21 Thread Marek Olšák
Tested-by: Marek Olšák Thanks. The tests pass on radeonsi. Marek On Tue, Aug 21, 2018 at 8:05 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt | 1 + > .../CMakeLists.gl.txt

[Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-21 Thread Sagar Ghuge
Signed-off-by: Sagar Ghuge --- tests/opengl.py | 8 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 15 ++ .../amd_depth_clamp_separate/CMakeLists.txt | 1 + .../depth-clamp-far-status.c