[Piglit] [PATCH 3/4] framework/test: Use relative paths in the filename for VkRunnerTest

2018-11-07 Thread Neil Roberts
Previously the filename was the full path to the test. This would break if the filename was serialized and installed to a different location. The code is based on what is done for ASMParserTest. However I have a suspicion that this won’t work for running generated tests from an out-of-tree build.

[Piglit] [PATCH 1/4] Cmake: Install vk_shader_test files

2018-11-07 Thread Neil Roberts
--- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f7d23fee1..b416cacb2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -537,7 +537,7 @@ install ( install ( DIRECTORY tests DESTINATION ${PIGLIT_INSTA

[Piglit] [PATCH 4/4] framework: Add support for serializing VkRunner tests

2018-11-07 Thread Neil Roberts
--- framework/profile.py| 4 +++- tests/CMakeLists.no_api.txt | 11 +++ tests/find_static_tests.py | 5 - tests/serializer.py | 7 ++- 4 files changed, 24 insertions(+), 3 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 8d6fd0706..b5

[Piglit] [PATCH 2/4] framework/test: Set the filename property on VkRunnerTest

2018-11-07 Thread Neil Roberts
This will be retrieved when generating the XML profile for the VkRunner tests. --- framework/test/piglit_test.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py index c80e355d1..4d3008139 100644 --- a/framework/test/piglit_test.py

[Piglit] [PATCH 0/4] Support serialization of VkRunner tests

2018-11-07 Thread Neil Roberts
As requested by Dylan in the review for the patch series to add VkRunner as an external dependency¹, this series adds the missing serialization support. 1. https://lists.freedesktop.org/archives/piglit/2018-November/025336.html Neil Roberts (4): Cmake: Install vk_shader_test files framework/t

Re: [Piglit] [PATCH v4] framework: Add a vulkan tests profile

2018-11-07 Thread Dylan Baker
Quoting Neil Roberts (2018-11-05 02:04:44) > This searches for files named *.vk_shader_test in the tests/vulkan > directory and runs them with VkRunner. VkRunner is executed as an > external dependency. It is found either with the vkrunner:bin config > option, by setting the PIGLIT_VKRUNNER_BINARY

[Piglit] [PATCH v2 01/15] nv_conditional_render: use common fill_tex-helper

2018-11-07 Thread Erik Faye-Lund
Instead of repeating this function in all these tests, let's add a common helper function instead. Signed-off-by: Erik Faye-Lund --- .../nv_conditional_render/CMakeLists.gl.txt | 8 ++-- .../nv_conditional_render/blitframebuffer.c | 18 +--- tests/spec/nv_conditional_render/common.c

[Piglit] [PATCH v2 09/15] nv_conditional_render: add helpers to compile useful programs

2018-11-07 Thread Erik Faye-Lund
--- tests/spec/nv_conditional_render/common.c | 36 +++ tests/spec/nv_conditional_render/common.h | 6 2 files changed, 42 insertions(+) diff --git a/tests/spec/nv_conditional_render/common.c b/tests/spec/nv_conditional_render/common.c index f47c9939d..f17d10cc6 100644

[Piglit] [PATCH v2 12/15] nv_conditional_render: port copyteximage-test to gles2

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles2, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + .../spec/nv_conditional_render/copyteximage.c | 28

[Piglit] [PATCH v2 05/15] nv_conditional_render: factor out query-helpers

2018-11-07 Thread Erik Faye-Lund
These tests does a lot of common operations, so let's factor those out into dedicated helpers. This will help us port these tests to gles. Signed-off-by: Erik Faye-Lund --- .../nv_conditional_render/CMakeLists.gl.txt | 14 .../begin-while-active.c | 5 +-- tests/

[Piglit] [PATCH v2 08/15] nv_conditional_render: port trivial tests to gles2

2018-11-07 Thread Erik Faye-Lund
These two tests are trivial to port to GLES 2. So let's do this to get some test-coverage for nv_conditional_render on OpenGL ES. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 2 ++ tests/spec/nv_conditional_render/CMakeLists.gles2.txt | 6 ++ test

[Piglit] [PATCH v2 07/15] nv_conditional_render: prefer GL_EXT_occlusion_query_boolean

2018-11-07 Thread Erik Faye-Lund
This is the first step in porting these tests to GLESi 2, where GL_EXT_occlusion_query_boolean is the only such extension available. Signed-off-by: Erik Faye-Lund --- tests/spec/nv_conditional_render/common.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[Piglit] [PATCH v2 11/15] nv_conditional_render: port clear-test to gles2

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles2, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + tests/spec/nv_conditional_render/clear.c | 19

[Piglit] [PATCH v2 14/15] nv_conditional_render: port generatemipmap-test to gles2

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles2, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + .../nv_conditional_render/generatemipmap.c| 26

[Piglit] [PATCH v2 03/15] nv_conditional_render: drop mipmapping from tests that doesn't care

2018-11-07 Thread Erik Faye-Lund
These tests won't use the mipmaps anyway, so generating them is just a waste of time, and it makes porting to GLES a bit more involved than it needs to be. Signed-off-by: Erik Faye-Lund --- tests/spec/nv_conditional_render/blitframebuffer.c | 4 +--- tests/spec/nv_conditional_render/copyteximage

[Piglit] [PATCH v2 15/15] nv_conditional_render: port vertex_array-test to gles2

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles2, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + .../spec/nv_conditional_render/vertex_array.c | 24

[Piglit] [PATCH v2 00/15] port NV_conditional_render tests to GLES 2/3

2018-11-07 Thread Erik Faye-Lund
OK, so here's round 2. The notable difference between this and v1, is that this version works on GLES 2, with the exception of the blitframebuffer test, which requires GLES 3. When doing this porting, I realized that I was depending on a bug in Mesa, where GL_SAMPLES_PASSED was allowed in GLES 3 e

[Piglit] [PATCH v2 04/15] nv_conditional_render: do not depend on float-textures

2018-11-07 Thread Erik Faye-Lund
OpenGL is pretty flexible in how you can upload textures, but OpenGL ES isn't. Let's change this to use unsigned byte texture components instead of floats, to increase compatiblity. Signed-off-by: Erik Faye-Lund --- tests/spec/nv_conditional_render/blitframebuffer.c | 3 ++- tests/spec/nv_condit

[Piglit] [PATCH v2 10/15] nv_conditional_render: port blitframebuffer-test to gles3

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles3, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + .../nv_conditional_render/blitframebuffer.c | 37

[Piglit] [PATCH v2 13/15] nv_conditional_render: port copytexsubimage-test to gles2

2018-11-07 Thread Erik Faye-Lund
This test can relatively easily be ported to gles2, so let's do that for better test-coverage. Signed-off-by: Erik Faye-Lund --- tests/opengl.py | 1 + .../CMakeLists.gles2.txt | 1 + .../nv_conditional_render/copytexsubimage.c | 28

[Piglit] [PATCH v2 06/15] nv_conditional_render: wrap up query gen/deletion

2018-11-07 Thread Erik Faye-Lund
By wrapping these up, we can use different GL extensions that doesn't have aliases on the core OpenGL functions. This is going to be useful when porting the tests to GLES. Signed-off-by: Erik Faye-Lund --- .../spec/nv_conditional_render/begin-while-active.c | 4 ++-- tests/spec/nv_conditional

[Piglit] [PATCH v2 02/15] nv_conditional_render: fixup test-requirements

2018-11-07 Thread Erik Faye-Lund
These tests shouldn't require OpenGL 2.0; NV_conditional_render itself requires either OpenGL 1.5 or ARB_occlusion_query, but requiring NV_conditional_render should be enough for these tests. Signed-off-by: Erik Faye-Lund --- tests/spec/nv_conditional_render/begin-while-active.c | 3 --- tests/s

Re: [Piglit] [PATCH 04/10] nv_conditional_render: port tests to gles3

2018-11-07 Thread Erik Faye-Lund
On Wed, 2018-11-07 at 10:18 +0100, Erik Faye-Lund wrote: > On Wed, 2018-11-07 at 09:35 +0100, Erik Faye-Lund wrote: > > On Tue, 2018-11-06 at 18:11 -0500, Ilia Mirkin wrote: > > > On Tue, Nov 6, 2018 at 1:38 PM Erik Faye-Lund > > > wrote: > > > > On Tue, 2018-11-06 at 13:25 -0500, Ilia Mirkin wrot

Re: [Piglit] [PATCH 04/10] nv_conditional_render: port tests to gles3

2018-11-07 Thread Erik Faye-Lund
On Wed, 2018-11-07 at 09:35 +0100, Erik Faye-Lund wrote: > On Tue, 2018-11-06 at 18:11 -0500, Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 1:38 PM Erik Faye-Lund > > wrote: > > > On Tue, 2018-11-06 at 13:25 -0500, Ilia Mirkin wrote: > > > > On Tue, Nov 6, 2018 at 1:14 PM Erik Faye-Lund > > > > w

Re: [Piglit] [PATCH 04/10] nv_conditional_render: port tests to gles3

2018-11-07 Thread Erik Faye-Lund
On Tue, 2018-11-06 at 18:11 -0500, Ilia Mirkin wrote: > On Tue, Nov 6, 2018 at 1:38 PM Erik Faye-Lund > wrote: > > On Tue, 2018-11-06 at 13:25 -0500, Ilia Mirkin wrote: > > > On Tue, Nov 6, 2018 at 1:14 PM Erik Faye-Lund > > > wrote: > > > > On Mon, 2018-11-05 at 23:56 -0500, Ilia Mirkin wrote: >