Re: [Pharo-users] DNU on materializing a fueled out exception

2017-01-22 Thread Ben Coman
You needed to change the status from 'Work Needed' to 'Resolved (Fix Review Needed)', which I see Andrei has done and the monkey has run. cheers -ben On Mon, Jan 23, 2017 at 1:15 AM, Holger Freyther wrote: > > > On 28 Dec 2016, at 13:44, Mariano Martinez Peck > wrote: > > > > I am not asking s

Re: [Pharo-users] DNU on materializing a fueled out exception

2017-01-22 Thread Holger Freyther
> On 28 Dec 2016, at 13:44, Mariano Martinez Peck wrote: > > I am not asking someone to fix what I think is important but I am still > struggling to grasp the process of getting a bugfix into Pharo5. > > > But are you sure there will be a bugfix release of 5.0? Because I am not > sure ab

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-28 Thread Mariano Martinez Peck
On Wed, Dec 28, 2016 at 7:22 AM, Holger Freyther wrote: > > > On 19 Dec 2016, at 08:53, Holger Freyther wrote: > > Good Morning Everyone, > > > > So it looks like now it should create a debug session first and then > pass it to the debugger? I think loading new fuel in Pharo3.x is still > possib

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-28 Thread Henrik Nergaard
[Pharo-users] DNU on materializing a fueled out exception > On 19 Dec 2016, at 08:53, Holger Freyther wrote: Good Morning Everyone, > So it looks like now it should create a debug session first and then pass it > to the debugger? I think loading new fuel in Pharo3.x is still possible so >

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-28 Thread Holger Freyther
> On 19 Dec 2016, at 08:53, Holger Freyther wrote: Good Morning Everyone, > So it looks like now it should create a debug session first and then pass it > to the debugger? I think loading new fuel in Pharo3.x is still possible so > maybe it is best to re-add that protocol? I hope all of you

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Mariano Martinez Peck
I personally think Denis has raised an important remark. Fuel responsibility here should stop at supporting post materialization actions. So...I do agree that this code is ONE particular usage of Fuel and such code should likely be packaged with the tool and not with Fuel . On Mon, Dec 19, 2016 at

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Tudor Girba
Hi, > On Dec 19, 2016, at 6:34 PM, Denis Kudriashov wrote: > > Hi. > > 2016-12-19 18:08 GMT+01:00 Max Leske : > I suppose that functionality should be resolved via FuelPlatform. Something > like > > FLPlatform current > openDebuggerOn: Processor activeProcess > context: materializ

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Denis Kudriashov
2016-12-19 18:34 GMT+01:00 Denis Kudriashov : > 016-12-19 18:08 GMT+01:00 Max Leske : > >> I suppose that functionality should be resolved via FuelPlatform. >> Something like >> >> FLPlatform current >> openDebuggerOn: Processor activeProcess >> context: materialization root >> label: 'External st

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Denis Kudriashov
Hi. 2016-12-19 18:08 GMT+01:00 Max Leske : > I suppose that functionality should be resolved via FuelPlatform. > Something like > > FLPlatform current > openDebuggerOn: Processor activeProcess > context: materialization root > label: 'External stack' > Is it really nice way to do it? I mean why

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Max Leske
I suppose that functionality should be resolved via FuelPlatform. Something like FLPlatform current openDebuggerOn: Processor activeProcess context: materialization root label: 'External stack' That method can then be overriden accoring to the platform. https://github.com

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Andrei Chis
Hi Holgen, This should be fixed by updating #serializeTestFailureContext:toFileNamed:. The API of the debugger was refactored in Pharo 5 and it seems like #serializeTestFailureContext:toFileNamed: was not updated in Pharo 5. Created an issue case 19477

Re: [Pharo-users] DNU on materializing a fueled out exception

2016-12-19 Thread Mariano Martinez Peck
On Mon, Dec 19, 2016 at 4:53 AM, Holger Freyther wrote: > Hi, > > I showed Pharo to a friend and wanted to show the nice feature of fueling > out an exception and then using FLMaterializer > class>>#materializeFromFileNamed: > to load it back and get a debugger up. In Pharo5 I am presented a DNU

[Pharo-users] DNU on materializing a fueled out exception

2016-12-18 Thread Holger Freyther
Hi, I showed Pharo to a friend and wanted to show the nice feature of fueling out an exception and then using FLMaterializer class>>#materializeFromFileNamed: to load it back and get a debugger up. In Pharo5 I am presented a DNU instead. The DNU is on GTGenericStackDebugger as it doesn't unders