this logic into a separate function,
it is possible to simplify the code. OperatorUpd function is too complex.
Also better to add comments to the tests.
The rest seems good.
PS I here thought it would be possible to print operators that have been
changed?
--
Yury Zhuravlev
Postgres Professional: http
is or
that function as static. I am not sure that such a list ever be complete.
In Postgres no clear boundaries between the subsystems.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq
]
GetXLogOldestLSNPtr(void)
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ility.
Options "year"/"isoyear" may confuse the users.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http:
different signature.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andres Freund wrote:
I plan to commit something like this, unless there's very loud protest
from Peter's side.
I agree. Peter proposal can be considered in a separate thread.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Michael Paquier wrote:
FWIW, when compiling with MS 2015 using the set of perl scripts I am
not seeing this compilation error...
This error not in build stage but in GIN regresion tests. CMake nothing to
do with.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The
attached (small and simple).
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Companydiff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c
index 06ba9cb..30113d0 100644
--- a/src/backend/access/gin/ginbtree.c
+++ b/sr
code for CMake.
PS This hack gives a slight inconvenience.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
://stackoverflow.com/questions/1193020/php-postgresql-check-if-a-prepared-statement-already-exists
What do you think about adding NOT EXIST functionality to PREPARE?
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing
Fabrízio de Royes Mello wrote:
I think you meant IF NOT EXISTS, right?
Thanks, you right.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
Andres Freund wrote:
you'd still need to compare the
statement somehow
You right, I think about that as syntax sugar. Maybe with some performance
increase but hardly. We can save on a round trip.
It may be necessary to add an index on the field "statement"?
Thanks.
--
Fabrízio de Royes Mello wrote:
You already have a patch? If yes I'm glad to review it.
If the community is not against it, I'll do it quickly. Changing the syntax
is the risk. In addition, we have already missed 9.6.
Thanks.
--
Yury Zhuravlev
Postgres Professi
Yury Zhuravlev wrote:
It may be necessary to add an index on the field "statement"?
Sorry. Said nonsense.
We need to understand what kind of behavior should be if the name is the
same but query_string not? Replace?
Thanks.
--
Yury Zhuravlev
Postgres Professi
Fabrízio de Royes Mello wrote:
Skip error if already exists when catched in
src/backend/commands/prepare.c isn't enough?
I think that's enough. And expand PrepareStmt of course.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
-
You already have a patch? If yes I'm glad to review it.
Please. Patch in attachment.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Companydiff --git a/src/backend/commands/prepare.c b/src/backend/commands/prepare.c
index cec37ce..63d164f 100644
Yury Zhuravlev wrote:
You already have a patch? If yes I'm glad to review it.
Please. Patch in attachment.
Fix bug, forgot change attr number in parser.
And, I forgot example:
PREPARE usrrptplan (int) IF NOT EXISTS AS
SELECT * FROM pg_operator;
PREPARE
New patch in attac
like it:
Done.
3) There are no regression tests
Done.
4) There are no docs
Done.
Regards.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Companydiff --git a/doc/src/sgml/ref/prepare.sgml b/doc/src/sgml/ref/prepare.sgml
index dbce8f2..c52879f 100644
Fabrízio de Royes Mello wrote:
You're correct. Yury please add your patch to the next commitfest.
Done. But I do not have restrictions as part of our PostgresPro distr. I
think this patch will be in production a month.
Big Thanks.
--
Yury Zhuravlev
Postgres Professional:
Fabrízio de Royes Mello wrote:
I got an error when build this patch.
Thanks for review and tests!
I'm working on it. Without ecpg everything works fine.
In ecpg we have black perl magic and special rules for PREPARE.
The error is in perl script.
Regards
--
Yury Zhuravlev
Pos
Fabrízio de Royes Mello wrote:
I got an error when build this patch.
I fix it! All tests pass (include ecpg tests).
Patch in attachment.
Thanks.
PS Who use ecpg? For me it's like hell.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Compan
Michael Meskes wrote:
More than you think.
I doubt you want to propose removing features that make developing new
features harder, or do you? :)
I want to understand the situation. You may want to make the build ecpg
optional. Personally, I want to.
--
Yury Zhuravlev
Postgres Professional
compatibility IMHO.
But I will not insist. My problem with ecpg I decided.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
message. But in tail we have
variable length array with parameters.
3. Detect prefix of prepared name. For example "__". Effects think clear.
I would like to know the community opinion on this matter.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
T
sy to implement.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Tom Lane wrote:
because it would break applications
I still do not agree with this. The app expects that there can be no
mistakes and it does not happen.
I can not invent a situation when it is breaks.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian
version seems to
me simplify build under Windows.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
seems silly.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Craig Ringer wrote:
On 27 January 2016 at 00:16, Yury Zhuravlev
wrote:
It says more about the modules, and not about libpq. Using
gendef.pl for this library in the light of the development of my
CMake build seems silly.
For what it's worth I personally agree. I'd rather have
P
Michael Paquier wrote:
Many companies use it, including mine, and likely EDB.
Ok, why? I wonder why it is?
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
done. Yesterday made the work of the gendef.pl under CMake.
Current issues:
https://github.com/stalkerg/postgres_cmake/issues
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
headers, an old gcc fork, and has had
some pretty nasty bugs.
You about MinGW or MinGW64?
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
Craig Ringer wrote:
I strongly disagree. MSVC is a high quality compiler and the
primary tool for the platform.
Ok. And we not suport MSVC2015 now. Either we support the platform normally
or throwing it.
Now it all looks like a zombie.
--
Yury Zhuravlev
Postgres Professional: http
Michael Paquier wrote:
Well, 2015 is not making things easy visibly by not providing direct
ways to get locale information.
pgwin32_putenv broken too...
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list
7;t understand why the patch has not been commited yet. It seems to me
not so important !! or ! = 0, the solution is all that matters.
Thanks!
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@po
Robert Haas wrote:
So, is it being pulled in indirectly by some other #include?
I can double-check it tomorrow.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
Yury Zhuravlev wrote:
Robert Haas wrote:
So, is it being pulled in indirectly by some other #include?
I can double-check it tomorrow.
I've found who include stdbool.h and think it is inevitable for MSVC2013
and MSVC2015.
In port/win32.h we inlcude process.h.
In process.h inc
Tom Lane wrote:
Well, the thing that is scaring me here is allowing a platform-specific
definition of "bool" to be adopted.
You say that something strange. bool from stdbool.h is C99 standart.
A different behavior would be regarded as a compiler error.
--
Yury Zhuravlev
Postgres Pr
cro.
In C99 cast to bool return 0 or 1 only. In older compilers nothing changes
(Now the code is designed to "char == char").
I think this is a good option. But of course to write bool and use char
strange.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The
Andres Freund wrote:
Did you read what I wrote?
Read.
That's not correct for char booleans, because the can have different bits set.
Current code support this behavior. But to shoot his leg becomes easier.
!= 0 much better of course.
Thanks.
--
Yury Zhuravlev
Postgres Professional:
's not really needed. Without that, I'd be worried that
this cure is worse than the disease because it breaks cases that
weren't broken befor
I think I have already proposed to drop MSVC support? :)
Too many problems due to of one compiler...
PS Cry from the heart. I work too
ternal CMake error, TryCompile generation of cmake failed
which I have no idea whether they are an actual problem or just
"configure" noise
Can you send issue into github?
https://github.com/stalkerg/postgres_cmake/issues
--
Yury Zhuravlev
Postgres Professional: http://www.post
to github tracker.
https://github.com/stalkerg/postgres_cmake/issues
Big thanks!
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscrip
ninja and
etc because CMake generate files for another make systems. On this basis,
to CMake can not meet the same requirements for version as GNU Make. It is
quite another thing.
PS Special for Postgres in CMake 3.6 I implemented features for replace
gen_def.pl script under MSVC.
https://gitlab.k
ittle benefit
in this whole endeavor.
I fully agree with this. Although I still leave the probability that for a
while (couple of months) CMake will coexist with autoconf solely for
testing and verification.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Pos
.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ain me why?
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Amit Kapila wrote:
On Thu, Aug 25, 2016 at 7:55 PM, Yury Zhuravlev
wrote:
Hello hackers.
I have a small question. While working on an incremental
backup I noticed a
strange thing.
Newly created index is contains the invalid LSN (0/0).
Exmaple: ...
For some of the indexes like btree which
e LSN with last backup LSN. For my page tracking system (ptrack) it is
secondary cheks but for classic pg_arman algorithm it is main approach.
If Invalid LSN will be realy sign of broken page header it help for
third-party applications.
--
Yury Zhuravlev
Postgres Professional:
cmake/issues
If you can only test CMake for Ubuntu x86_64 that it is not necessary.
If I not fully understand you - sorry.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or
msys has not passed
some tests)
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
x27;s all I have for now. Looking forward to seeing some progress here.
I merged master to my branch and I spent time to porting all changes. I
hope send patch in the weekend without terrible flaws.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Co
nsist, just I trying to find the easiest way.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ird
party tools must use maximum same api what in backend.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Stas Kelvich wrote:
On 17 Sep 2016, at 20:21, Yury Zhuravlev
wrote:
Michael Paquier wrote: ...
Tried to generate Xcode project out of cmake, build fails on
genbki.pl: can't locate Catalog.pm (which itself lives in
src/backend/catalog/Catalog.pm)
Can you try again? On my Xcod
Stas Kelvich wrote:
Tried to generate Xcode project out of cmake, build fails on
genbki.pl: can't locate Catalog.pm (which itself lives in
src/backend/catalog/Catalog.pm)
Thanks again! I have corrected your issue.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Ru
n try this in
cmake-3.7.0-rc1.
Current postgres_cmake is using the modified gendef.pl (use only
stdin/stdout for objtool without any files).
regards,
Yury
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgs
w only one decision - copy-paste.
Without strict politics in this case we will be time to time meet new
persons who ask this or similar question.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgs
ct this patch not to require C code changes.
I suppose separate patches with comments will be best way. I will do it.
I think we can talks about details after that.
Big thanks for your remarks it's very important for me and this "small"
project.
I will try to do all tasks quickly.
that
we'll reject this work.
Who asking about negotiation? I just wanted an explanation for the clear
understanding and nothing more.
Now I know about reasons. Thanks.
regards
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via
ut I'm not sure what Tom Lane will accept this.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ut I'm not sure what Tom Lane will accept this.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
iginal had some changes for building under latest
Windows...(I'm using Ubuntu 16.10, with cmake 3.5).
Thanks for all your works! Can you make push request here:
https://github.com/stalkerg/postgres_cmake
I have rebased (merge) to master and make other important fix.
--
Yury Zhuravlev
Postgr
.
After some time and some updates for MSVC Michael Paquier could not
reproduce my problem but I keep this patch to avoid problems in the
future.
I can check old behavior again and revert all changes if needed and
ofcourse I have plans to make separate patch for this changes.
Thanks!
--
Yury
Michael Paquier wrote:
src/include/port/win32.h:#define putenv(x) pgwin32_putenv(x)
and my MSVC2015 drop down here because pgwin32_putenv has wrong signature.
I hope it is not true now.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent
corresponding item in the input).
regards, tom lane
You're right. I will try to provide a patch as soon as possible.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-ha
New patch version in attachment.
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Companydiff --git a/doc/src/sgml/array.sgml b/doc/src/sgml/array.sgml
index 4385a09..305cabb 100644
--- a/doc/src/sgml/array.sgml
+++ b/doc/src/sgml/array.sgml
ie the implied range runs
from whatever the array lower bound is up to the specified subscript.
[3:4][:5] instead a[3:4][5] at least this is logical. But after what will
result from a[3:4][5]? One element?
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian
I've committed this with a number of revisions, mostly but not entirely
cosmetic.
Thanks Tom!
I feel I still have a lot to learn Postgres to choose the right solution.
Your comments are very valuable.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Pos
Craig Ringer wrote:
If we eventually get a CMake build system conversion that'll
mostly go away too.
I'm working on it. But the build system does not solve the problem of some
hacks. We must nevertheless spend more time for Windows or at least goes to
mingw64 (like ActivePerl).
es on patches to
core infrastructure and on committers.
Maybe someone in the community to appoint a chief for Windows?
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
be good to get help.
Thanks.
PS https://github.com/stalkerg/postgres_cmake
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
.
Thank you for attention.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I do not see this as a problem because we can build Postgres only with one
version of Python (2 or 3).
Or am I missing something?
may be a bit of a kluge
For python developer it is really strange...
PS I see Postgres philosophy - do not touch what works well, even if it
looks terrible.
zeray87 wrote:
Hello guys,
This is my first ever post and here goes my apology for being newbie.
I have been able to build PgAdmin3 after several days of hassle on building
PgAdmin3 using build-wxmsw.bat.
If I remember it right for PgAdminIII needed mingw now.
Thanks.
--
Yury Zhuravlev
.
Current version you can get here:
https://github.com/stalkerg/postgres_cmake
Thanks!
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
of some kind, in perl
that may be a good idea, though perl is not a hard requirement in
source tarballs, and on Windows/MSVC it is.
Only one extra phase (mkdir build). I think it's not so important.
For windows and macosx I used cmake GUI it's so easy.
--
Yury Zhuravlev
Postgres Pr
Michael Paquier wrote:
Personally I am allergic to any kind of UIs for
development, and I am sure not to be the only one on this list.
Andrew Dunstan:
We need this to be scriptable, not using a GUI.
GUI is strong optional feature. Helpful for some tasks.
--
Yury Zhuravlev
Postgres
it has been fixed by
db0f6cad4884bd4c835156d3a720d9a79dbd63a9 commit.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
like the idea of investigating Rust.
I am working on it last few weeks. But it's like seek blocks for new DB. I
don't know how we can insert Rust code into Postgres spaghetti.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent vi
limitations.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
82 matches
Mail list logo
